Re: Review Request 37007: Pass ExecutorID to task-status label decorator hook.

2015-08-03 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37007/#review93963 --- include/mesos/hook.hpp (lines 89 - 90)

Re: Review Request 37007: Pass ExecutorID to task-status label decorator hook.

2015-08-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37007/#review93834 --- Patch looks great! Reviews applied: [37007] All tests passed. -

Re: Review Request 37007: Pass ExecutorID to task-status label decorator hook.

2015-07-31 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37007/ --- (Updated Aug. 1, 2015, 12:24 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37007: Pass ExecutorID to task-status label decorator hook.

2015-07-31 Thread Kapil Arya
On July 31, 2015, 10:22 p.m., Michael Park wrote: src/slave/slave.cpp, lines 2740-2743 https://reviews.apache.org/r/37007/diff/1/?file=1026663#file1026663line2740 Why did this have to move? I guess we want the `update` within the `if (executor == NULL)` statement block to have

Re: Review Request 37007: Pass ExecutorID to task-status label decorator hook.

2015-07-31 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37007/#review93825 --- Patch looks great! Reviews applied: [37007] All tests passed. -

Re: Review Request 37007: Pass ExecutorID to task-status label decorator hook.

2015-07-31 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37007/#review93827 --- include/mesos/hook.hpp (line 89)