Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-11 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/ --- (Updated Aug. 11, 2015, 10:57 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-11 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/#review94941 --- Looking. Minor issues. Please make sure when you fix an issue, you

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-11 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/ --- (Updated Aug. 11, 2015, 5:03 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-11 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/ --- (Updated Aug. 11, 2015, 8:11 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-11 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/#review95052 --- Ship it! Ship It! - Vinod Kone On Aug. 11, 2015, 10:57 p.m.,

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-07 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/ --- (Updated Aug. 7, 2015, 5:54 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-07 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/#review94568 --- Ship it! Ship It! - Vinod Kone On Aug. 7, 2015, 2:56 a.m.,

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-06 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/ --- (Updated Aug. 7, 2015, 2:56 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-06 Thread Anand Mazumdar
On Aug. 7, 2015, 12:21 a.m., Vinod Kone wrote: src/tests/http_api_tests.cpp, line 187 https://reviews.apache.org/r/37082/diff/3-4/?file=1032065#file1032065line187 No CHECK's in test code please. It will crash the program. Use ASSERT_SOME() instead. here and

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/#review94468 --- src/tests/http_api_tests.cpp (line 182)

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/#review94422 --- Patch looks great! Reviews applied: [37080, 36720, 37082] All

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-06 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/ --- (Updated Aug. 6, 2015, 4:26 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-05 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/ --- (Updated Aug. 6, 2015, 5:23 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-05 Thread Anand Mazumdar
On Aug. 5, 2015, 11:52 p.m., Vinod Kone wrote: src/tests/http_api_tests.cpp, line 145 https://reviews.apache.org/r/37082/diff/3/?file=1032065#file1032065line145 don't need to do this anymore now that the default framework info sets the user, right? Yep, it got committed

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-05 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/#review94292 --- Tests look good! Mainly stylistic issues and generous use of

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-04 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/ --- (Updated Aug. 4, 2015, 10:02 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-04 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/ --- (Updated Aug. 5, 2015, midnight) Review request for mesos, Ben Mahler and

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-04 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/ --- (Updated Aug. 4, 2015, 5:15 p.m.) Review request for mesos, Ben Mahler and