Re: Review Request 37106: PortMappingIsolatorProcess shell script can silently fail.

2015-08-05 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37106/#review94208
---


Patch looks great!

Reviews applied: [37106]

All tests passed.

- Mesos ReviewBot


On Aug. 5, 2015, 12:58 a.m., Paul Brett wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37106/
 ---
 
 (Updated Aug. 5, 2015, 12:58 a.m.)
 
 
 Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
 
 
 Bugs: MESOS-3204
 https://issues.apache.org/jira/browse/MESOS-3204
 
 
 Repository: mesos
 
 
 Description
 ---
 
 PortMappingIsolatorProcess shell script can silently fail.
 
 
 Diffs
 -
 
   src/slave/containerizer/isolators/network/port_mapping.cpp 
 8244c345b84108af7fa18d20e71401d6e1a0aeb0 
 
 Diff: https://reviews.apache.org/r/37106/diff/
 
 
 Testing
 ---
 
 sudo make check
 
 
 Thanks,
 
 Paul Brett
 




Re: Review Request 37106: PortMappingIsolatorProcess shell script can silently fail.

2015-08-05 Thread Chi Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37106/#review94260
---

Ship it!


Ship It!

- Chi Zhang


On Aug. 5, 2015, 12:58 a.m., Paul Brett wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37106/
 ---
 
 (Updated Aug. 5, 2015, 12:58 a.m.)
 
 
 Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
 
 
 Bugs: MESOS-3204
 https://issues.apache.org/jira/browse/MESOS-3204
 
 
 Repository: mesos
 
 
 Description
 ---
 
 PortMappingIsolatorProcess shell script can silently fail.
 
 
 Diffs
 -
 
   src/slave/containerizer/isolators/network/port_mapping.cpp 
 8244c345b84108af7fa18d20e71401d6e1a0aeb0 
 
 Diff: https://reviews.apache.org/r/37106/diff/
 
 
 Testing
 ---
 
 sudo make check
 
 
 Thanks,
 
 Paul Brett