Re: Review Request 37147: Timeout perf stat command if it does not complete.

2015-08-05 Thread Cong Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37147/#review94358
---


Why perf stat can timeout here? Since it just executes `sleep $DURATION`. 
Please state it in description

- Cong Wang


On Aug. 5, 2015, 11:25 p.m., Paul Brett wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37147/
 ---
 
 (Updated Aug. 5, 2015, 11:25 p.m.)
 
 
 Review request for mesos and Ben Mahler.
 
 
 Bugs: MESOS-2834
 https://issues.apache.org/jira/browse/MESOS-2834
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Timeout perf stat command if it does not complete.
 
 
 Diffs
 -
 
   src/linux/perf.cpp 5d4cb613cf41e52c605dc89dabe4c29cf8f54c95 
 
 Diff: https://reviews.apache.org/r/37147/diff/
 
 
 Testing
 ---
 
 sudo make check
 
 
 Thanks,
 
 Paul Brett
 




Re: Review Request 37147: Timeout perf stat command if it does not complete.

2015-08-05 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37147/#review94332
---


Bad patch!

Reviews applied: [37147]

Failed command: ./support/apply-review.sh -n -r 37147

Error:
 2015-08-06 00:09:00 URL:https://reviews.apache.org/r/37147/diff/raw/ 
[1484/1484] - 37147.patch [1]
error: patch failed: src/linux/perf.cpp:296
error: src/linux/perf.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Aug. 5, 2015, 11:25 p.m., Paul Brett wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37147/
 ---
 
 (Updated Aug. 5, 2015, 11:25 p.m.)
 
 
 Review request for mesos and Ben Mahler.
 
 
 Bugs: MESOS-2834
 https://issues.apache.org/jira/browse/MESOS-2834
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Timeout perf stat command if it does not complete.
 
 
 Diffs
 -
 
   src/linux/perf.cpp 5d4cb613cf41e52c605dc89dabe4c29cf8f54c95 
 
 Diff: https://reviews.apache.org/r/37147/diff/
 
 
 Testing
 ---
 
 sudo make check
 
 
 Thanks,
 
 Paul Brett