Re: Review Request 37165: Introduced v1 API.

2015-08-10 Thread haosdent huang
> On Aug. 10, 2015, 2:57 p.m., haosdent huang wrote: > > > > haosdent huang wrote: > If the order is > 1. "mv -f ../include/mesos/v1/mesos.pb.cc ../include/mesos/v1" > 2. "mv -f ../include/mesos/v1/mesos.pb.cc v1" > > It would not left mesos.pb.cc in "../include/mesos/v1" >

Re: Review Request 37165: Introduced v1 API.

2015-08-10 Thread haosdent huang
> On Aug. 10, 2015, 2:57 p.m., haosdent huang wrote: > > If the order is 1. "mv -f ../include/mesos/v1/mesos.pb.cc ../include/mesos/v1" 2. "mv -f ../include/mesos/v1/mesos.pb.cc v1" It would not left mesos.pb.cc in "../include/mesos/v1" If the order is 1. "mv -f ../include/mesos/v1/mesos.pb.

Re: Review Request 37165: Introduced v1 API.

2015-08-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37165/#review94746 --- src/Makefile.am (line 244)

Re: Review Request 37165: Introduced v1 API.

2015-08-08 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37165/ --- (Updated Aug. 8, 2015, 11:43 p.m.) Review request for mesos, Anand Mazumdar, Be

Re: Review Request 37165: Introduced v1 API.

2015-08-08 Thread Benjamin Hindman
Yup, needed to tweak the -mv. On Sat, Aug 8, 2015 at 8:40 AM Vinod Kone wrote: > Benh, looks like 'make dist clean' is complaining. Can you test your > branch with "make dist check"? > > On Sat, Aug 8, 2015 at 12:41 AM, Mesos ReviewBot > wrote: > >> This is an automatically generated e-mail. To

Re: Review Request 37165: Introduced v1 API.

2015-08-07 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37165/ --- (Updated Aug. 8, 2015, 6:48 a.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 37165: Introduced v1 API.

2015-08-06 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37165/ --- (Updated Aug. 7, 2015, 6:38 a.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 37165: Introduced v1 API.

2015-08-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37165/#review94436 --- Ship it! LGTM. Please rebase and let the review bot give an OK befo

Re: Review Request 37165: Introduced v1 API.

2015-08-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37165/#review94381 --- Bad patch! Reviews applied: [37165] Failed command: ./support/appl