Re: Review Request 37199: Added store interface and moved store implementation to LocalStore subclass.

2015-08-20 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37199/#review96010
---


Bad patch!

Reviews applied: [37196, 37197, 37198, 37199]

Failed command: ./support/apply-review.sh -n -r 37199

Error:
 2015-08-20 21:59:29 URL:https://reviews.apache.org/r/37199/diff/raw/ 
[8196/8196] -> "37199.patch" [1]
error: patch failed: src/slave/containerizer/provisioners/docker/store.hpp:39
error: src/slave/containerizer/provisioners/docker/store.hpp: patch does not 
apply
error: patch failed: src/slave/containerizer/provisioners/docker/store.cpp:48
error: src/slave/containerizer/provisioners/docker/store.cpp: patch does not 
apply
Failed to apply patch

- Mesos ReviewBot


On Aug. 17, 2015, 9:12 p.m., Lily Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37199/
> ---
> 
> (Updated Aug. 17, 2015, 9:12 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, 
> and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-2849
> https://issues.apache.org/jira/browse/MESOS-2849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added store interface and moved store implementation to LocalStore subclass.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37199/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Lily Chen
> 
>

Re: Review Request 37199: Added store interface and moved store implementation to LocalStore subclass.

2015-08-20 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37199/#review96006
---



src/slave/containerizer/provisioners/docker/store.cpp (line 56)


"Unknown docker store: " + flags.docker_Store



src/slave/containerizer/provisioners/docker/store.cpp (line 365)


This should be "store path not found", local_store.cpp is already part of 
the log message.


- Timothy Chen


On Aug. 17, 2015, 9:12 p.m., Lily Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37199/
> ---
> 
> (Updated Aug. 17, 2015, 9:12 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Timothy Chen, 
> and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-2849
> https://issues.apache.org/jira/browse/MESOS-2849
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added store interface and moved store implementation to LocalStore subclass.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37199/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Lily Chen
> 
>

Re: Review Request 37199: Added store interface and moved store implementation to LocalStore subclass.

2015-08-16 Thread Lily Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37199/
---

(Updated Aug. 16, 2015, 8:32 a.m.)


Review request for mesos and Timothy Chen.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Added store interface and moved store implementation to LocalStore subclass.


Diffs (updated)
-

  src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37199/diff/


Testing
---

make check


Thanks,

Lily Chen

Re: Review Request 37199: Added store interface and moved store implementation to LocalStore subclass.

2015-08-14 Thread Lily Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37199/
---

(Updated Aug. 15, 2015, 12:39 a.m.)


Review request for mesos and Timothy Chen.


Changes
---

Rebased on master.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Added store interface and moved store implementation to LocalStore subclass.


Diffs (updated)
-

  src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37199/diff/


Testing
---

make check


Thanks,

Lily Chen

Re: Review Request 37199: Added store interface and moved store implementation to LocalStore subclass.

2015-08-11 Thread Lily Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37199/
---

(Updated Aug. 11, 2015, 11:24 p.m.)


Review request for mesos and Timothy Chen.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Added store interface and moved store implementation to LocalStore subclass.


Diffs (updated)
-

  src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37199/diff/


Testing
---

make check


Thanks,

Lily Chen

Re: Review Request 37199: Added store interface and moved store implementation to LocalStore subclass.

2015-08-07 Thread Lily Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37199/
---

(Updated Aug. 8, 2015, 1:32 a.m.)


Review request for mesos and Timothy Chen.


Bugs: MESOS-2849
https://issues.apache.org/jira/browse/MESOS-2849


Repository: mesos


Description
---

Added store interface and moved store implementation to LocalStore subclass.


Diffs (updated)
-

  src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37199/diff/


Testing
---

make check


Thanks,

Lily Chen