Re: Review Request 37228: Updated slave task label decorator hook to pass in ExecutorInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37228/#review94913 --- Ship it! Ship It! - Guangya Liu On 八月 7, 2015, 10:44 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37228/ > --- > > (Updated 八月 7, 2015, 10:44 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Bugs: MESOS-3236 > https://issues.apache.org/jira/browse/MESOS-3236 > > > Repository: mesos > > > Description > --- > > If the task being launched has a command executor, there is no way for > the hook to determine the executor-id for that task. This update calls > the hook _after_ the ExecutorInfo has been created and thus is able to > pass in ExecutorInfo to the label decorator. > > > Diffs > - > > include/mesos/hook.hpp bb5a635dcf189e1023f1eec66fc06955f816fc0b > src/examples/test_hook_module.cpp c664b565bcf18dd2153205990119cc679e4ad6cf > src/hook/manager.hpp 8153ce4826f94d5771c93d37c59fdc4991352e66 > src/hook/manager.cpp 11e6b0a2c0df1d0d7039aaad94e1c6f0e5cc6bc2 > src/slave/slave.cpp f181b1b23cec57a9cce6311127f733f17fbd87e4 > > Diff: https://reviews.apache.org/r/37228/diff/ > > > Testing > --- > > make check. > > > Thanks, > > Kapil Arya > >
Re: Review Request 37228: Updated slave task label decorator hook to pass in ExecutorInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37228/#review94894 --- Ship it! Ship It! - Till Toenshoff On Aug. 7, 2015, 10:44 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37228/ > --- > > (Updated Aug. 7, 2015, 10:44 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Bugs: MESOS-3236 > https://issues.apache.org/jira/browse/MESOS-3236 > > > Repository: mesos > > > Description > --- > > If the task being launched has a command executor, there is no way for > the hook to determine the executor-id for that task. This update calls > the hook _after_ the ExecutorInfo has been created and thus is able to > pass in ExecutorInfo to the label decorator. > > > Diffs > - > > include/mesos/hook.hpp bb5a635dcf189e1023f1eec66fc06955f816fc0b > src/examples/test_hook_module.cpp c664b565bcf18dd2153205990119cc679e4ad6cf > src/hook/manager.hpp 8153ce4826f94d5771c93d37c59fdc4991352e66 > src/hook/manager.cpp 11e6b0a2c0df1d0d7039aaad94e1c6f0e5cc6bc2 > src/slave/slave.cpp f181b1b23cec57a9cce6311127f733f17fbd87e4 > > Diff: https://reviews.apache.org/r/37228/diff/ > > > Testing > --- > > make check. > > > Thanks, > > Kapil Arya > >
Re: Review Request 37228: Updated slave task label decorator hook to pass in ExecutorInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37228/#review94588 --- Ship it! Ship It! - Niklas Nielsen On Aug. 7, 2015, 3:44 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37228/ > --- > > (Updated Aug. 7, 2015, 3:44 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Bugs: MESOS-3236 > https://issues.apache.org/jira/browse/MESOS-3236 > > > Repository: mesos > > > Description > --- > > If the task being launched has a command executor, there is no way for > the hook to determine the executor-id for that task. This update calls > the hook _after_ the ExecutorInfo has been created and thus is able to > pass in ExecutorInfo to the label decorator. > > > Diffs > - > > include/mesos/hook.hpp bb5a635dcf189e1023f1eec66fc06955f816fc0b > src/examples/test_hook_module.cpp c664b565bcf18dd2153205990119cc679e4ad6cf > src/hook/manager.hpp 8153ce4826f94d5771c93d37c59fdc4991352e66 > src/hook/manager.cpp 11e6b0a2c0df1d0d7039aaad94e1c6f0e5cc6bc2 > src/slave/slave.cpp f181b1b23cec57a9cce6311127f733f17fbd87e4 > > Diff: https://reviews.apache.org/r/37228/diff/ > > > Testing > --- > > make check. > > > Thanks, > > Kapil Arya > >
Re: Review Request 37228: Updated slave task label decorator hook to pass in ExecutorInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37228/ --- (Updated Aug. 7, 2015, 3:44 p.m.) Review request for mesos and Niklas Nielsen. Bugs: MESOS-3236 https://issues.apache.org/jira/browse/MESOS-3236 Repository: mesos Description (updated) --- If the task being launched has a command executor, there is no way for the hook to determine the executor-id for that task. This update calls the hook _after_ the ExecutorInfo has been created and thus is able to pass in ExecutorInfo to the label decorator. Diffs - include/mesos/hook.hpp bb5a635dcf189e1023f1eec66fc06955f816fc0b src/examples/test_hook_module.cpp c664b565bcf18dd2153205990119cc679e4ad6cf src/hook/manager.hpp 8153ce4826f94d5771c93d37c59fdc4991352e66 src/hook/manager.cpp 11e6b0a2c0df1d0d7039aaad94e1c6f0e5cc6bc2 src/slave/slave.cpp f181b1b23cec57a9cce6311127f733f17fbd87e4 Diff: https://reviews.apache.org/r/37228/diff/ Testing --- make check. Thanks, Kapil Arya
Re: Review Request 37228: Updated slave task label decorator hook to pass in ExecutorInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37228/#review94578 --- Patch looks great! Reviews applied: [37228] All tests passed. - Mesos ReviewBot On Aug. 7, 2015, 6:51 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37228/ > --- > > (Updated Aug. 7, 2015, 6:51 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Repository: mesos > > > Description > --- > > If that task being launched has a command executor, there is no way for > the hook to determine the executor-id for that task. This update calls > the hook _after_ the ExecutorInfo has been created and thus is able to > pass in ExecutorInfo to the label decorator. > > > Diffs > - > > include/mesos/hook.hpp bb5a635dcf189e1023f1eec66fc06955f816fc0b > src/examples/test_hook_module.cpp c664b565bcf18dd2153205990119cc679e4ad6cf > src/hook/manager.hpp 8153ce4826f94d5771c93d37c59fdc4991352e66 > src/hook/manager.cpp 11e6b0a2c0df1d0d7039aaad94e1c6f0e5cc6bc2 > src/slave/slave.cpp f181b1b23cec57a9cce6311127f733f17fbd87e4 > > Diff: https://reviews.apache.org/r/37228/diff/ > > > Testing > --- > > make check. > > > Thanks, > > Kapil Arya > >
