Re: Review Request 37247: Added Docker image reference store.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37247/#review97914
---


I did not realize that we had a combined RR for this chain - please forgive my 
ignorance for now - I shall review the combined one once you fixed the locally 
mentioned issues.


src/Makefile.am (line 234)


Lets wrap this to fit, putting the backslash at column 72.

```
DOCKER_PROVISIONER_PROTOS = 
\
  messages/docker_provisioner.pb.cc \
  messages/docker_provisioner.pb.h
```



src/Makefile.am (line 402)


Tabs still off?!



src/Makefile.am (line 446)


Tabs still off?!



src/Makefile.am (line 730)


Tabs still off?!



src/Makefile.am (line 758)


Tabs still off?!



src/Makefile.am (line 759)


Not yours but tab spacing is off, please correct.



src/slave/containerizer/provisioners/docker/reference_store.hpp (lines 98 - 99)


Can we move the process definition into the implementation file to make the 
headers fully "need to know" only?



src/slave/containerizer/provisioners/docker/store.cpp (line 115)


This seems rather dangerous - you are using the factory method for the 
initializer here but you ignore the fact that there is indeed chances for it to 
return a failed try. I see why you went the way it is now as that resulted in 
very little code. Still, I think we should be a bit more careful here and test 
for failures.


- Till Toenshoff


On Aug. 27, 2015, 11:41 p.m., Lily Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37247/
> ---
> 
> (Updated Aug. 27, 2015, 11:41 p.m.)
> 
> 
> Review request for mesos, Till Toenshoff and Timothy Chen.
> 
> 
> Bugs: MESOS-3021
> https://issues.apache.org/jira/browse/MESOS-3021
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Docker image reference store.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
>   src/messages/docker_provisioner.hpp PRE-CREATION 
>   src/messages/docker_provisioner.proto PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/reference_store.hpp 
> PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/reference_store.cpp 
> PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37247/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Tests will be added in a later review.
> 
> 
> Thanks,
> 
> Lily Chen
> 
>

Re: Review Request 37247: Added Docker image reference store.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37247/#review97935
---


Thanks till these will be fixed and pushed in my big review!

- Timothy Chen


On Aug. 27, 2015, 11:41 p.m., Lily Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37247/
> ---
> 
> (Updated Aug. 27, 2015, 11:41 p.m.)
> 
> 
> Review request for mesos, Till Toenshoff and Timothy Chen.
> 
> 
> Bugs: MESOS-3021
> https://issues.apache.org/jira/browse/MESOS-3021
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Docker image reference store.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
>   src/messages/docker_provisioner.hpp PRE-CREATION 
>   src/messages/docker_provisioner.proto PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/reference_store.hpp 
> PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/reference_store.cpp 
> PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37247/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Tests will be added in a later review.
> 
> 
> Thanks,
> 
> Lily Chen
> 
>

Re: Review Request 37247: Added Docker image reference store.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37247/
---

(Updated Aug. 27, 2015, 11:41 p.m.)


Review request for mesos, Till Toenshoff and Timothy Chen.


Bugs: MESOS-3021
https://issues.apache.org/jira/browse/MESOS-3021


Repository: mesos


Description
---

Added Docker image reference store.


Diffs (updated)
-

  src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
  src/messages/docker_provisioner.hpp PRE-CREATION 
  src/messages/docker_provisioner.proto PRE-CREATION 
  src/slave/containerizer/provisioners/docker/reference_store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37247/diff/


Testing
---

make check

Tests will be added in a later review.


Thanks,

Lily Chen

Re: Review Request 37247: Added Docker image reference store.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37247/#review96549
---



src/Makefile.am (line 402)
https://reviews.apache.org/r/37247/#comment152020

Tab spacing / hard tabs.



src/Makefile.am (line 446)
https://reviews.apache.org/r/37247/#comment152021

Tab spacing / hard-tabs!



src/Makefile.am 
https://reviews.apache.org/r/37247/#comment152022

Why did you kill this line?



src/Makefile.am (line 729)
https://reviews.apache.org/r/37247/#comment152023

Spacing / hard-tabs!



src/Makefile.am (lines 755 - 758)
https://reviews.apache.org/r/37247/#comment152024

Spacing / hard-tabs!



src/messages/docker_provisioner.proto (lines 25 - 26)
https://reviews.apache.org/r/37247/#comment152026

s/layerId/layer id/



src/slave/containerizer/provisioners/docker/reference_store.hpp (line 26)
https://reviews.apache.org/r/37247/#comment152027

Kill this blank line please.



src/slave/containerizer/provisioners/docker/reference_store.hpp (line 28)
https://reviews.apache.org/r/37247/#comment152029

Missing 
```
#include process/process.hpp
```
(for ProcessBase)



src/slave/containerizer/provisioners/docker/reference_store.hpp (line 30)
https://reviews.apache.org/r/37247/#comment152028

Missing
```
#include stout/option.hpp
```



src/slave/containerizer/provisioners/docker/reference_store.hpp (line 32)
https://reviews.apache.org/r/37247/#comment152030

Missing
```
#include stout/try.hpp
```



src/slave/containerizer/provisioners/docker/reference_store.cpp (line 42)
https://reviews.apache.org/r/37247/#comment152034

This appears a bit overblown for the amount of symbols you are actually 
using from that namespace.



src/slave/containerizer/provisioners/docker/reference_store.cpp (line 59)
https://reviews.apache.org/r/37247/#comment152039

Blank line here please.



src/slave/containerizer/provisioners/docker/reference_store.cpp (line 65)
https://reviews.apache.org/r/37247/#comment152038

Blank line here please.



src/slave/containerizer/provisioners/docker/reference_store.cpp (line 71)
https://reviews.apache.org/r/37247/#comment152037

Blank line here please.



src/slave/containerizer/provisioners/docker/reference_store.cpp (line 76)
https://reviews.apache.org/r/37247/#comment152036

Blank line here please.



src/slave/containerizer/provisioners/docker/reference_store.cpp (line 84)
https://reviews.apache.org/r/37247/#comment152040

Blank line here please.



src/slave/containerizer/provisioners/docker/reference_store.cpp (line 93)
https://reviews.apache.org/r/37247/#comment152035

Blank line here please.



src/slave/containerizer/provisioners/docker/store.cpp (line 100)
https://reviews.apache.org/r/37247/#comment152042

Blank line here please.



src/slave/containerizer/provisioners/docker/store.cpp (line 107)
https://reviews.apache.org/r/37247/#comment152041

Blank line here please.


- Till Toenshoff


On Aug. 25, 2015, 9 p.m., Lily Chen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37247/
 ---
 
 (Updated Aug. 25, 2015, 9 p.m.)
 
 
 Review request for mesos and Timothy Chen.
 
 
 Bugs: MESOS-3021
 https://issues.apache.org/jira/browse/MESOS-3021
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added Docker image reference store.
 
 
 Diffs
 -
 
   src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab 
   src/messages/docker_provisioner.hpp PRE-CREATION 
   src/messages/docker_provisioner.proto PRE-CREATION 
   src/slave/containerizer/provisioners/docker/reference_store.hpp 
 PRE-CREATION 
   src/slave/containerizer/provisioners/docker/reference_store.cpp 
 PRE-CREATION 
   src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
   src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/37247/diff/
 
 
 Testing
 ---
 
 make check
 
 Tests will be added in a later review.
 
 
 Thanks,
 
 Lily Chen
 

Re: Review Request 37247: Added Docker image reference store.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37247/
---

(Updated Aug. 25, 2015, 9 p.m.)


Review request for mesos and Timothy Chen.


Changes
---

Rebased on master.


Bugs: MESOS-3021
https://issues.apache.org/jira/browse/MESOS-3021


Repository: mesos


Description
---

Added Docker image reference store.


Diffs (updated)
-

  src/Makefile.am 571e1ac0f96b2452797a478680b540f2aab63aab 
  src/messages/docker_provisioner.hpp PRE-CREATION 
  src/messages/docker_provisioner.proto PRE-CREATION 
  src/slave/containerizer/provisioners/docker/reference_store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37247/diff/


Testing
---

make check

Tests will be added in a later review.


Thanks,

Lily Chen

Re: Review Request 37247: Added Docker image reference store.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37247/
---

(Updated Aug. 25, 2015, 1:33 a.m.)


Review request for mesos and Timothy Chen.


Bugs: MESOS-3021
https://issues.apache.org/jira/browse/MESOS-3021


Repository: mesos


Description
---

Added Docker image reference store.


Diffs (updated)
-

  src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db 
  src/messages/docker_provisioner.hpp PRE-CREATION 
  src/messages/docker_provisioner.proto PRE-CREATION 
  src/slave/containerizer/provisioners/docker/reference_store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37247/diff/


Testing
---

make check

Tests will be added in a later review.


Thanks,

Lily Chen

Re: Review Request 37247: Added Docker image reference store.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37247/
---

(Updated Aug. 19, 2015, 6:44 p.m.)


Review request for mesos and Timothy Chen.


Bugs: MESOS-3021
https://issues.apache.org/jira/browse/MESOS-3021


Repository: mesos


Description
---

Added Docker image reference store.


Diffs (updated)
-

  src/Makefile.am 457ad26ee55bd7a2aedf27f45db58a9a4a6a5dc5 
  src/messages/docker_provisioner.hpp PRE-CREATION 
  src/messages/docker_provisioner.proto PRE-CREATION 
  src/slave/containerizer/provisioners/docker/reference_store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37247/diff/


Testing
---

make check

Tests will be added in a later review.


Thanks,

Lily Chen

Re: Review Request 37247: Added Docker image reference store.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37247/
---

(Updated Aug. 16, 2015, 8:35 a.m.)


Review request for mesos and Timothy Chen.


Changes
---

Fixed build error.


Bugs: MESOS-3021
https://issues.apache.org/jira/browse/MESOS-3021


Repository: mesos


Description
---

Added Docker image reference store.


Diffs (updated)
-

  src/Makefile.am 457ad26ee55bd7a2aedf27f45db58a9a4a6a5dc5 
  src/messages/docker_provisioner.hpp PRE-CREATION 
  src/messages/docker_provisioner.proto PRE-CREATION 
  src/slave/containerizer/provisioners/docker/reference_store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37247/diff/


Testing
---

make check

Tests will be added in a later review.


Thanks,

Lily Chen

Re: Review Request 37247: Added Docker image reference store.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37247/
---

(Updated Aug. 15, 2015, 12:46 a.m.)


Review request for mesos and Timothy Chen.


Changes
---

Integrated reference store into local image store and removed restore, since 
reference store handles saving and restoring state.


Bugs: MESOS-3021
https://issues.apache.org/jira/browse/MESOS-3021


Repository: mesos


Description
---

Added Docker image reference store.


Diffs (updated)
-

  src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 
  src/messages/docker_provisioner.hpp PRE-CREATION 
  src/messages/docker_provisioner.proto PRE-CREATION 
  src/slave/containerizer/provisioners/docker/reference_store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37247/diff/


Testing
---

make check

Tests will be added in a later review.


Thanks,

Lily Chen

Re: Review Request 37247: Added Docker image reference store.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37247/#review95034
---


Bad patch!

Reviews applied: [37196, 37197, 37198, 37199, 37200, 37245, 37246, 37247]

Failed command: ./support/apply-review.sh -n -r 37247

Error:
 2015-08-12 00:28:40 URL:https://reviews.apache.org/r/37247/diff/raw/ 
[15655/15655] - 37247.patch [1]
error: patch failed: src/Makefile.am:422
error: src/Makefile.am: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Aug. 11, 2015, 11:34 p.m., Lily Chen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37247/
 ---
 
 (Updated Aug. 11, 2015, 11:34 p.m.)
 
 
 Review request for mesos and Timothy Chen.
 
 
 Bugs: MESOS-3021
 https://issues.apache.org/jira/browse/MESOS-3021
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added Docker image reference store.
 
 
 Diffs
 -
 
   src/Makefile.am c213ac779e7acc3235312ca9524b3959417b8c33 
   src/messages/docker_provisioner.hpp PRE-CREATION 
   src/messages/docker_provisioner.proto PRE-CREATION 
   src/slave/containerizer/provisioners/docker/reference_store.hpp 
 PRE-CREATION 
   src/slave/containerizer/provisioners/docker/reference_store.cpp 
 PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/37247/diff/
 
 
 Testing
 ---
 
 make check
 
 Tests will be added in a later review.
 
 
 Thanks,
 
 Lily Chen
 

Re: Review Request 37247: Added Docker image reference store.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37247/
---

(Updated Aug. 11, 2015, 11:34 p.m.)


Review request for mesos and Timothy Chen.


Changes
---

Moved DockerProvisionerImages to a .proto file not accessible through the 
public API and added some logs.


Bugs: MESOS-3021
https://issues.apache.org/jira/browse/MESOS-3021


Repository: mesos


Description
---

Added Docker image reference store.


Diffs (updated)
-

  src/Makefile.am c213ac779e7acc3235312ca9524b3959417b8c33 
  src/messages/docker_provisioner.hpp PRE-CREATION 
  src/messages/docker_provisioner.proto PRE-CREATION 
  src/slave/containerizer/provisioners/docker/reference_store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37247/diff/


Testing
---

make check

Tests will be added in a later review.


Thanks,

Lily Chen

Re: Review Request 37247: Added Docker image reference store.

[Lily Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37247/
---

(Updated Aug. 10, 2015, 10:53 p.m.)


Review request for mesos and Timothy Chen.


Bugs: MESOS-3021
https://issues.apache.org/jira/browse/MESOS-3021


Repository: mesos


Description
---

Added Docker image reference store.


Diffs (updated)
-

  include/mesos/mesos.proto 80f56ac2178b24ff19f57c1ace13f567843c7807 
  src/Makefile.am c213ac779e7acc3235312ca9524b3959417b8c33 
  src/slave/containerizer/provisioners/docker/reference_store.hpp PRE-CREATION 
  src/slave/containerizer/provisioners/docker/reference_store.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37247/diff/


Testing
---

make check

Tests will be added in a later review.


Thanks,

Lily Chen

Re: Review Request 37247: Added Docker image reference store.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37247/#review94840
---


Bad patch!

Reviews applied: [37196, 37197, 37198, 37199, 37200, 37245]

Failed command: ./support/apply-review.sh -n -r 37245

Error:
 2015-08-11 00:56:27 URL:https://reviews.apache.org/r/37245/diff/raw/ 
[5141/5141] - 37245.patch [1]
error: patch failed: src/slave/containerizer/provisioners/docker.cpp:199
error: src/slave/containerizer/provisioners/docker.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Aug. 10, 2015, 10:53 p.m., Lily Chen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37247/
 ---
 
 (Updated Aug. 10, 2015, 10:53 p.m.)
 
 
 Review request for mesos and Timothy Chen.
 
 
 Bugs: MESOS-3021
 https://issues.apache.org/jira/browse/MESOS-3021
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added Docker image reference store.
 
 
 Diffs
 -
 
   include/mesos/mesos.proto 80f56ac2178b24ff19f57c1ace13f567843c7807 
   src/Makefile.am c213ac779e7acc3235312ca9524b3959417b8c33 
   src/slave/containerizer/provisioners/docker/reference_store.hpp 
 PRE-CREATION 
   src/slave/containerizer/provisioners/docker/reference_store.cpp 
 PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/37247/diff/
 
 
 Testing
 ---
 
 make check
 
 Tests will be added in a later review.
 
 
 Thanks,
 
 Lily Chen
 

Re: Review Request 37247: Added Docker image reference store.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37247/#review94646
---



include/mesos/mesos.proto (line 1397)
https://reviews.apache.org/r/37247/#comment149238

Since this is not a protobuf message that is going to be used in the public 
API, we usually put these in the src folder, look at messages.proto and where 
it is at and I think we should create a new proto file just for docker 
provisioner.



include/mesos/mesos.proto (line 1404)
https://reviews.apache.org/r/37247/#comment149239

This is already in the image message, we just need to name this name



include/mesos/mesos.proto (line 1405)
https://reviews.apache.org/r/37247/#comment149240

layer_ids



src/slave/containerizer/provisioners/docker/reference_store.hpp (line 46)
https://reviews.apache.org/r/37247/#comment149241

Don't we persist to disk?



src/slave/containerizer/provisioners/docker/reference_store.hpp (line 57)
https://reviews.apache.org/r/37247/#comment149242

don't we load from disk? why would we need to recover if it's already in 
memory?



src/slave/containerizer/provisioners/docker/reference_store.hpp (line 66)
https://reviews.apache.org/r/37247/#comment149243

I think we are converting comments to javadoc style now, so you'll need to 
also comment on the params too.



src/slave/containerizer/provisioners/docker/reference_store.hpp (line 69)
https://reviews.apache.org/r/37247/#comment149244

What does available mean here?



src/slave/containerizer/provisioners/docker/reference_store.hpp (line 79)
https://reviews.apache.org/r/37247/#comment149245

two spaces between classes



src/slave/containerizer/provisioners/docker/reference_store.hpp (line 101)
https://reviews.apache.org/r/37247/#comment149246

How about just say Write out referencen store state to persistent store.
How about just calling this persist? Save doesn't seem to convey what this 
method does.



src/slave/containerizer/provisioners/docker/reference_store.cpp (line 28)
https://reviews.apache.org/r/37247/#comment149247

Move this above stout



src/slave/containerizer/provisioners/docker/reference_store.cpp (line 127)
https://reviews.apache.org/r/37247/#comment149248

Why create a heap allocated object?

Why not just:

DockerProvisionerImages images;

?



src/slave/containerizer/provisioners/docker/reference_store.cpp (line 137)
https://reviews.apache.org/r/37247/#comment149249

Space between foreach and (



src/slave/containerizer/provisioners/docker/reference_store.cpp (line 162)
https://reviews.apache.org/r/37247/#comment149250

Space between if and (



src/slave/containerizer/provisioners/docker/reference_store.cpp (line 163)
https://reviews.apache.org/r/37247/#comment149251

LOG something here



src/slave/containerizer/provisioners/docker/reference_store.cpp (line 186)
https://reviews.apache.org/r/37247/#comment149252

Why missing layer means we don't load up the image? And when would this 
happen?

We should definitely log here too!



src/slave/containerizer/provisioners/docker/reference_store.cpp (line 188)
https://reviews.apache.org/r/37247/#comment149253

I think we should add VLOG(1) or VLOG(2) of logging all the images we 
loaded up.


- Timothy Chen


On Aug. 8, 2015, 1:38 a.m., Lily Chen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37247/
 ---
 
 (Updated Aug. 8, 2015, 1:38 a.m.)
 
 
 Review request for mesos and Timothy Chen.
 
 
 Bugs: MESOS-3021
 https://issues.apache.org/jira/browse/MESOS-3021
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added Docker image reference store.
 
 
 Diffs
 -
 
   include/mesos/mesos.proto 80f56ac2178b24ff19f57c1ace13f567843c7807 
   src/Makefile.am c213ac779e7acc3235312ca9524b3959417b8c33 
   src/slave/containerizer/provisioners/docker/reference_store.hpp 
 PRE-CREATION 
   src/slave/containerizer/provisioners/docker/reference_store.cpp 
 PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/37247/diff/
 
 
 Testing
 ---
 
 make check
 
 Tests will be added in a later review.
 
 
 Thanks,
 
 Lily Chen