Re: Review Request 37273: [2/3]Add CMake macro VsBuildCommand in libprocess.

2015-08-11 Thread haosdent huang
On Aug. 10, 2015, 6:42 p.m., Alex Clemmer wrote: 3rdparty/libprocess/3rdparty/glog-0.3.3.patch, line 21 https://reviews.apache.org/r/37273/diff/2/?file=1036048#file1036048line21 Looks like your updating the patchfile here to include my glog PR that opens it to working on MSVC

Re: Review Request 37273: [2/3]Add CMake macro VsBuildCommand in libprocess.

2015-08-11 Thread haosdent huang
On Aug. 10, 2015, 6:42 p.m., Alex Clemmer wrote: 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 55 https://reviews.apache.org/r/37273/diff/2/?file=1036047#file1036047line55 Sorry, maybe I'm a bit slow this morning -- but how are you running this? Windows doesn't have the

Re: Review Request 37273: [2/3]Add CMake macro VsBuildCommand in libprocess.

2015-08-11 Thread haosdent huang
On Aug. 10, 2015, 6:42 p.m., Alex Clemmer wrote: 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 55 https://reviews.apache.org/r/37273/diff/2/?file=1036047#file1036047line55 Sorry, maybe I'm a bit slow this morning -- but how are you running this? Windows doesn't have the

Re: Review Request 37273: [2/3]Add CMake macro VsBuildCommand in libprocess.

2015-08-11 Thread haosdent huang
On Aug. 10, 2015, 6:42 p.m., Alex Clemmer wrote: 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 77 https://reviews.apache.org/r/37273/diff/2/?file=1036047#file1036047line77 So, why change the value to `TRUE` here? Is there some consequence of this, or is it just clearer to

Re: Review Request 37273: [2/3]Add CMake macro VsBuildCommand in libprocess.

2015-08-11 Thread haosdent huang
On Aug. 10, 2015, 6:42 p.m., Alex Clemmer wrote: 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 77 https://reviews.apache.org/r/37273/diff/2/?file=1036047#file1036047line77 So, why change the value to `TRUE` here? Is there some consequence of this, or is it just clearer to

Re: Review Request 37273: [2/3]Add CMake macro VsBuildCommand in libprocess.

2015-08-10 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/#review94776 --- 3rdparty/libprocess/3rdparty/CMakeLists.txt (line 55)

Re: Review Request 37273: [2/3]Add CMake macro VsBuildCommand in libprocess.

2015-08-10 Thread Alex Clemmer
On Aug. 10, 2015, 6:42 p.m., Alex Clemmer wrote: 3rdparty/libprocess/3rdparty/glog-0.3.3.patch, line 21 https://reviews.apache.org/r/37273/diff/2/?file=1036048#file1036048line21 Looks like your updating the patchfile here to include my glog PR that opens it to working on MSVC

Re: Review Request 37273: [2/3]Add CMake macro VsBuildCommand in libprocess.

2015-08-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/ --- (Updated Aug. 10, 2015, 9:50 a.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 37273: [2/3]Add CMake macro VsBuildCommand in libprocess.

2015-08-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/ --- (Updated Aug. 9, 2015, 6:21 p.m.) Review request for mesos and Alex Clemmer.