Re: Review Request 37307: Changed Image::AppC::id from required to optional.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37307/#review94939
---

Ship it!


Ship It!

- Jie Yu


On Aug. 10, 2015, 6:31 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37307/
> ---
> 
> (Updated Aug. 10, 2015, 6:31 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Timothy Chen, and Vinod Kone.
> 
> 
> Bugs: MESOS-3192
> https://issues.apache.org/jira/browse/MESOS-3192
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See the ticket for details.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 80f56ac2178b24ff19f57c1ace13f567843c7807 
> 
> Diff: https://reviews.apache.org/r/37307/diff/
> 
> 
> Testing
> ---
> 
> N/A.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 37307: Changed Image::AppC::id from required to optional.

[Jiang Yan Xu]

> On Aug. 10, 2015, 1:29 p.m., Timothy Chen wrote:
> > include/mesos/mesos.proto, line 1208
> > 
> >
> > Should the user have the ability then to specify either a name or a id?
> > 
> > If name is required then I don't see why specify an id at the same time?

The user should have the ability and flexibility to specify:

name + version + other things (arch, os, etc., version can be SemVar or 
conventional patterns such as 'latest' or 'live' or 'production')
name (use the default version)
name + id

Even though the id may be universally unique, current Appc spec and our 
discovery implementation (not checked in yet) don't support queries by the id 
alone. Therefore 'name' being a required field is fine with me.

Plus I think knowing the name is much less of a burden and source of 
inflexibility than the id.

The motivation is for the image maintainer / cluster operator to be able to 
update the base image (for new tasks) across the cluster without requiring the 
users to update the `id` for each individual task. I should put this in the 
ticket.


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37307/#review94792
---


On Aug. 10, 2015, 11:31 a.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37307/
> ---
> 
> (Updated Aug. 10, 2015, 11:31 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Timothy Chen, and Vinod Kone.
> 
> 
> Bugs: MESOS-3192
> https://issues.apache.org/jira/browse/MESOS-3192
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See the ticket for details.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 80f56ac2178b24ff19f57c1ace13f567843c7807 
> 
> Diff: https://reviews.apache.org/r/37307/diff/
> 
> 
> Testing
> ---
> 
> N/A.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 37307: Changed Image::AppC::id from required to optional.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37307/#review94792
---



include/mesos/mesos.proto (line 1208)


Should the user have the ability then to specify either a name or a id?

If name is required then I don't see why specify an id at the same time?


- Timothy Chen


On Aug. 10, 2015, 6:31 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37307/
> ---
> 
> (Updated Aug. 10, 2015, 6:31 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Timothy Chen, and Vinod Kone.
> 
> 
> Bugs: MESOS-3192
> https://issues.apache.org/jira/browse/MESOS-3192
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See the ticket for details.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 80f56ac2178b24ff19f57c1ace13f567843c7807 
> 
> Diff: https://reviews.apache.org/r/37307/diff/
> 
> 
> Testing
> ---
> 
> N/A.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>