Re: Review Request 37424: Timeout the perf future if the process does not complete.

2015-08-18 Thread Paul Brett
On Aug. 17, 2015, 6:22 p.m., Ben Mahler wrote: src/linux/perf.cpp, line 199 https://reviews.apache.org/r/37424/diff/1/?file=1038974#file1038974line199 We may want to update this to become killtree in a separate patch? Or are we guaranteed that perf will clean up child processes?

Re: Review Request 37424: Timeout the perf future if the process does not complete.

2015-08-18 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37424/ --- (Updated Aug. 18, 2015, 6:40 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37424: Timeout the perf future if the process does not complete.

2015-08-18 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37424/ --- (Updated Aug. 18, 2015, 6:43 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37424: Timeout the perf future if the process does not complete.

2015-08-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37424/#review95773 --- Ship it! Thanks, the summary here is now stale, but I'll update it

Re: Review Request 37424: Timeout the perf future if the process does not complete.

2015-08-17 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37424/#review95606 --- src/linux/perf.cpp (line 199)