Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-09-02 Thread Paul Brett
> On Sept. 2, 2015, 10:47 p.m., Ben Mahler wrote: > > src/tests/containerizer/perf_tests.cpp, line 67 > > > > > > Why is this called ParseTypes and the one below called ParseCgroups? > > They both seem to parse

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-09-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/#review97597 --- Patch looks great! Reviews applied: [37416, 37442, 37462, 37466]

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-09-02 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/ --- (Updated Sept. 2, 2015, 11:33 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-09-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/#review97530 --- Bad patch! Reviews applied: [37416, 37442, 37462, 37466] Failed

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-09-02 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/ --- (Updated Sept. 2, 2015, 9:13 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-09-02 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/#review97551 --- Thinking about this further, the test parameteratization here seems

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-09-01 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/#review97366 --- Thanks for testing this! src/tests/containerizer/perf_tests.cpp

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-09-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/#review97348 --- Bad patch! Reviews applied: [37416, 37442] Failed command:

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-08-24 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/#review96168 --- src/tests/containerizer/perf_tests.cpp (line 52)

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-08-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/ --- (Updated Aug. 21, 2015, 4:06 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-08-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/ --- (Updated Aug. 20, 2015, 11 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-08-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/ --- (Updated Aug. 20, 2015, 11:51 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-08-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/#review95396 --- Patch looks great! Reviews applied: [37423, 37424, 37417, 37416,