----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37491/#review95485 -----------------------------------------------------------
Patch looks great! Reviews applied: [37491] All tests passed. - Mesos ReviewBot On Aug. 14, 2015, 8:19 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37491/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2015, 8:19 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-3263 > https://issues.apache.org/jira/browse/MESOS-3263 > > > Repository: mesos > > > Description > ------- > > Added a test to show how converting a protobuf having a byte field to json > fails due to the bytes not being escaped correctly. The test is currently > disabled. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp > 018ff51d10f4ba076609704d6e3b2c704c82b016 > > Diff: https://reviews.apache.org/r/37491/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
