Re: Review Request 37494: Fixed JSON wrapper to properly encode bytes.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37494/#review95610
---



3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp (lines 497 - 498)


Does this TODO need updating based on how picojson does it?


- Ben Mahler


On Aug. 14, 2015, 11:24 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37494/
> ---
> 
> (Updated Aug. 14, 2015, 11:24 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Bugs: MESOS-3267
> https://issues.apache.org/jira/browse/MESOS-3267
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See the bug for details.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
> 8f848ad9646d828b9efa2fb0f3225c82ac81b23e 
>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 
> dd692094e164e33ba0f13e2b994c14cbfd827cbf 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 
> 018ff51d10f4ba076609704d6e3b2c704c82b016 
> 
> Diff: https://reviews.apache.org/r/37494/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 37494: Fixed JSON wrapper to properly encode bytes.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37494/#review95494
---

Ship it!


LGTM


3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp (line 499)


We can return here itself: return out << stuff



3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp (line 123)


s/message a little bit to test/message to test


- Anand Mazumdar


On Aug. 14, 2015, 11:24 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37494/
> ---
> 
> (Updated Aug. 14, 2015, 11:24 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Bugs: MESOS-3267
> https://issues.apache.org/jira/browse/MESOS-3267
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See the bug for details.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
> 8f848ad9646d828b9efa2fb0f3225c82ac81b23e 
>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 
> dd692094e164e33ba0f13e2b994c14cbfd827cbf 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 
> 018ff51d10f4ba076609704d6e3b2c704c82b016 
> 
> Diff: https://reviews.apache.org/r/37494/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 37494: Fixed JSON wrapper to properly encode bytes.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37494/#review95495
---


Patch looks great!

Reviews applied: [37494]

All tests passed.

- Mesos ReviewBot


On Aug. 14, 2015, 11:24 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37494/
> ---
> 
> (Updated Aug. 14, 2015, 11:24 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Bugs: MESOS-3267
> https://issues.apache.org/jira/browse/MESOS-3267
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See the bug for details.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
> 8f848ad9646d828b9efa2fb0f3225c82ac81b23e 
>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 
> dd692094e164e33ba0f13e2b994c14cbfd827cbf 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 
> 018ff51d10f4ba076609704d6e3b2c704c82b016 
> 
> Diff: https://reviews.apache.org/r/37494/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>