Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-18 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/#review99600 --- i'm going to commit this chain now. after talking some other

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-18 Thread Guangya Liu
> On 九月 18, 2015, 9:06 p.m., Vinod Kone wrote: > > i'm going to commit this chain now. after talking some other committers, > > SUPPRESS name is still preferablet o QUIESCE. so lets see if you or I can > > make that work (after this chain gets committed). Thanks Vinod. I can work on the

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/#review99443 --- Ship it! include/mesos/scheduler.hpp (line 271)

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-17 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/ --- (Updated 九月 18, 2015, 3:54 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/ --- (Updated 九月 16, 2015, 5:51 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-15 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/#review99153 --- Ship it! Ship It! - Yong Qiao Wang On Sept. 15, 2015, 11 p.m.,

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/#review99061 --- include/mesos/scheduler.hpp (line 272)

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-14 Thread Adam B
> On Sept. 4, 2015, 12:49 p.m., Vinod Kone wrote: > > this review blocks a bunch of reviews? can you make the dependency linear? > > it would make my life easier to follow the chain of reviews. > > Guangya Liu wrote: > Thanks Vinod, both 37867 and 37866 are now discared but I do not know

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-14 Thread Guangya Liu
> On Sept. 4, 2015, 7:49 p.m., Vinod Kone wrote: > > this review blocks a bunch of reviews? can you make the dependency linear? > > it would make my life easier to follow the chain of reviews. > > Guangya Liu wrote: > Thanks Vinod, both 37867 and 37866 are now discared but I do not know

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/ --- (Updated 九月 4, 2015, 12:06 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/#review97792 --- this review blocks a bunch of reviews? can you make the dependency

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-04 Thread Guangya Liu
> On 九月 4, 2015, 7:49 p.m., Vinod Kone wrote: > > this review blocks a bunch of reviews? can you make the dependency linear? > > it would make my life easier to follow the chain of reviews. Thanks Vinod, both 37867 and 37866 are now discared but I do not know how to remove them from depenency

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/ --- (Updated 九月 4, 2015, 2:20 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/ --- (Updated Sept. 4, 2015, 3:35 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-01 Thread Guangya Liu
> On 八月 20, 2015, 7:39 p.m., Marco Massenzio wrote: > > include/mesos/scheduler/scheduler.proto, lines 314-315 > > > > > > This comments does not read well: what is the timeout? also, it would > > be good to have a

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-01 Thread Guangya Liu
> On 八月 20, 2015, 7:39 p.m., Marco Massenzio wrote: > > include/mesos/scheduler/scheduler.proto, lines 314-315 > > > > > > This comments does not read well: what is the timeout? also, it would > > be good to have a

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-01 Thread Marco Massenzio
> On Aug. 20, 2015, 7:39 p.m., Marco Massenzio wrote: > > include/mesos/scheduler/scheduler.proto, lines 314-315 > > > > > > This comments does not read well: what is the timeout? also, it would > > be good to have

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-01 Thread Marco Massenzio
> On Aug. 20, 2015, 7:39 p.m., Marco Massenzio wrote: > > include/mesos/scheduler/scheduler.proto, lines 314-315 > > > > > > This comments does not read well: what is the timeout? also, it would > > be good to have

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-27 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/ --- (Updated Aug. 28, 2015, 3:40 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-27 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/ --- (Updated Aug. 28, 2015, 5:53 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-27 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/ --- (Updated Aug. 28, 2015, 1:35 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-27 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/ --- (Updated Aug. 28, 2015, 1:46 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-27 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/ --- (Updated Aug. 28, 2015, 3:10 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-26 Thread Guangya Liu
On Aug. 25, 2015, 11:46 p.m., Vinod Kone wrote: Can you split the addition of suppress to the driver (sched.cpp) and http library (scheduler.cpp) into separate patches? Note that the former needs updates to the Java and Python bindings as well. More importantly, are you planning to

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-26 Thread Guangya Liu
On Aug. 25, 2015, 11:46 p.m., Vinod Kone wrote: Can you split the addition of suppress to the driver (sched.cpp) and http library (scheduler.cpp) into separate patches? Note that the former needs updates to the Java and Python bindings as well. More importantly, are you planning to

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/#review96453 --- Can you split the addition of suppress to the driver (sched.cpp)

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-22 Thread Guangya Liu
On 八月 20, 2015, 7:39 p.m., Marco Massenzio wrote: include/mesos/scheduler/scheduler.proto, lines 314-315 https://reviews.apache.org/r/37532/diff/1/?file=1042006#file1042006line314 This comments does not read well: what is the timeout? also, it would be good to have a bit of info

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/ --- (Updated 八月 22, 2015, 2:27 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-20 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/#review95997 --- include/mesos/scheduler.hpp (line 273)

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/#review95645 --- Patch looks great! Reviews applied: [37532] All tests passed. -