Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-18 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review99600
---


i'm going to commit this chain now. after talking some other committers, 
SUPPRESS name is still preferablet o QUIESCE. so lets see if you or I can make 
that work (after this chain gets committed).

- Vinod Kone


On Sept. 18, 2015, 3:54 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37532/
> ---
> 
> (Updated Sept. 18, 2015, 3:54 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is just part of MESOS-3037, this patch only add the interface
> of QUIESCE call.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
>   include/mesos/scheduler/scheduler.proto 
> 19f548dba4b5d72fca8e692c5f15796feca17106 
>   src/master/master.hpp d48ef7c0da8978a5e02e69e055ff010585b20ceb 
>   src/master/master.cpp 1c4e7af7448c05f54c1068d6496ed21c8c359ac5 
>   src/sched/sched.cpp a1723f3cdd05289b417b4ea8bdd9b000655eccf8 
> 
> Diff: https://reviews.apache.org/r/37532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-18 Thread Guangya Liu


> On 九月 18, 2015, 9:06 p.m., Vinod Kone wrote:
> > i'm going to commit this chain now. after talking some other committers, 
> > SUPPRESS name is still preferablet o QUIESCE. so lets see if you or I can 
> > make that work (after this chain gets committed).

Thanks Vinod. I can work on the following tasks after this chain committed.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review99600
---


On 九月 18, 2015, 3:54 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37532/
> ---
> 
> (Updated 九月 18, 2015, 3:54 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is just part of MESOS-3037, this patch only add the interface
> of QUIESCE call.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
>   include/mesos/scheduler/scheduler.proto 
> 19f548dba4b5d72fca8e692c5f15796feca17106 
>   src/master/master.hpp d48ef7c0da8978a5e02e69e055ff010585b20ceb 
>   src/master/master.cpp 1c4e7af7448c05f54c1068d6496ed21c8c359ac5 
>   src/sched/sched.cpp a1723f3cdd05289b417b4ea8bdd9b000655eccf8 
> 
> Diff: https://reviews.apache.org/r/37532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-17 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review99443
---

Ship it!



include/mesos/scheduler.hpp (line 271)


s/, the/. The/


- Vinod Kone


On Sept. 16, 2015, 5:51 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37532/
> ---
> 
> (Updated Sept. 16, 2015, 5:51 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is just part of MESOS-3037, this patch only add the interface
> of QUIESCE call.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
>   include/mesos/scheduler/scheduler.proto 
> 19f548dba4b5d72fca8e692c5f15796feca17106 
>   src/master/master.hpp d48ef7c0da8978a5e02e69e055ff010585b20ceb 
>   src/master/master.cpp f26271c5b21685916c0654488ac1464f21d72e9a 
>   src/sched/sched.cpp a1723f3cdd05289b417b4ea8bdd9b000655eccf8 
> 
> Diff: https://reviews.apache.org/r/37532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-17 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/
---

(Updated 九月 18, 2015, 3:54 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

This is just part of MESOS-3037, this patch only add the interface
of QUIESCE call.


Diffs (updated)
-

  include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
  include/mesos/scheduler/scheduler.proto 
19f548dba4b5d72fca8e692c5f15796feca17106 
  src/master/master.hpp d48ef7c0da8978a5e02e69e055ff010585b20ceb 
  src/master/master.cpp 1c4e7af7448c05f54c1068d6496ed21c8c359ac5 
  src/sched/sched.cpp a1723f3cdd05289b417b4ea8bdd9b000655eccf8 

Diff: https://reviews.apache.org/r/37532/diff/


Testing
---


Thanks,

Guangya Liu



Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-15 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/
---

(Updated 九月 16, 2015, 5:51 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

This is just part of MESOS-3037, this patch only add the interface
of QUIESCE call.


Diffs (updated)
-

  include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
  include/mesos/scheduler/scheduler.proto 
19f548dba4b5d72fca8e692c5f15796feca17106 
  src/master/master.hpp d48ef7c0da8978a5e02e69e055ff010585b20ceb 
  src/master/master.cpp f26271c5b21685916c0654488ac1464f21d72e9a 
  src/sched/sched.cpp a1723f3cdd05289b417b4ea8bdd9b000655eccf8 

Diff: https://reviews.apache.org/r/37532/diff/


Testing
---


Thanks,

Guangya Liu



Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-15 Thread Yong Qiao Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review99153
---

Ship it!


Ship It!

- Yong Qiao Wang


On Sept. 15, 2015, 11 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37532/
> ---
> 
> (Updated Sept. 15, 2015, 11 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is just part of MESOS-3037, this patch only add the interface
> of QUIESCE call.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
>   include/mesos/scheduler/scheduler.proto 
> 19f548dba4b5d72fca8e692c5f15796feca17106 
>   src/master/master.hpp d48ef7c0da8978a5e02e69e055ff010585b20ceb 
>   src/master/master.cpp f26271c5b21685916c0654488ac1464f21d72e9a 
>   src/sched/sched.cpp a1723f3cdd05289b417b4ea8bdd9b000655eccf8 
> 
> Diff: https://reviews.apache.org/r/37532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-15 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review99061
---



include/mesos/scheduler.hpp (line 272)


Should we even bother adding this to the old API? Note that adding a new 
call to the driver will impose a upgrade dependency between schedulers and 
master (master first, libmesos for scheduler next, scheduler jar last)

more importantly, add a comment here that scheduler should call 
reviveOffers() to resume getting offers.



include/mesos/scheduler/scheduler.proto (line 173)


period at the end. also, does this fit within 80 chars?



src/master/master.cpp (line 1747)


you also need to add a case statement to master/http.cpp.



src/master/master.cpp (line 2542)


s/just ignore/ignoring/


- Vinod Kone


On Sept. 5, 2015, 12:01 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37532/
> ---
> 
> (Updated Sept. 5, 2015, 12:01 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is just part of MESOS-3037, this patch only add the interface
> of QUIESCE call.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
>   include/mesos/scheduler/scheduler.proto 
> 89daf8a6b74057ee156b3ad691397e76fcb835b8 
>   src/master/master.hpp e1331851c19e3372a4a525dcfd7ba2a01c3e97a6 
>   src/master/master.cpp 5589eca4317b597de509f3387cfc349083b361ac 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
> 
> Diff: https://reviews.apache.org/r/37532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-14 Thread Adam B


> On Sept. 4, 2015, 12:49 p.m., Vinod Kone wrote:
> > this review blocks a bunch of reviews? can you make the dependency linear? 
> > it would make my life easier to follow the chain of reviews.
> 
> Guangya Liu wrote:
> Thanks Vinod, both 37867 and 37866 are now discared but I do not know how 
> to remove them from depenency list, can you help?

I reopened the dependent reviews, cleared their "Depends on" sections, and 
re-discarded them. Now this review only blocks 37873.


- Adam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review97792
---


On Sept. 4, 2015, 5:01 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37532/
> ---
> 
> (Updated Sept. 4, 2015, 5:01 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is just part of MESOS-3037, this patch only add the interface
> of QUIESCE call.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
>   include/mesos/scheduler/scheduler.proto 
> 89daf8a6b74057ee156b3ad691397e76fcb835b8 
>   src/master/master.hpp e1331851c19e3372a4a525dcfd7ba2a01c3e97a6 
>   src/master/master.cpp 5589eca4317b597de509f3387cfc349083b361ac 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
> 
> Diff: https://reviews.apache.org/r/37532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-14 Thread Guangya Liu


> On Sept. 4, 2015, 7:49 p.m., Vinod Kone wrote:
> > this review blocks a bunch of reviews? can you make the dependency linear? 
> > it would make my life easier to follow the chain of reviews.
> 
> Guangya Liu wrote:
> Thanks Vinod, both 37867 and 37866 are now discared but I do not know how 
> to remove them from depenency list, can you help?
> 
> Adam B wrote:
> I reopened the dependent reviews, cleared their "Depends on" sections, 
> and re-discarded them. Now this review only blocks 37873.

Thansk Adam for the help!


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review97792
---


On Sept. 5, 2015, 12:01 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37532/
> ---
> 
> (Updated Sept. 5, 2015, 12:01 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is just part of MESOS-3037, this patch only add the interface
> of QUIESCE call.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
>   include/mesos/scheduler/scheduler.proto 
> 89daf8a6b74057ee156b3ad691397e76fcb835b8 
>   src/master/master.hpp e1331851c19e3372a4a525dcfd7ba2a01c3e97a6 
>   src/master/master.cpp 5589eca4317b597de509f3387cfc349083b361ac 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
> 
> Diff: https://reviews.apache.org/r/37532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-04 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/
---

(Updated 九月 4, 2015, 12:06 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

This is just part of MESOS-3037, this patch only add the interface
of QUIESCE call.


Diffs (updated)
-

  include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
  include/mesos/scheduler/scheduler.proto 
89daf8a6b74057ee156b3ad691397e76fcb835b8 
  src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b 
  src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 
  src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 

Diff: https://reviews.apache.org/r/37532/diff/


Testing
---


Thanks,

Guangya Liu



Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-04 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review97792
---


this review blocks a bunch of reviews? can you make the dependency linear? it 
would make my life easier to follow the chain of reviews.


include/mesos/scheduler/scheduler.proto (line 173)


period at the end.

does this fit within 80 char limit?



src/master/master.cpp (line 2540)


period.



src/master/master.cpp (line 2541)


s/INFO/WARNING/


- Vinod Kone


On Sept. 4, 2015, 12:06 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37532/
> ---
> 
> (Updated Sept. 4, 2015, 12:06 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is just part of MESOS-3037, this patch only add the interface
> of QUIESCE call.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
>   include/mesos/scheduler/scheduler.proto 
> 89daf8a6b74057ee156b3ad691397e76fcb835b8 
>   src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b 
>   src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
> 
> Diff: https://reviews.apache.org/r/37532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-04 Thread Guangya Liu


> On 九月 4, 2015, 7:49 p.m., Vinod Kone wrote:
> > this review blocks a bunch of reviews? can you make the dependency linear? 
> > it would make my life easier to follow the chain of reviews.

Thanks Vinod, both 37867 and 37866 are now discared but I do not know how to 
remove them from depenency list, can you help?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review97792
---


On 九月 5, 2015, 12:01 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37532/
> ---
> 
> (Updated 九月 5, 2015, 12:01 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is just part of MESOS-3037, this patch only add the interface
> of QUIESCE call.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
>   include/mesos/scheduler/scheduler.proto 
> 89daf8a6b74057ee156b3ad691397e76fcb835b8 
>   src/master/master.hpp e1331851c19e3372a4a525dcfd7ba2a01c3e97a6 
>   src/master/master.cpp 5589eca4317b597de509f3387cfc349083b361ac 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
> 
> Diff: https://reviews.apache.org/r/37532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-03 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/
---

(Updated 九月 4, 2015, 2:20 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

This is just part of MESOS-3037, this patch only add the interface
of QUIESCE call.


Diffs (updated)
-

  include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
  include/mesos/scheduler/scheduler.proto 
89daf8a6b74057ee156b3ad691397e76fcb835b8 
  src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b 
  src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 
  src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 

Diff: https://reviews.apache.org/r/37532/diff/


Testing
---


Thanks,

Guangya Liu



Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-03 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/
---

(Updated Sept. 4, 2015, 3:35 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

removed circular dep -- @vinodkone


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

This is just part of MESOS-3037, this patch only add the interface
of QUIESCE call.


Diffs
-

  include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
  include/mesos/scheduler/scheduler.proto 
89daf8a6b74057ee156b3ad691397e76fcb835b8 
  src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b 
  src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 
  src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 

Diff: https://reviews.apache.org/r/37532/diff/


Testing
---


Thanks,

Guangya Liu



Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-01 Thread Guangya Liu


> On 八月 20, 2015, 7:39 p.m., Marco Massenzio wrote:
> > include/mesos/scheduler/scheduler.proto, lines 314-315
> > 
> >
> > This comments does not read well: what is the timeout? also, it would 
> > be good to have a bit of info about what the filters are
> > 
> > (eg, are they 'inclusion' or 'exclusion' filters? etc.)
> 
> Guangya Liu wrote:
> Marco, can you pls show more the difference between "inclusion" and 
> "exclusion" filters? I'm not quite catch this point. Thanks.
> 
> Marco Massenzio wrote:
> Well, I am assuming that the `filters` here will take a conditional 
> action based on a `Predicate`? (I am sorry, I don't really know what the 
> `Filters` are for here - this was part of what I was asking for more 
> documentation about this - please assume that the reader may not have access 
> to all the source code - this is certainly true for people using Java 
> bindings, who only usually look at the javadoc).
> 
> So, if you have method `foo()` that takes some `filters` to take some 
> `action` on a given set of objects - the filters are "inclusive" if they will 
> result in `action` being taken only on those objects for which 
> `Predicate(Object) == true` - "exclusion" filters will instead **not** take 
> action under the same circumstance.
> 
> Think of it as `-v` in `grep` :)

Thanks Marco. Here the filter is just a refused time out, when this time out 
reached, the frameworks can get resource offers again. Quiesce offer will set 
filters to frameworks to disable resource offers and revive offer will clear 
the filter to enable resource offering. The quiesce offer will also be revived 
when the filter time out reached.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review95997
---


On 八月 31, 2015, 1:23 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37532/
> ---
> 
> (Updated 八月 31, 2015, 1:23 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is just part of MESOS-3037, this patch only add the interface
> of QUIESCE call.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
>   include/mesos/scheduler/scheduler.proto 
> 89daf8a6b74057ee156b3ad691397e76fcb835b8 
>   src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
>   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
> 
> Diff: https://reviews.apache.org/r/37532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-01 Thread Guangya Liu


> On 八月 20, 2015, 7:39 p.m., Marco Massenzio wrote:
> > include/mesos/scheduler/scheduler.proto, lines 314-315
> > 
> >
> > This comments does not read well: what is the timeout? also, it would 
> > be good to have a bit of info about what the filters are
> > 
> > (eg, are they 'inclusion' or 'exclusion' filters? etc.)
> 
> Guangya Liu wrote:
> Marco, can you pls show more the difference between "inclusion" and 
> "exclusion" filters? I'm not quite catch this point. Thanks.
> 
> Marco Massenzio wrote:
> Well, I am assuming that the `filters` here will take a conditional 
> action based on a `Predicate`? (I am sorry, I don't really know what the 
> `Filters` are for here - this was part of what I was asking for more 
> documentation about this - please assume that the reader may not have access 
> to all the source code - this is certainly true for people using Java 
> bindings, who only usually look at the javadoc).
> 
> So, if you have method `foo()` that takes some `filters` to take some 
> `action` on a given set of objects - the filters are "inclusive" if they will 
> result in `action` being taken only on those objects for which 
> `Predicate(Object) == true` - "exclusion" filters will instead **not** take 
> action under the same circumstance.
> 
> Think of it as `-v` in `grep` :)
> 
> Guangya Liu wrote:
> Thanks Marco. Here the filter is just a refused time out, when this time 
> out reached, the frameworks can get resource offers again. Quiesce offer will 
> set filters to frameworks to disable resource offers and revive offer will 
> clear the filter to enable resource offering. The quiesce offer will also be 
> revived when the filter time out reached.
> 
> Marco Massenzio wrote:
> Great, thanks - I'd suggest to add this information to the javadoc:
> ```
> // The quiesce message from the framework will disable resource offers 
> until a Revive message clears the filter to enable resource offering.
> // When the timeout expires, the frameworks will start receiving resource 
> offers again.
> ```
> 
> Or something to this effect (I'm sorry, I'm not that familiar with this 
> part yet, so I may have gotten the finer details wrong).

Sure, will update to the scheduler.proto file. Also update the information a 
bit as following, please show your comments if any. Thanks!
// The quiesce message from the framework will disable resource offers until a 
Revive message clears the filter to enable resource offering or the quiesce 
message filter time out expires


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review95997
---


On 八月 31, 2015, 1:23 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37532/
> ---
> 
> (Updated 八月 31, 2015, 1:23 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is just part of MESOS-3037, this patch only add the interface
> of QUIESCE call.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
>   include/mesos/scheduler/scheduler.proto 
> 89daf8a6b74057ee156b3ad691397e76fcb835b8 
>   src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
>   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
> 
> Diff: https://reviews.apache.org/r/37532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-01 Thread Marco Massenzio


> On Aug. 20, 2015, 7:39 p.m., Marco Massenzio wrote:
> > include/mesos/scheduler/scheduler.proto, lines 314-315
> > 
> >
> > This comments does not read well: what is the timeout? also, it would 
> > be good to have a bit of info about what the filters are
> > 
> > (eg, are they 'inclusion' or 'exclusion' filters? etc.)
> 
> Guangya Liu wrote:
> Marco, can you pls show more the difference between "inclusion" and 
> "exclusion" filters? I'm not quite catch this point. Thanks.

Well, I am assuming that the `filters` here will take a conditional action 
based on a `Predicate`? (I am sorry, I don't really know what the `Filters` are 
for here - this was part of what I was asking for more documentation about this 
- please assume that the reader may not have access to all the source code - 
this is certainly true for people using Java bindings, who only usually look at 
the javadoc).

So, if you have method `foo()` that takes some `filters` to take some `action` 
on a given set of objects - the filters are "inclusive" if they will result in 
`action` being taken only on those objects for which `Predicate(Object) == 
true` - "exclusion" filters will instead **not** take action under the same 
circumstance.

Think of it as `-v` in `grep` :)


> On Aug. 20, 2015, 7:39 p.m., Marco Massenzio wrote:
> > src/tests/scheduler_tests.cpp, line 1003
> > 
> >
> > so, this is a good test, but I would really like to see one where we 
> > ask Master to keep quiet for a while and we don't get offers during that 
> > period of time, then we start getting again.
> > 
> > It may require some fiddling around with `Clock`s and all that jazz, 
> > but it would give us more confidence that this whole thing works.
> > 
> > Also - some tests around more complex filtering (if any? maybe this is 
> > there is, then it's fine).
> 
> Guangya Liu wrote:
> I'm planning to add more test cases in another patch, make sense? Thanks.

Ok - so long as the patches are related and will be committed together.
Please make sure to mark them accordingly.


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review95997
---


On Aug. 31, 2015, 1:23 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37532/
> ---
> 
> (Updated Aug. 31, 2015, 1:23 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is just part of MESOS-3037, this patch only add the interface
> of QUIESCE call.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
>   include/mesos/scheduler/scheduler.proto 
> 89daf8a6b74057ee156b3ad691397e76fcb835b8 
>   src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
>   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
> 
> Diff: https://reviews.apache.org/r/37532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-01 Thread Marco Massenzio


> On Aug. 20, 2015, 7:39 p.m., Marco Massenzio wrote:
> > include/mesos/scheduler/scheduler.proto, lines 314-315
> > 
> >
> > This comments does not read well: what is the timeout? also, it would 
> > be good to have a bit of info about what the filters are
> > 
> > (eg, are they 'inclusion' or 'exclusion' filters? etc.)
> 
> Guangya Liu wrote:
> Marco, can you pls show more the difference between "inclusion" and 
> "exclusion" filters? I'm not quite catch this point. Thanks.
> 
> Marco Massenzio wrote:
> Well, I am assuming that the `filters` here will take a conditional 
> action based on a `Predicate`? (I am sorry, I don't really know what the 
> `Filters` are for here - this was part of what I was asking for more 
> documentation about this - please assume that the reader may not have access 
> to all the source code - this is certainly true for people using Java 
> bindings, who only usually look at the javadoc).
> 
> So, if you have method `foo()` that takes some `filters` to take some 
> `action` on a given set of objects - the filters are "inclusive" if they will 
> result in `action` being taken only on those objects for which 
> `Predicate(Object) == true` - "exclusion" filters will instead **not** take 
> action under the same circumstance.
> 
> Think of it as `-v` in `grep` :)
> 
> Guangya Liu wrote:
> Thanks Marco. Here the filter is just a refused time out, when this time 
> out reached, the frameworks can get resource offers again. Quiesce offer will 
> set filters to frameworks to disable resource offers and revive offer will 
> clear the filter to enable resource offering. The quiesce offer will also be 
> revived when the filter time out reached.

Great, thanks - I'd suggest to add this information to the javadoc:
```
// The quiesce message from the framework will disable resource offers until a 
Revive message clears the filter to enable resource offering.
// When the timeout expires, the frameworks will start receiving resource 
offers again.
```

Or something to this effect (I'm sorry, I'm not that familiar with this part 
yet, so I may have gotten the finer details wrong).


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review95997
---


On Aug. 31, 2015, 1:23 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37532/
> ---
> 
> (Updated Aug. 31, 2015, 1:23 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is just part of MESOS-3037, this patch only add the interface
> of QUIESCE call.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
>   include/mesos/scheduler/scheduler.proto 
> 89daf8a6b74057ee156b3ad691397e76fcb835b8 
>   src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
>   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
> 
> Diff: https://reviews.apache.org/r/37532/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-27 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/
---

(Updated Aug. 28, 2015, 3:40 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

This is just part of MESOS-3037, this patch only add the interface
of QUIESCE call.


Diffs (updated)
-

  include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
  include/mesos/scheduler/scheduler.proto 
89daf8a6b74057ee156b3ad691397e76fcb835b8 
  src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
  src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
  src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 

Diff: https://reviews.apache.org/r/37532/diff/


Testing
---


Thanks,

Guangya Liu



Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-27 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/
---

(Updated Aug. 28, 2015, 5:53 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

This is just part of MESOS-3037, this patch only add the interface
of QUIESCE call.


Diffs (updated)
-

  include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
  include/mesos/scheduler/scheduler.proto 
89daf8a6b74057ee156b3ad691397e76fcb835b8 
  src/master/master.hpp 36c67599ef2c470da8d95f2caf926a154342d2cc 
  src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
  src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 

Diff: https://reviews.apache.org/r/37532/diff/


Testing
---


Thanks,

Guangya Liu



Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-27 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/
---

(Updated Aug. 28, 2015, 1:35 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

This is just part of MESOS-3037, this patch only add the interface
of QUIESCE call.


Diffs (updated)
-

  include/mesos/scheduler/scheduler.proto 
89daf8a6b74057ee156b3ad691397e76fcb835b8 
  include/mesos/v1/scheduler/scheduler.proto 
bd5e82a614b1163b29f9b20e562208efa1ba4b55 

Diff: https://reviews.apache.org/r/37532/diff/


Testing
---


Thanks,

Guangya Liu



Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-27 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/
---

(Updated Aug. 28, 2015, 1:46 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

This is just part of MESOS-3037, this patch only add the interface
of QUIESCE call.


Diffs (updated)
-

  include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
  include/mesos/scheduler/scheduler.proto 
89daf8a6b74057ee156b3ad691397e76fcb835b8 
  include/mesos/v1/scheduler/scheduler.proto 
bd5e82a614b1163b29f9b20e562208efa1ba4b55 

Diff: https://reviews.apache.org/r/37532/diff/


Testing
---


Thanks,

Guangya Liu



Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-27 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/
---

(Updated Aug. 28, 2015, 3:10 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

This is just part of MESOS-3037, this patch only add the interface
of QUIESCE call.


Diffs (updated)
-

  include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
  include/mesos/scheduler/scheduler.proto 
89daf8a6b74057ee156b3ad691397e76fcb835b8 
  include/mesos/v1/scheduler/scheduler.proto 
bd5e82a614b1163b29f9b20e562208efa1ba4b55 

Diff: https://reviews.apache.org/r/37532/diff/


Testing
---


Thanks,

Guangya Liu



Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-26 Thread Guangya Liu


 On Aug. 25, 2015, 11:46 p.m., Vinod Kone wrote:
  Can you split the addition of suppress to the driver (sched.cpp) and http 
  library (scheduler.cpp) into separate patches? Note that the former needs 
  updates to the Java and Python bindings as well.
  
  More importantly, are you planning to plumb this call through to the 
  allocator to actually do the quiescing/suppressing?

OK, will try to split those patches.

Yes, I was planning to use allocator to trigger master do the 
quiescing/supperssing, any comments on this? Thanks.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review96453
---


On Aug. 22, 2015, 2:27 p.m., Guangya Liu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37532/
 ---
 
 (Updated Aug. 22, 2015, 2:27 p.m.)
 
 
 Review request for mesos and Vinod Kone.
 
 
 Bugs: MESOS-3037
 https://issues.apache.org/jira/browse/MESOS-3037
 
 
 Repository: mesos
 
 
 Description
 ---
 
 This is just part of MESOS-3037, this patch only add the interface
 of QUIESCE call.
 
 
 Diffs
 -
 
   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
   include/mesos/scheduler/scheduler.proto 
 89daf8a6b74057ee156b3ad691397e76fcb835b8 
   include/mesos/v1/scheduler/scheduler.proto 
 bd5e82a614b1163b29f9b20e562208efa1ba4b55 
   src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be 
   src/master/master.cpp c5e6c6f3304060d4c92d52851951f10bc432500e 
   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
   src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968 
 
 Diff: https://reviews.apache.org/r/37532/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Guangya Liu
 




Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-26 Thread Guangya Liu


 On Aug. 25, 2015, 11:46 p.m., Vinod Kone wrote:
  Can you split the addition of suppress to the driver (sched.cpp) and http 
  library (scheduler.cpp) into separate patches? Note that the former needs 
  updates to the Java and Python bindings as well.
  
  More importantly, are you planning to plumb this call through to the 
  allocator to actually do the quiescing/suppressing?
 
 Guangya Liu wrote:
 OK, will try to split those patches.
 
 Yes, I was planning to use allocator to trigger master do the 
 quiescing/supperssing, any comments on this? Thanks.

Vinod, hope I can get more comments from you for the desing. In MESOS-3037, you 
mentioned that For the scheduler driver to send only Call messages 
(MESOS-2913), DeactivateFrameworkMessage needs to be converted to Call(s). We 
can implement this by having the driver send a SUPPRESS call followed by a 
DECLINE call for outstanding offers., so do you mean that the 
quiescing/suppress offer need depend on decline offer?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review96453
---


On Aug. 22, 2015, 2:27 p.m., Guangya Liu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37532/
 ---
 
 (Updated Aug. 22, 2015, 2:27 p.m.)
 
 
 Review request for mesos and Vinod Kone.
 
 
 Bugs: MESOS-3037
 https://issues.apache.org/jira/browse/MESOS-3037
 
 
 Repository: mesos
 
 
 Description
 ---
 
 This is just part of MESOS-3037, this patch only add the interface
 of QUIESCE call.
 
 
 Diffs
 -
 
   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
   include/mesos/scheduler/scheduler.proto 
 89daf8a6b74057ee156b3ad691397e76fcb835b8 
   include/mesos/v1/scheduler/scheduler.proto 
 bd5e82a614b1163b29f9b20e562208efa1ba4b55 
   src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be 
   src/master/master.cpp c5e6c6f3304060d4c92d52851951f10bc432500e 
   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
   src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968 
 
 Diff: https://reviews.apache.org/r/37532/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Guangya Liu
 




Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-25 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review96453
---


Can you split the addition of suppress to the driver (sched.cpp) and http 
library (scheduler.cpp) into separate patches? Note that the former needs 
updates to the Java and Python bindings as well.

More importantly, are you planning to plumb this call through to the allocator 
to actually do the quiescing/suppressing?

- Vinod Kone


On Aug. 22, 2015, 2:27 p.m., Guangya Liu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37532/
 ---
 
 (Updated Aug. 22, 2015, 2:27 p.m.)
 
 
 Review request for mesos and Vinod Kone.
 
 
 Bugs: MESOS-3037
 https://issues.apache.org/jira/browse/MESOS-3037
 
 
 Repository: mesos
 
 
 Description
 ---
 
 This is just part of MESOS-3037, this patch only add the interface
 of QUIESCE call.
 
 
 Diffs
 -
 
   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
   include/mesos/scheduler/scheduler.proto 
 89daf8a6b74057ee156b3ad691397e76fcb835b8 
   include/mesos/v1/scheduler/scheduler.proto 
 bd5e82a614b1163b29f9b20e562208efa1ba4b55 
   src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be 
   src/master/master.cpp c5e6c6f3304060d4c92d52851951f10bc432500e 
   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
   src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968 
 
 Diff: https://reviews.apache.org/r/37532/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Guangya Liu
 




Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-22 Thread Guangya Liu


 On 八月 20, 2015, 7:39 p.m., Marco Massenzio wrote:
  include/mesos/scheduler/scheduler.proto, lines 314-315
  https://reviews.apache.org/r/37532/diff/1/?file=1042006#file1042006line314
 
  This comments does not read well: what is the timeout? also, it would 
  be good to have a bit of info about what the filters are
  
  (eg, are they 'inclusion' or 'exclusion' filters? etc.)

Marco, can you pls show more the difference between inclusion and exclusion 
filters? I'm not quite catch this point. Thanks.


 On 八月 20, 2015, 7:39 p.m., Marco Massenzio wrote:
  src/tests/scheduler_tests.cpp, line 1003
  https://reviews.apache.org/r/37532/diff/1/?file=1042011#file1042011line1003
 
  so, this is a good test, but I would really like to see one where we 
  ask Master to keep quiet for a while and we don't get offers during that 
  period of time, then we start getting again.
  
  It may require some fiddling around with `Clock`s and all that jazz, 
  but it would give us more confidence that this whole thing works.
  
  Also - some tests around more complex filtering (if any? maybe this is 
  there is, then it's fine).

I'm planning to add more test cases in another patch, make sense? Thanks.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review95997
---


On 八月 17, 2015, 1:47 p.m., Guangya Liu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37532/
 ---
 
 (Updated 八月 17, 2015, 1:47 p.m.)
 
 
 Review request for mesos and Vinod Kone.
 
 
 Bugs: MESOS-3037
 https://issues.apache.org/jira/browse/MESOS-3037
 
 
 Repository: mesos
 
 
 Description
 ---
 
 This is just part of MESOS-3037, this patch only add the interface
 of QUIESCE call.
 
 
 Diffs
 -
 
   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
   include/mesos/scheduler/scheduler.proto 
 89daf8a6b74057ee156b3ad691397e76fcb835b8 
   include/mesos/v1/scheduler/scheduler.proto 
 bd5e82a614b1163b29f9b20e562208efa1ba4b55 
   src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be 
   src/master/master.cpp c5e6c6f3304060d4c92d52851951f10bc432500e 
   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
   src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968 
 
 Diff: https://reviews.apache.org/r/37532/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Guangya Liu
 




Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-22 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/
---

(Updated 八月 22, 2015, 2:27 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Thanks Marco, another patch is uploaded according to your comments.


Bugs: MESOS-3037
https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
---

This is just part of MESOS-3037, this patch only add the interface
of QUIESCE call.


Diffs (updated)
-

  include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
  include/mesos/scheduler/scheduler.proto 
89daf8a6b74057ee156b3ad691397e76fcb835b8 
  include/mesos/v1/scheduler/scheduler.proto 
bd5e82a614b1163b29f9b20e562208efa1ba4b55 
  src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be 
  src/master/master.cpp c5e6c6f3304060d4c92d52851951f10bc432500e 
  src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
  src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968 

Diff: https://reviews.apache.org/r/37532/diff/


Testing
---


Thanks,

Guangya Liu



Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-20 Thread Marco Massenzio

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review95997
---



include/mesos/scheduler.hpp (line 273)
https://reviews.apache.org/r/37532/#comment151190

indent is off?



include/mesos/scheduler.hpp (line 424)
https://reviews.apache.org/r/37532/#comment151195

indent



include/mesos/scheduler/scheduler.proto (line 173)
https://reviews.apache.org/r/37532/#comment151191

micro-nit: the // is not aligned with lines above.



include/mesos/scheduler/scheduler.proto (lines 314 - 315)
https://reviews.apache.org/r/37532/#comment151192

This comments does not read well: what is the timeout? also, it would be 
good to have a bit of info about what the filters are

(eg, are they 'inclusion' or 'exclusion' filters? etc.)



src/master/master.cpp (line 2507)
https://reviews.apache.org/r/37532/#comment151193

IMO we should LOG(INFO) here to state this is not implemented yet or 
something.

Otherwise, say people see this and start using it, then nothing happens, 
look at the logs (which give the impression that the Processing QUIESCE was 
successfully called) and will report it as a bug.



src/sched/sched.cpp (line 1953)
https://reviews.apache.org/r/37532/#comment151194

indent off



src/tests/scheduler_tests.cpp (line 1003)
https://reviews.apache.org/r/37532/#comment151196

so, this is a good test, but I would really like to see one where we ask 
Master to keep quiet for a while and we don't get offers during that period of 
time, then we start getting again.

It may require some fiddling around with `Clock`s and all that jazz, but it 
would give us more confidence that this whole thing works.

Also - some tests around more complex filtering (if any? maybe this is 
there is, then it's fine).


- Marco Massenzio


On Aug. 17, 2015, 1:47 p.m., Guangya Liu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37532/
 ---
 
 (Updated Aug. 17, 2015, 1:47 p.m.)
 
 
 Review request for mesos and Vinod Kone.
 
 
 Bugs: MESOS-3037
 https://issues.apache.org/jira/browse/MESOS-3037
 
 
 Repository: mesos
 
 
 Description
 ---
 
 This is just part of MESOS-3037, this patch only add the interface
 of QUIESCE call.
 
 
 Diffs
 -
 
   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
   include/mesos/scheduler/scheduler.proto 
 89daf8a6b74057ee156b3ad691397e76fcb835b8 
   include/mesos/v1/scheduler/scheduler.proto 
 bd5e82a614b1163b29f9b20e562208efa1ba4b55 
   src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be 
   src/master/master.cpp c5e6c6f3304060d4c92d52851951f10bc432500e 
   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
   src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968 
 
 Diff: https://reviews.apache.org/r/37532/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Guangya Liu
 




Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-17 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review95645
---


Patch looks great!

Reviews applied: [37532]

All tests passed.

- Mesos ReviewBot


On Aug. 17, 2015, 1:47 p.m., Guangya Liu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37532/
 ---
 
 (Updated Aug. 17, 2015, 1:47 p.m.)
 
 
 Review request for mesos and Vinod Kone.
 
 
 Bugs: MESOS-3037
 https://issues.apache.org/jira/browse/MESOS-3037
 
 
 Repository: mesos
 
 
 Description
 ---
 
 This is just part of MESOS-3037, this patch only add the interface
 of QUIESCE call.
 
 
 Diffs
 -
 
   include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd 
   include/mesos/scheduler/scheduler.proto 
 89daf8a6b74057ee156b3ad691397e76fcb835b8 
   include/mesos/v1/scheduler/scheduler.proto 
 bd5e82a614b1163b29f9b20e562208efa1ba4b55 
   src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be 
   src/master/master.cpp c5e6c6f3304060d4c92d52851951f10bc432500e 
   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
   src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968 
 
 Diff: https://reviews.apache.org/r/37532/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Guangya Liu