Re: Review Request 37541: Add TraceEvent API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37541/ --- (Updated Sept. 2, 2015, 10:14 p.m.) Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. Changes --- Rebase and cleanup Bugs: MESOS-2769 https://issues.apache.org/jira/browse/MESOS-2769 Repository: mesos Description --- Based on the PerfEvent API's, add API for Linux kernel trace events, especially the schedule trace events. Diffs (updated) - src/linux/perf.hpp c5630118f4858b1a805f25a2db7a24ca0989 src/linux/perf.cpp bb8b5918e4c8f4379784d4fa18c3b4709696e1ea src/tests/containerizer/cgroups_tests.cpp 75a3bc0009c037dc18ce319db2eb44630f083e8c src/tests/containerizer/perf_tests.cpp 8c29ca3dc2a8f6d1fb0f430482190f87f08eb4e8 Diff: https://reviews.apache.org/r/37541/diff/ Testing --- make check Thanks, Cong Wang
Re: Review Request 37541: Add TraceEvent API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37541/#review96969 --- Patch looks great! Reviews applied: [37540, 37541] All tests passed. - Mesos ReviewBot On Aug. 28, 2015, 11:07 p.m., Cong Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37541/ > --- > > (Updated Aug. 28, 2015, 11:07 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. > > > Bugs: MESOS-2769 > https://issues.apache.org/jira/browse/MESOS-2769 > > > Repository: mesos > > > Description > --- > > Based on the PerfEvent API's, add API for Linux kernel trace events, > especially the schedule trace events. > > > Diffs > - > > src/linux/perf.hpp b77b61d7048b12cea4586bcf802cbc2ff634331b > src/linux/perf.cpp cdc5f8314a875ababf2b17a32873775d808e1c78 > src/tests/containerizer/cgroups_tests.cpp > 0b171eeb53037f26b7e952830e88e59f1278e7c6 > src/tests/containerizer/perf_tests.cpp > 6b3d70f3e7ea8f59f94e6961491d4e9a730e3334 > > Diff: https://reviews.apache.org/r/37541/diff/ > > > Testing > --- > > make check > > > Thanks, > > Cong Wang > >
Re: Review Request 37541: Add TraceEvent API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37541/ --- (Updated Aug. 28, 2015, 11:07 p.m.) Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. Changes --- Clean up Bugs: MESOS-2769 https://issues.apache.org/jira/browse/MESOS-2769 Repository: mesos Description --- Based on the PerfEvent API's, add API for Linux kernel trace events, especially the schedule trace events. Diffs (updated) - src/linux/perf.hpp b77b61d7048b12cea4586bcf802cbc2ff634331b src/linux/perf.cpp cdc5f8314a875ababf2b17a32873775d808e1c78 src/tests/containerizer/cgroups_tests.cpp 0b171eeb53037f26b7e952830e88e59f1278e7c6 src/tests/containerizer/perf_tests.cpp 6b3d70f3e7ea8f59f94e6961491d4e9a730e3334 Diff: https://reviews.apache.org/r/37541/diff/ Testing --- make check Thanks, Cong Wang
Re: Review Request 37541: Add TraceEvent API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37541/ --- (Updated Aug. 25, 2015, 12:17 a.m.) Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. Bugs: MESOS-2769 https://issues.apache.org/jira/browse/MESOS-2769 Repository: mesos Description --- Based on the PerfEvent API's, add API for Linux kernel trace events, especially the schedule trace events. Diffs (updated) - src/linux/perf.hpp b77b61d7048b12cea4586bcf802cbc2ff634331b src/linux/perf.cpp cdc5f8314a875ababf2b17a32873775d808e1c78 src/tests/containerizer/perf_tests.cpp 6b3d70f3e7ea8f59f94e6961491d4e9a730e3334 Diff: https://reviews.apache.org/r/37541/diff/ Testing --- make check Thanks, Cong Wang
Re: Review Request 37541: Add TraceEvent API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37541/ --- (Updated Aug. 24, 2015, 9:32 p.m.) Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. Changes --- Cleanup Bugs: MESOS-2769 https://issues.apache.org/jira/browse/MESOS-2769 Repository: mesos Description --- Based on the PerfEvent API's, add API for Linux kernel trace events, especially the schedule trace events. Diffs (updated) - src/linux/perf.hpp b77b61d7048b12cea4586bcf802cbc2ff634331b src/linux/perf.cpp cdc5f8314a875ababf2b17a32873775d808e1c78 src/tests/containerizer/perf_tests.cpp 6b3d70f3e7ea8f59f94e6961491d4e9a730e3334 Diff: https://reviews.apache.org/r/37541/diff/ Testing --- make check Thanks, Cong Wang
Re: Review Request 37541: Add TraceEvent API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37541/ --- (Updated Aug. 17, 2015, 10:34 p.m.) Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. Changes --- Detect debugfs or tracefs mount at run-time. Bugs: MESOS-2769 https://issues.apache.org/jira/browse/MESOS-2769 Repository: mesos Description --- Based on the PerfEvent API's, add API for Linux kernel trace events, especially the schedule trace events. Diffs (updated) - src/linux/perf.hpp b77b61d7048b12cea4586bcf802cbc2ff634331b src/linux/perf.cpp cb1a13d0b1754a50f0121bfda522056ff8c3e3c8 src/tests/containerizer/perf_tests.cpp 6b3d70f3e7ea8f59f94e6961491d4e9a730e3334 Diff: https://reviews.apache.org/r/37541/diff/ Testing --- make check Thanks, Cong Wang