Re: Review Request 37589: Remove unnecessary usage information.

2015-09-10 Thread Michael Park


> On Aug. 30, 2015, 10:31 p.m., Michael Park wrote:
> > This is great! Many of these were slightly incorrect. They're all fixed now 
> > :)
> > e.g. `/statistics.json` -> `/monitor/statistics.json`

I've committed this patch for you with a trivial rebase.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37589/#review97041
---


On Aug. 18, 2015, 6:36 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37589/
> ---
> 
> (Updated Aug. 18, 2015, 6:36 p.m.)
> 
> 
> Review request for mesos, Michael Park and Vinod Kone.
> 
> 
> Bugs: MESOS-3239
> https://issues.apache.org/jira/browse/MESOS-3239
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Remove unnecessary usage information.
> 
> 
> Diffs
> -
> 
>   src/files/files.cpp a94a5eec0d4cf095f84255a66117947a308fdb2f 
>   src/master/http.cpp d016b3c055a06e7aa0649a36fd4b095c2938ba56 
>   src/master/registrar.cpp ca8efb4000a688ea42c84123db2a0d3fbe1227c3 
>   src/slave/http.cpp b0fe5f520dfca156548ba8c436d42fc432223f3d 
>   src/slave/monitor.cpp 82aa659b02f98ad8dc4c4f556be7a332dfba6816 
> 
> Diff: https://reviews.apache.org/r/37589/diff/
> 
> 
> Testing
> ---
> 
> manual test
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 37589: Remove unnecessary usage information.

2015-08-19 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37589/#review95887
---


Patch looks great!

Reviews applied: [37586, 37589]

All tests passed.

- Mesos ReviewBot


On Aug. 18, 2015, 6:36 p.m., haosdent huang wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37589/
 ---
 
 (Updated Aug. 18, 2015, 6:36 p.m.)
 
 
 Review request for mesos, Michael Park and Vinod Kone.
 
 
 Bugs: MESOS-3239
 https://issues.apache.org/jira/browse/MESOS-3239
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Remove unnecessary usage information.
 
 
 Diffs
 -
 
   src/files/files.cpp a94a5eec0d4cf095f84255a66117947a308fdb2f 
   src/master/http.cpp d016b3c055a06e7aa0649a36fd4b095c2938ba56 
   src/master/registrar.cpp ca8efb4000a688ea42c84123db2a0d3fbe1227c3 
   src/slave/http.cpp b0fe5f520dfca156548ba8c436d42fc432223f3d 
   src/slave/monitor.cpp 82aa659b02f98ad8dc4c4f556be7a332dfba6816 
 
 Diff: https://reviews.apache.org/r/37589/diff/
 
 
 Testing
 ---
 
 manual test
 
 
 Thanks,
 
 haosdent huang
 




Re: Review Request 37589: Remove unnecessary usage information.

2015-08-18 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37589/
---

(Updated Aug. 18, 2015, 6:36 p.m.)


Review request for mesos, Michael Park and Vinod Kone.


Summary (updated)
-

Remove unnecessary usage information.


Bugs: MESOS-3239
https://issues.apache.org/jira/browse/MESOS-3239


Repository: mesos


Description (updated)
---

Remove unnecessary usage information.


Diffs
-

  src/files/files.cpp a94a5eec0d4cf095f84255a66117947a308fdb2f 
  src/master/http.cpp d016b3c055a06e7aa0649a36fd4b095c2938ba56 
  src/master/registrar.cpp ca8efb4000a688ea42c84123db2a0d3fbe1227c3 
  src/slave/http.cpp b0fe5f520dfca156548ba8c436d42fc432223f3d 
  src/slave/monitor.cpp 82aa659b02f98ad8dc4c4f556be7a332dfba6816 

Diff: https://reviews.apache.org/r/37589/diff/


Testing
---

manual test


Thanks,

haosdent huang



Re: Review Request 37589: Remove unnecessary usage information.

2015-08-18 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37589/#review95808
---

Ship it!


Ship It!

- Guangya Liu


On 八月 18, 2015, 6:36 p.m., haosdent huang wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37589/
 ---
 
 (Updated 八月 18, 2015, 6:36 p.m.)
 
 
 Review request for mesos, Michael Park and Vinod Kone.
 
 
 Bugs: MESOS-3239
 https://issues.apache.org/jira/browse/MESOS-3239
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Remove unnecessary usage information.
 
 
 Diffs
 -
 
   src/files/files.cpp a94a5eec0d4cf095f84255a66117947a308fdb2f 
   src/master/http.cpp d016b3c055a06e7aa0649a36fd4b095c2938ba56 
   src/master/registrar.cpp ca8efb4000a688ea42c84123db2a0d3fbe1227c3 
   src/slave/http.cpp b0fe5f520dfca156548ba8c436d42fc432223f3d 
   src/slave/monitor.cpp 82aa659b02f98ad8dc4c4f556be7a332dfba6816 
 
 Diff: https://reviews.apache.org/r/37589/diff/
 
 
 Testing
 ---
 
 manual test
 
 
 Thanks,
 
 haosdent huang