Re: Review Request 37657: Document iptable rule need added when use docker bridge network mode.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37657/#review96020 --- docs/docker-containerizer.md (line 21) https://reviews.apache.org/r/37657/#comment151215 I'm also not a native speaker, but i'd suggest to: If *iptables* enabled on slave, make sure *iptables* accept all traffic from docker bridge interface. Example: ``` iptables -A INPUT -s 172.17.0.0/16 -i docker0 -p tcp -j ACCEPT ``` - Klaus Ma On 八月 20, 2015, 5:30 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37657/ --- (Updated 八月 20, 2015, 5:30 p.m.) Review request for mesos, Klaus Ma and Timothy Chen. Bugs: MESOS-3053 https://issues.apache.org/jira/browse/MESOS-3053 Repository: mesos Description --- Document iptable rule need added when use docker bridge network mode. Diffs - docs/docker-containerizer.md 73f897780a0bb72ab092cb08186a228e3084e798 Diff: https://reviews.apache.org/r/37657/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 37657: Document iptable rule need added when use docker bridge network mode.
On 八月 21, 2015, 1:26 a.m., Klaus Ma wrote: docs/docker-containerizer.md, line 21 https://reviews.apache.org/r/37657/diff/1/?file=1045176#file1045176line21 I'm also not a native speaker, but i'd suggest to: If *iptables* enabled on slave, make sure *iptables* accept all traffic from docker bridge interface. Example: ``` iptables -A INPUT -s 172.17.0.0/16 -i docker0 -p tcp -j ACCEPT ``` haosdent huang wrote: Because the patch is submitted, if it is not urgent, could update next time. :-) sure, it's clear enough to end user :). - Klaus --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37657/#review96020 --- On 八月 20, 2015, 5:30 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37657/ --- (Updated 八月 20, 2015, 5:30 p.m.) Review request for mesos, Klaus Ma and Timothy Chen. Bugs: MESOS-3053 https://issues.apache.org/jira/browse/MESOS-3053 Repository: mesos Description --- Document iptable rule need added when use docker bridge network mode. Diffs - docs/docker-containerizer.md 73f897780a0bb72ab092cb08186a228e3084e798 Diff: https://reviews.apache.org/r/37657/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 37657: Document iptable rule need added when use docker bridge network mode.
On Aug. 21, 2015, 1:26 a.m., Klaus Ma wrote: docs/docker-containerizer.md, line 21 https://reviews.apache.org/r/37657/diff/1/?file=1045176#file1045176line21 I'm also not a native speaker, but i'd suggest to: If *iptables* enabled on slave, make sure *iptables* accept all traffic from docker bridge interface. Example: ``` iptables -A INPUT -s 172.17.0.0/16 -i docker0 -p tcp -j ACCEPT ``` Because the patch is submitted, if it is not urgent, could update next time. :-) - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37657/#review96020 --- On Aug. 20, 2015, 5:30 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37657/ --- (Updated Aug. 20, 2015, 5:30 p.m.) Review request for mesos, Klaus Ma and Timothy Chen. Bugs: MESOS-3053 https://issues.apache.org/jira/browse/MESOS-3053 Repository: mesos Description --- Document iptable rule need added when use docker bridge network mode. Diffs - docs/docker-containerizer.md 73f897780a0bb72ab092cb08186a228e3084e798 Diff: https://reviews.apache.org/r/37657/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 37657: Document iptable rule need added when use docker bridge network mode.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37657/#review95994 --- Ship it! Ship It! - Timothy Chen On Aug. 20, 2015, 5:30 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37657/ --- (Updated Aug. 20, 2015, 5:30 p.m.) Review request for mesos, Klaus Ma and Timothy Chen. Bugs: MESOS-3053 https://issues.apache.org/jira/browse/MESOS-3053 Repository: mesos Description --- Document iptable rule need added when use docker bridge network mode. Diffs - docs/docker-containerizer.md 73f897780a0bb72ab092cb08186a228e3084e798 Diff: https://reviews.apache.org/r/37657/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 37657: Document iptable rule need added when use docker bridge network mode.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37657/#review95995 --- Patch looks great! Reviews applied: [37657] All tests passed. - Mesos ReviewBot On Aug. 20, 2015, 5:30 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37657/ --- (Updated Aug. 20, 2015, 5:30 p.m.) Review request for mesos, Klaus Ma and Timothy Chen. Bugs: MESOS-3053 https://issues.apache.org/jira/browse/MESOS-3053 Repository: mesos Description --- Document iptable rule need added when use docker bridge network mode. Diffs - docs/docker-containerizer.md 73f897780a0bb72ab092cb08186a228e3084e798 Diff: https://reviews.apache.org/r/37657/diff/ Testing --- Thanks, haosdent huang
