Re: Review Request 37878: mesos: Replace volatile with std::atomic.

2015-09-10 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37878/
---

(Updated Sept. 10, 2015, 6:55 p.m.)


Review request for mesos, Joris Van Remoortere and switched to 'mcypark'.


Bugs: MESOS-3326
https://issues.apache.org/jira/browse/MESOS-3326


Repository: mesos


Description
---

MESOS-3326.


Diffs (updated)
-

  src/exec/exec.cpp 31e0c2f17a9092d18285828111d27628fb07bc02 
  src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 

Diff: https://reviews.apache.org/r/37878/diff/


Testing
---


Thanks,

Neil Conway



Re: Review Request 37878: mesos: Replace volatile with std::atomic.

2015-09-09 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37878/#review98212
---

Ship it!


- Joris Van Remoortere


On Sept. 9, 2015, 4:01 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37878/
> ---
> 
> (Updated Sept. 9, 2015, 4:01 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and switched to 'mcypark'.
> 
> 
> Bugs: MESOS-3326
> https://issues.apache.org/jira/browse/MESOS-3326
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3326.
> 
> 
> Diffs
> -
> 
>   src/exec/exec.cpp 31e0c2f17a9092d18285828111d27628fb07bc02 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
> 
> Diff: https://reviews.apache.org/r/37878/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Re: Review Request 37878: mesos: Replace volatile with std::atomic.

2015-08-28 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37878/#review96845
---


Patch looks great!

Reviews applied: [37876, 37877, 37878]

All tests passed.

- Mesos ReviewBot


On Aug. 28, 2015, 7:51 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37878/
> ---
> 
> (Updated Aug. 28, 2015, 7:51 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and switched to 
> 'mcypark'.
> 
> 
> Bugs: MESOS-3326
> https://issues.apache.org/jira/browse/MESOS-3326
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3326.
> 
> 
> Diffs
> -
> 
>   src/exec/exec.cpp 31e0c2f17a9092d18285828111d27628fb07bc02 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
> 
> Diff: https://reviews.apache.org/r/37878/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>