Re: Review Request 37880: Changed the Appc provisioner directory to identify a rootfs by a rootfs_id (UUID).

2015-09-03 Thread Chi Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37880/#review97701
---

Ship it!


Ship It!

- Chi Zhang


On Aug. 31, 2015, 5:44 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37880/
> ---
> 
> (Updated Aug. 31, 2015, 5:44 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2796
> https://issues.apache.org/jira/browse/MESOS-2796
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - So the user can provision multiple identical rootfses in the volumes of one 
> container, a case we don't need to disallow.
> - Previously a rootfs is identified by the 'image_id' of its topmost file 
> system layer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioners/appc/paths.hpp 
> 41e3bf79da0854406c488855f953111e67353829 
>   src/slave/containerizer/provisioners/appc/paths.cpp 
> 3113c84b9526dd9e9e89fb9aa4ec75ed66a996c7 
> 
> Diff: https://reviews.apache.org/r/37880/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>



Re: Review Request 37880: Changed the Appc provisioner directory to identify a rootfs by a rootfs_id (UUID).

2015-08-29 Thread Jiang Yan Xu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37880/
---

(Updated Aug. 29, 2015, 9:26 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-2796
https://issues.apache.org/jira/browse/MESOS-2796


Repository: mesos


Description
---

- So the user can provision multiple identical rootfses in the volumes of one 
container, a case we don't need to disallow.
- Previously a rootfs is identified by the 'image_id' of its topmost file 
system layer.


Diffs
-

  src/slave/containerizer/provisioners/appc/paths.hpp 
41e3bf79da0854406c488855f953111e67353829 
  src/slave/containerizer/provisioners/appc/paths.cpp 
3113c84b9526dd9e9e89fb9aa4ec75ed66a996c7 

Diff: https://reviews.apache.org/r/37880/diff/


Testing
---

make check.


Thanks,

Jiang Yan Xu