Re: Review Request 37894: Renamed cgroups::kill to cgroups::signal.

2015-08-31 Thread Timothy Chen
> On Aug. 28, 2015, 4:45 p.m., Cong Wang wrote: > > Why? Everyone knows kill(2) sends a signal while signal(2) installs a > > signal handler... > > Jie Yu wrote: > IMO, that naming is confusing, and should be 'signal' and 'install'. > > Joerg Schad wrote: > This is actually answering

Re: Review Request 37894: Renamed cgroups::kill to cgroups::signal.

2015-08-31 Thread Ben Mahler
> On Aug. 28, 2015, 4:45 p.m., Cong Wang wrote: > > Why? Everyone knows kill(2) sends a signal while signal(2) installs a > > signal handler... > > Jie Yu wrote: > IMO, that naming is confusing, and should be 'signal' and 'install'. > > Joerg Schad wrote: > This is actually answering

Re: Review Request 37894: Renamed cgroups::kill to cgroups::signal.

2015-08-28 Thread Jie Yu
On Aug. 28, 2015, 4:45 p.m., Cong Wang wrote: Why? Everyone knows kill(2) sends a signal while signal(2) installs a signal handler... IMO, that naming is confusing, and should be 'signal' and 'install'. - Jie --- This is an

Re: Review Request 37894: Renamed cgroups::kill to cgroups::signal.

2015-08-28 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37894/#review96883 --- Why? Everyone knows kill(2) sends a signal while signal(2) installs

Re: Review Request 37894: Renamed cgroups::kill to cgroups::signal.

2015-08-28 Thread Joerg Schad
On Aug. 28, 2015, 4:45 p.m., Cong Wang wrote: Why? Everyone knows kill(2) sends a signal while signal(2) installs a signal handler... Jie Yu wrote: IMO, that naming is confusing, and should be 'signal' and 'install'. This is actually answering a discussion here

Re: Review Request 37894: Renamed cgroups::kill to cgroups::signal.

2015-08-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37894/#review96897 --- Patch looks great! Reviews applied: [37894] All tests passed. -

Re: Review Request 37894: Renamed cgroups::kill to cgroups::signal.

2015-08-28 Thread Cong Wang
On Aug. 28, 2015, 4:45 p.m., Cong Wang wrote: Why? Everyone knows kill(2) sends a signal while signal(2) installs a signal handler... Jie Yu wrote: IMO, that naming is confusing, and should be 'signal' and 'install'. Joerg Schad wrote: This is actually answering a

Re: Review Request 37894: Renamed cgroups::kill to cgroups::signal.

2015-08-28 Thread Jie Yu
On Aug. 28, 2015, 4:45 p.m., Cong Wang wrote: Why? Everyone knows kill(2) sends a signal while signal(2) installs a signal handler... Jie Yu wrote: IMO, that naming is confusing, and should be 'signal' and 'install'. Joerg Schad wrote: This is actually answering a