Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37903/#review100848 --- I'll get this in today :) Thanks Neil! - Niklas Nielsen On

Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37903/ --- (Updated Sept. 24, 2015, 9:29 p.m.) Review request for mesos. Changes

Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37903/#review100509 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37903/#review99144 --- Patch looks great! Reviews applied: [37903] All tests passed. -

Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37903/ --- (Updated Sept. 15, 2015, 9:10 p.m.) Review request for mesos. Bugs:

Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37903/#review98301 --- Ship it! Minor nits

Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37903/ --- (Updated Sept. 10, 2015, 5:07 a.m.) Review request for mesos. Bugs:

Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix.

> On Sept. 9, 2015, 11:08 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, line 402 > > > > > > An alternative could have been: > > > > IP(prefix == 0 ? 0 :

Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37903/#review97170 --- Ship it! Or we can simply make 'prefix' unsigned. - Cong Wang

Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix.

> On Aug. 31, 2015, 10:28 p.m., Cong Wang wrote: > > Or we can simply make 'prefix' unsigned. Thanks for the review! As far as I know, making "prefix" unsigned would not help. The code in question is: "0x << (32 - prefix)". 0x is an unsigned integer literal -- left-shifting a

Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37903/#review96934 --- Patch looks great! Reviews applied: [37903] All tests passed. -