Re: Review Request 37914: Updated the ReviewBot to flag reviews that do not contain reviewers.

[Vinod Kone]

> On Sept. 21, 2015, 11:01 p.m., Ben Mahler wrote:
> > support/verify_reviews.py, line 141
> > 
> >
> > Maybe this should say bad review instead of bad patch?

done.


> On Sept. 21, 2015, 11:01 p.m., Ben Mahler wrote:
> > support/verify_reviews.py, line 142
> > 
> >
> > Is this line necessary for review related errors?

yes. much like for bad patches, this points to which review had the error.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37914/#review99856
---


On Aug. 29, 2015, 12:08 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37914/
> ---
> 
> (Updated Aug. 29, 2015, 12:08 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> I'm seeing more and more reviews being sent without tagging reviewers. This 
> should flag such reviews to guide new contributors.
> 
> 
> Diffs
> -
> 
>   support/verify_reviews.py b85a3245b2f248dbdb8e2783f2384092e3d53031 
> 
> Diff: https://reviews.apache.org/r/37914/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> ./support/verify_reviews.py vinod kone 10 "?from-user=neilc"
> git rev-parse HEAD
> Checking if review: 37445 needs verification
> Latest diff timestamp: 2015-08-13 21:01:08
> Verifying review 37445
> Posting review: Bad patch!
> 
> Reviews applied: []
> 
> Error:
>  No reviewers specified. Please find a reviewer by asking on JIRA or the 
> mailing list.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 37914: Updated the ReviewBot to flag reviews that do not contain reviewers.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37914/#review99856
---

Ship it!



support/verify_reviews.py (line 141)


Maybe this should say bad review instead of bad patch?



support/verify_reviews.py (line 142)


Is this line necessary for review related errors?


- Ben Mahler


On Aug. 29, 2015, 12:08 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37914/
> ---
> 
> (Updated Aug. 29, 2015, 12:08 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> I'm seeing more and more reviews being sent without tagging reviewers. This 
> should flag such reviews to guide new contributors.
> 
> 
> Diffs
> -
> 
>   support/verify_reviews.py b85a3245b2f248dbdb8e2783f2384092e3d53031 
> 
> Diff: https://reviews.apache.org/r/37914/diff/
> 
> 
> Testing
> ---
> 
> Tested locally
> 
> ./support/verify_reviews.py vinod kone 10 "?from-user=neilc"
> git rev-parse HEAD
> Checking if review: 37445 needs verification
> Latest diff timestamp: 2015-08-13 21:01:08
> Verifying review 37445
> Posting review: Bad patch!
> 
> Reviews applied: []
> 
> Error:
>  No reviewers specified. Please find a reviewer by asking on JIRA or the 
> mailing list.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 37914: Updated the ReviewBot to flag reviews that do not contain reviewers.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37914/#review96977
---


Patch looks great!

Reviews applied: [37914]

All tests passed.

- Mesos ReviewBot


On Aug. 29, 2015, 12:08 a.m., Vinod Kone wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37914/
 ---
 
 (Updated Aug. 29, 2015, 12:08 a.m.)
 
 
 Review request for mesos, Benjamin Hindman and Michael Park.
 
 
 Repository: mesos
 
 
 Description
 ---
 
 I'm seeing more and more reviews being sent without tagging reviewers. This 
 should flag such reviews to guide new contributors.
 
 
 Diffs
 -
 
   support/verify_reviews.py b85a3245b2f248dbdb8e2783f2384092e3d53031 
 
 Diff: https://reviews.apache.org/r/37914/diff/
 
 
 Testing
 ---
 
 Tested locally
 
 ./support/verify_reviews.py vinod kone 10 ?from-user=neilc
 git rev-parse HEAD
 Checking if review: 37445 needs verification
 Latest diff timestamp: 2015-08-13 21:01:08
 Verifying review 37445
 Posting review: Bad patch!
 
 Reviews applied: []
 
 Error:
  No reviewers specified. Please find a reviewer by asking on JIRA or the 
 mailing list.
 
 
 Thanks,
 
 Vinod Kone