Re: Review Request 38056: Fix webui task informations not update bug.

2015-09-23 Thread Philip Norman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38056/#review100182
---

Ship it!


Ship It!

- Philip Norman


On Sept. 16, 2015, 3:03 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38056/
> ---
> 
> (Updated Sept. 16, 2015, 3:03 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, Michael Park, and Philip 
> Norman.
> 
> 
> Bugs: MESOS-3282
> https://issues.apache.org/jira/browse/MESOS-3282
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix webui task informations not update bug.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/js/controllers.js 
> c4340ab94812433a2eadb1e5183b0765330cb844 
> 
> Diff: https://reviews.apache.org/r/38056/diff/
> 
> 
> Testing
> ---
> 
> Manual test, test scenarios:
> 
> * Normal scenarios updated after the new task is finished
> * After mesos-master down, could updated after reconnected
> 
> ![task_infomartions.png](https://issues.apache.org/jira/secure/attachment/12753783/task_infomartions.png)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 38056: Fix webui task informations not update bug.

2015-09-23 Thread haosdent huang


> On Sept. 23, 2015, 10:16 a.m., Philip Norman wrote:
> > Ship It!

Thank you. :-)


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38056/#review100182
---


On Sept. 16, 2015, 3:03 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38056/
> ---
> 
> (Updated Sept. 16, 2015, 3:03 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, Michael Park, and Philip 
> Norman.
> 
> 
> Bugs: MESOS-3282
> https://issues.apache.org/jira/browse/MESOS-3282
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix webui task informations not update bug.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/js/controllers.js 
> c4340ab94812433a2eadb1e5183b0765330cb844 
> 
> Diff: https://reviews.apache.org/r/38056/diff/
> 
> 
> Testing
> ---
> 
> Manual test, test scenarios:
> 
> * Normal scenarios updated after the new task is finished
> * After mesos-master down, could updated after reconnected
> 
> ![task_infomartions.png](https://issues.apache.org/jira/secure/attachment/12753783/task_infomartions.png)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 38056: Fix webui task informations not update bug.

2015-09-23 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38056/
---

(Updated Sept. 23, 2015, 2:03 p.m.)


Review request for mesos, Adam B, Joerg Schad, Michael Park, and Philip Norman.


Changes
---

Rebase


Bugs: MESOS-3282
https://issues.apache.org/jira/browse/MESOS-3282


Repository: mesos


Description
---

Fix webui task informations not update bug.


Diffs (updated)
-

  src/webui/master/static/js/controllers.js 
c4340ab94812433a2eadb1e5183b0765330cb844 

Diff: https://reviews.apache.org/r/38056/diff/


Testing
---

Manual test, test scenarios:

* Normal scenarios updated after the new task is finished
* After mesos-master down, could updated after reconnected

![task_infomartions.png](https://issues.apache.org/jira/secure/attachment/12753783/task_infomartions.png)


Thanks,

haosdent huang



Re: Review Request 38056: Fix webui task informations not update bug.

2015-09-23 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38056/#review100197
---


Patch looks great!

Reviews applied: [38056]

All tests passed.

- Mesos ReviewBot


On Sept. 23, 2015, 2:03 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38056/
> ---
> 
> (Updated Sept. 23, 2015, 2:03 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, Michael Park, and Philip 
> Norman.
> 
> 
> Bugs: MESOS-3282
> https://issues.apache.org/jira/browse/MESOS-3282
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix webui task informations not update bug.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/js/controllers.js 
> c4340ab94812433a2eadb1e5183b0765330cb844 
> 
> Diff: https://reviews.apache.org/r/38056/diff/
> 
> 
> Testing
> ---
> 
> Manual test, test scenarios:
> 
> * Normal scenarios updated after the new task is finished
> * After mesos-master down, could updated after reconnected
> 
> ![task_infomartions.png](https://issues.apache.org/jira/secure/attachment/12753783/task_infomartions.png)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 38056: Fix webui task informations not update bug.

2015-09-16 Thread Philip Norman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38056/#review99207
---



src/webui/master/static/js/controllers.js (line 217)


These metrics are not available on master, only directly from the slave 
nodes. 

The webui redirects the user to master, so these metrics will never be 
available in the UI, so I can't see a situation where this would work.

It's not clear to me how this data could be gathered from master, and it 
would be impractical to poll slaves directly, even assuming that the CORS 
restrictions were fixed.


- Philip Norman


On Sept. 14, 2015, 4:42 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38056/
> ---
> 
> (Updated Sept. 14, 2015, 4:42 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, and Michael Park.
> 
> 
> Bugs: MESOS-3282
> https://issues.apache.org/jira/browse/MESOS-3282
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix webui task informations not update bug.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/js/controllers.js 
> fbf86965efdb16f11787c24fb50d20af0837c62d 
> 
> Diff: https://reviews.apache.org/r/38056/diff/
> 
> 
> Testing
> ---
> 
> Manual test, test scenarios:
> 
> * Normal scenarios updated after the new task is finished
> * After mesos-master down, could updated after reconnected
> 
> ![task_infomartions.png](https://issues.apache.org/jira/secure/attachment/12753783/task_infomartions.png)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 38056: Fix webui task informations not update bug.

2015-09-16 Thread haosdent huang


> On Sept. 16, 2015, 10:41 a.m., Philip Norman wrote:
> > src/webui/master/static/js/controllers.js, line 224
> > 
> >
> > These metrics are not available on master, only directly from the slave 
> > nodes. 
> > 
> > The webui redirects the user to master, so these metrics will never be 
> > available in the UI, so I can't see a situation where this would work.
> > 
> > It's not clear to me how this data could be gathered from master, and 
> > it would be impractical to poll slaves directly, even assuming that the 
> > CORS restrictions were fixed.

Thank you very much for your review @philipnrmn . Yes, I need change 
s/slave/master. Because I use mesos-local when I debug this, it would start the 
master and slave at same network port. Let me update it.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38056/#review99207
---


On Sept. 14, 2015, 4:42 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38056/
> ---
> 
> (Updated Sept. 14, 2015, 4:42 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, and Michael Park.
> 
> 
> Bugs: MESOS-3282
> https://issues.apache.org/jira/browse/MESOS-3282
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix webui task informations not update bug.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/js/controllers.js 
> fbf86965efdb16f11787c24fb50d20af0837c62d 
> 
> Diff: https://reviews.apache.org/r/38056/diff/
> 
> 
> Testing
> ---
> 
> Manual test, test scenarios:
> 
> * Normal scenarios updated after the new task is finished
> * After mesos-master down, could updated after reconnected
> 
> ![task_infomartions.png](https://issues.apache.org/jira/secure/attachment/12753783/task_infomartions.png)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 38056: Fix webui task informations not update bug.

2015-09-16 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38056/
---

(Updated Sept. 16, 2015, 3:03 p.m.)


Review request for mesos, Adam B, Joerg Schad, Michael Park, and Philip Norman.


Changes
---

Update according @Philip Norman reviews, and test it under cluster mode.


Bugs: MESOS-3282
https://issues.apache.org/jira/browse/MESOS-3282


Repository: mesos


Description
---

Fix webui task informations not update bug.


Diffs (updated)
-

  src/webui/master/static/js/controllers.js 
c4340ab94812433a2eadb1e5183b0765330cb844 

Diff: https://reviews.apache.org/r/38056/diff/


Testing
---

Manual test, test scenarios:

* Normal scenarios updated after the new task is finished
* After mesos-master down, could updated after reconnected

![task_infomartions.png](https://issues.apache.org/jira/secure/attachment/12753783/task_infomartions.png)


Thanks,

haosdent huang



Re: Review Request 38056: Fix webui task informations not update bug.

2015-09-16 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38056/#review99229
---


Patch looks great!

Reviews applied: [38056]

All tests passed.

- Mesos ReviewBot


On Sept. 16, 2015, 3:03 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38056/
> ---
> 
> (Updated Sept. 16, 2015, 3:03 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, Michael Park, and Philip 
> Norman.
> 
> 
> Bugs: MESOS-3282
> https://issues.apache.org/jira/browse/MESOS-3282
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix webui task informations not update bug.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/js/controllers.js 
> c4340ab94812433a2eadb1e5183b0765330cb844 
> 
> Diff: https://reviews.apache.org/r/38056/diff/
> 
> 
> Testing
> ---
> 
> Manual test, test scenarios:
> 
> * Normal scenarios updated after the new task is finished
> * After mesos-master down, could updated after reconnected
> 
> ![task_infomartions.png](https://issues.apache.org/jira/secure/attachment/12753783/task_infomartions.png)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 38056: Fix webui task informations not update bug.

2015-09-10 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38056/
---

(Updated Sept. 10, 2015, 4:51 p.m.)


Review request for mesos, Adam B and Michael Park.


Changes
---

Rebase.


Bugs: MESOS-3282
https://issues.apache.org/jira/browse/MESOS-3282


Repository: mesos


Description
---

Fix webui task informations not update bug.


Diffs (updated)
-

  src/webui/master/static/js/controllers.js 
fbf86965efdb16f11787c24fb50d20af0837c62d 

Diff: https://reviews.apache.org/r/38056/diff/


Testing (updated)
---

Manual test, test scenarios:

* Normal scenarios updated after the new task is finished
* After mesos-master down, could updated after reconnected

![task_infomartions.png](https://issues.apache.org/jira/secure/attachment/12753783/task_infomartions.png)


Thanks,

haosdent huang



Re: Review Request 38056: Fix webui task informations not update bug.

2015-09-10 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38056/#review98425
---


Patch looks great!

Reviews applied: [38056]

All tests passed.

- Mesos ReviewBot


On Sept. 10, 2015, 4:51 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38056/
> ---
> 
> (Updated Sept. 10, 2015, 4:51 p.m.)
> 
> 
> Review request for mesos, Adam B and Michael Park.
> 
> 
> Bugs: MESOS-3282
> https://issues.apache.org/jira/browse/MESOS-3282
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix webui task informations not update bug.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/js/controllers.js 
> fbf86965efdb16f11787c24fb50d20af0837c62d 
> 
> Diff: https://reviews.apache.org/r/38056/diff/
> 
> 
> Testing
> ---
> 
> Manual test, test scenarios:
> 
> * Normal scenarios updated after the new task is finished
> * After mesos-master down, could updated after reconnected
> 
> ![task_infomartions.png](https://issues.apache.org/jira/secure/attachment/12753783/task_infomartions.png)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 38056: Fix webui task informations not update bug.

2015-09-02 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38056/#review97470
---


Patch looks great!

Reviews applied: [38056]

All tests passed.

- Mesos ReviewBot


On Sept. 2, 2015, 2:30 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38056/
> ---
> 
> (Updated Sept. 2, 2015, 2:30 p.m.)
> 
> 
> Review request for mesos, Adam B and Ross Allen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix webui task informations not update bug.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/js/controllers.js 
> 3445028138fd621d0e3a5427668c5eca7db5224f 
> 
> Diff: https://reviews.apache.org/r/38056/diff/
> 
> 
> Testing
> ---
> 
> Manual test, test scenarios:
> * Normal scenarios updated after the new task is finished
> * After mesos-master down, could updated after reconnected
> 
> 
> Thanks,
> 
> haosdent huang
> 
>