Re: Review Request 38077: [5/5] Integer Precision for JSON <-> Protobuf conversions.

2015-09-17 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38077/
---

(Updated Sept. 17, 2015, 12:14 p.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Timothy Chen, and Vinod Kone.


Changes
---

Re-opening with fixes for g++ 4.8/4.9 on CentOS 7.  (No changes other than 
rebase)


Bugs: MESOS-3345
https://issues.apache.org/jira/browse/MESOS-3345


Repository: mesos


Description
---

* Add TODO's for refactoring some JSON parsing in the docker code (See 
MESOS-3409).  Update how the JSON::Number is used.
* Tweak some tests to match changes to JSON::Number.
* Address a TODO on one test, which used a workaround for double-precision 
comparison.


Diffs (updated)
-

  src/docker/docker.cpp c4c37cb98ef50beeae0030ac472c7bf77e10fb5e 
  src/slave/containerizer/provisioner/docker/token_manager.cpp 
cf52626554f5bddcbbac4d515d7dd599d269dd57 
  src/tests/fault_tolerance_tests.cpp 061e0998239f7b69d989523e341881cd4abfcdeb 
  src/tests/master_tests.cpp dd65fccf89566b367fd0da781a60b6b6b35e5d5b 
  src/tests/monitor_tests.cpp f4049553d9f2b0e6419d9e6f88d3b0a54184f88d 
  src/tests/rate_limiting_tests.cpp f3aeddee00c7bb7905092aa8a760603468063126 
  src/tests/slave_tests.cpp 4a1a586f645424e30a4e989d1fd2f0bc2993b188 

Diff: https://reviews.apache.org/r/38077/diff/


Testing (updated)
---

`make check` (OSX | clang-6.1.0, CentOS 7.1 | g++ 4.8.3)


Thanks,

Joseph Wu



Re: Review Request 38077: [5/5] Integer Precision for JSON <-> Protobuf conversions.

2015-09-17 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38077/#review99433
---


Patch looks great!

Reviews applied: [38028, 38030, 38031, 38076, 38077]

All tests passed.

- Mesos ReviewBot


On Sept. 17, 2015, 7:14 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38077/
> ---
> 
> (Updated Sept. 17, 2015, 7:14 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Timothy Chen, and Vinod Kone.
> 
> 
> Bugs: MESOS-3345
> https://issues.apache.org/jira/browse/MESOS-3345
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> * Add TODO's for refactoring some JSON parsing in the docker code (See 
> MESOS-3409).  Update how the JSON::Number is used.
> * Tweak some tests to match changes to JSON::Number.
> * Address a TODO on one test, which used a workaround for double-precision 
> comparison.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.cpp c4c37cb98ef50beeae0030ac472c7bf77e10fb5e 
>   src/slave/containerizer/provisioner/docker/token_manager.cpp 
> cf52626554f5bddcbbac4d515d7dd599d269dd57 
>   src/tests/fault_tolerance_tests.cpp 
> 061e0998239f7b69d989523e341881cd4abfcdeb 
>   src/tests/master_tests.cpp dd65fccf89566b367fd0da781a60b6b6b35e5d5b 
>   src/tests/monitor_tests.cpp f4049553d9f2b0e6419d9e6f88d3b0a54184f88d 
>   src/tests/rate_limiting_tests.cpp f3aeddee00c7bb7905092aa8a760603468063126 
>   src/tests/slave_tests.cpp 4a1a586f645424e30a4e989d1fd2f0bc2993b188 
> 
> Diff: https://reviews.apache.org/r/38077/diff/
> 
> 
> Testing
> ---
> 
> `make check` (OSX | clang-6.1.0, CentOS 7.1 | g++ 4.8.3)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 38077: [5/5] Integer Precision for JSON <-> Protobuf conversions.

2015-09-11 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38077/
---

(Updated Sept. 11, 2015, 10:42 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Timothy Chen, and Vinod Kone.


Changes
---

Rebase due to test fix and merge conflict.


Bugs: MESOS-3345
https://issues.apache.org/jira/browse/MESOS-3345


Repository: mesos


Description
---

* Add TODO's for refactoring some JSON parsing in the docker code (See 
MESOS-3409).  Update how the JSON::Number is used.
* Tweak some tests to match changes to JSON::Number.
* Address a TODO on one test, which used a workaround for double-precision 
comparison.


Diffs (updated)
-

  src/docker/docker.cpp 553e831029454d6d423842915b8bbfcaf19fa7f9 
  src/slave/containerizer/provisioners/docker/token_manager.cpp 
aec915f25f6aada0a1d8f22d63a093bdbac97b25 
  src/tests/fault_tolerance_tests.cpp 89cb18be96cd60fb77fbcc4acd08cebdcf1ba075 
  src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
  src/tests/monitor_tests.cpp 53fb53eeea7d444ee043eb4569a52fead7ad0da8 
  src/tests/rate_limiting_tests.cpp f3aeddee00c7bb7905092aa8a760603468063126 
  src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102 

Diff: https://reviews.apache.org/r/38077/diff/


Testing
---

`make check`


Thanks,

Joseph Wu



Re: Review Request 38077: [5/5] Integer Precision for JSON <-> Protobuf conversions.

2015-09-11 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38077/#review98706
---


Patch looks great!

Reviews applied: [38028, 38030, 38031, 38076, 38077]

All tests passed.

- Mesos ReviewBot


On Sept. 11, 2015, 5:42 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38077/
> ---
> 
> (Updated Sept. 11, 2015, 5:42 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Timothy Chen, and Vinod Kone.
> 
> 
> Bugs: MESOS-3345
> https://issues.apache.org/jira/browse/MESOS-3345
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> * Add TODO's for refactoring some JSON parsing in the docker code (See 
> MESOS-3409).  Update how the JSON::Number is used.
> * Tweak some tests to match changes to JSON::Number.
> * Address a TODO on one test, which used a workaround for double-precision 
> comparison.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.cpp 553e831029454d6d423842915b8bbfcaf19fa7f9 
>   src/slave/containerizer/provisioners/docker/token_manager.cpp 
> aec915f25f6aada0a1d8f22d63a093bdbac97b25 
>   src/tests/fault_tolerance_tests.cpp 
> 89cb18be96cd60fb77fbcc4acd08cebdcf1ba075 
>   src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
>   src/tests/monitor_tests.cpp 53fb53eeea7d444ee043eb4569a52fead7ad0da8 
>   src/tests/rate_limiting_tests.cpp f3aeddee00c7bb7905092aa8a760603468063126 
>   src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102 
> 
> Diff: https://reviews.apache.org/r/38077/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 38077: [5/5] Integer Precision for JSON <-> Protobuf conversions.

2015-09-10 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38077/#review98512
---


The above reviewbot failure is related to the recently committed `/reserve` 
`/unreserve` endpoints.  (See https://reviews.apache.org/r/35984/)

@mcypark will have a fix shortly 
(https://issues.apache.org/jira/browse/MESOS-3411).

- Joseph Wu


On Sept. 10, 2015, 11:26 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38077/
> ---
> 
> (Updated Sept. 10, 2015, 11:26 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Timothy Chen, and Vinod Kone.
> 
> 
> Bugs: MESOS-3345
> https://issues.apache.org/jira/browse/MESOS-3345
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> * Add TODO's for refactoring some JSON parsing in the docker code (See 
> MESOS-3409).  Update how the JSON::Number is used.
> * Tweak some tests to match changes to JSON::Number.
> * Address a TODO on one test, which used a workaround for double-precision 
> comparison.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.cpp 553e831029454d6d423842915b8bbfcaf19fa7f9 
>   src/slave/containerizer/provisioners/docker/token_manager.cpp 
> aec915f25f6aada0a1d8f22d63a093bdbac97b25 
>   src/tests/fault_tolerance_tests.cpp 
> 89cb18be96cd60fb77fbcc4acd08cebdcf1ba075 
>   src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
>   src/tests/monitor_tests.cpp 53fb53eeea7d444ee043eb4569a52fead7ad0da8 
>   src/tests/rate_limiting_tests.cpp f3aeddee00c7bb7905092aa8a760603468063126 
>   src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102 
> 
> Diff: https://reviews.apache.org/r/38077/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 38077: [5/5] Integer Precision for JSON <-> Protobuf conversions.

2015-09-10 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38077/
---

(Updated Sept. 10, 2015, 11:26 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Timothy Chen, and Vinod Kone.


Changes
---

Update due to privatization of Number's fields.


Bugs: MESOS-3345
https://issues.apache.org/jira/browse/MESOS-3345


Repository: mesos


Description (updated)
---

* Add TODO's for refactoring some JSON parsing in the docker code (See 
MESOS-3409).  Update how the JSON::Number is used.
* Tweak some tests to match changes to JSON::Number.
* Address a TODO on one test, which used a workaround for double-precision 
comparison.


Diffs (updated)
-

  src/docker/docker.cpp 553e831029454d6d423842915b8bbfcaf19fa7f9 
  src/slave/containerizer/provisioners/docker/token_manager.cpp 
aec915f25f6aada0a1d8f22d63a093bdbac97b25 
  src/tests/fault_tolerance_tests.cpp 89cb18be96cd60fb77fbcc4acd08cebdcf1ba075 
  src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
  src/tests/monitor_tests.cpp 53fb53eeea7d444ee043eb4569a52fead7ad0da8 
  src/tests/rate_limiting_tests.cpp f3aeddee00c7bb7905092aa8a760603468063126 
  src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102 

Diff: https://reviews.apache.org/r/38077/diff/


Testing
---

`make check`


Thanks,

Joseph Wu



Re: Review Request 38077: [5/5] Integer Precision for JSON <-> Protobuf conversions.

2015-09-09 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38077/
---

(Updated Sept. 9, 2015, 3:20 p.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
and Vinod Kone.


Changes
---

Ready for wider review.


Summary (updated)
-

[5/5] Integer Precision for JSON <-> Protobuf conversions.


Repository: mesos


Description
---

Address a TODO on one test, which used a workaround for double-precision 
comparison.


Diffs (updated)
-

  src/tests/monitor_tests.cpp 53fb53eeea7d444ee043eb4569a52fead7ad0da8 

Diff: https://reviews.apache.org/r/38077/diff/


Testing
---

`make check`


Thanks,

Joseph Wu



Re: Review Request 38077: [5/5] Integer Precision for JSON <-> Protobuf conversions.

2015-09-09 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38077/#review98288
---

Ship it!


- Joris Van Remoortere


On Sept. 9, 2015, 10:20 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38077/
> ---
> 
> (Updated Sept. 9, 2015, 10:20 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Address a TODO on one test, which used a workaround for double-precision 
> comparison.
> 
> 
> Diffs
> -
> 
>   src/tests/monitor_tests.cpp 53fb53eeea7d444ee043eb4569a52fead7ad0da8 
> 
> Diff: https://reviews.apache.org/r/38077/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 38077: [5/5] Integer Precision for JSON <-> Protobuf conversions.

2015-09-09 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38077/#review98333
---


Patch looks great!

Reviews applied: [38028, 38030, 38031, 38076, 38077]

All tests passed.

- Mesos ReviewBot


On Sept. 9, 2015, 10:20 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38077/
> ---
> 
> (Updated Sept. 9, 2015, 10:20 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Address a TODO on one test, which used a workaround for double-precision 
> comparison.
> 
> 
> Diffs
> -
> 
>   src/tests/monitor_tests.cpp 53fb53eeea7d444ee043eb4569a52fead7ad0da8 
> 
> Diff: https://reviews.apache.org/r/38077/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>