Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review112650 --- Ship it! Looks good, just some minor items below that I'll

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review112234 --- The tests look great! Just a minor comment about Forbidden (sorry

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Dec. 14, 2015, 1:53 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Dec. 11, 2015, 3:01 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review109954 --- Ship it! 3rdparty/libprocess/src/authenticator.cpp (line 49)

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review110060 --- Thanks for the test, main question is why BasicAuthenticator is

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Dec. 10, 2015, 3:28 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review109305 --- 3rdparty/libprocess/src/tests/http_tests.cpp (line 1408)

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Dec. 7, 2015, 3:18 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review104381 --- 3rdparty/libprocess/include/process/authenticator.hpp (line 20)

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review109145 --- 3rdparty/libprocess/include/process/authenticator.hpp (line 26)

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Dec. 7, 2015, 4:02 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Dec. 7, 2015, 4:11 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review109154 --- Ship it! Ship It! - Till Toenshoff On Dec. 7, 2015, 3:11 p.m.,

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

> On Dec. 7, 2015, 3:22 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/authenticator.cpp, lines 25-26 > > > > > > I think `std::*`s go first. Not according to all the examples I checked, see

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

> On Dec. 7, 2015, 3:22 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/authenticator.cpp, lines 25-26 > > > > > > I think `std::*`s go first. > > Alexander Rojas wrote: > Not according to all the

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

> On Dec. 7, 2015, 2:22 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/authenticator.cpp, lines 25-26 > > > > > > I think `std::*`s go first. > > Alexander Rojas wrote: > Not according to all the

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

> On Dec. 7, 2015, 2:22 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/authenticator.cpp, lines 39-40 > > > > > > I see you use the same error message in case something is wrong. Is it > > done on

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review109213 --- 3rdparty/libprocess/src/tests/http_tests.cpp (line 1408)

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Nov. 17, 2015, 2:37 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Nov. 16, 2015, 5:26 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Nov. 16, 2015, 10:54 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Nov. 10, 2015, 5 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Nov. 9, 2015, 11:33 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Nov. 4, 2015, 12:29 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Oct. 21, 2015, 2:37 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review103235 --- 3rdparty/libprocess/src/authenticator.cpp (lines 81 - 84)

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Oct. 20, 2015, 2:07 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review103291 --- Sorry for not finding the below in the first pass ...

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review101130 --- Patch looks great! Reviews applied: [37714, 37996, 37997, 37998,

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Sept. 30, 2015, 10:21 a.m.) Review request for mesos, Adam B,

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Sept. 24, 2015, 12:33 p.m.) Review request for mesos, Adam B,

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review100398 --- Patch looks great! Reviews applied: [37714, 37996, 37997, 37998,

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review100188 --- Patch looks great! Reviews applied: [37714, 37996, 37997, 37998,

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Sept. 23, 2015, 1:17 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review100237 --- Can we please add this file to the CMakeLists.txt in

Re: Review Request 38094: Added implementation of Http Basic authentication scheme.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/ --- (Updated Sept. 23, 2015, 10:58 a.m.) Review request for mesos, Adam B,