Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-15 Thread Isabel Jimenez
> On Sept. 15, 2015, 10:40 p.m., Anand Mazumdar wrote: > > LGTM minus Two Nits: > > > > 1. Can we update the description of the review to just say that this change > > just copies the existing unversioned protobuf to the V1 namespace. > > 2. I am assuming that you would take care of Vinod's

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-15 Thread Isabel Jimenez
- Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review99117 --- On Sept. 15, 2015, 10:46 p.m., Isabel Jimenez wrote: >

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-15 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/ --- (Updated Sept. 15, 2015, 10:46 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review99156 --- Patch looks great! Reviews applied: [38278, 38143] All tests

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-15 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/ --- (Updated Sept. 15, 2015, 8:16 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-10 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/ --- (Updated Sept. 10, 2015, 11:38 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-10 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/ --- (Updated Sept. 10, 2015, 10:32 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-10 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/ --- (Updated Sept. 10, 2015, 11:33 p.m.) Review request for mesos, Adam B, Anand

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-10 Thread Isabel Jimenez
> On Sept. 10, 2015, 1:17 a.m., Vinod Kone wrote: > > include/mesos/v1/executor/executor.proto, lines 89-90 > > > > > > Much like with the scheduler, invalid calls result in BadRequest. We > > should really update

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review98326 --- most (if not all) comments here pertain to the unversioned

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-08 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review98047 --- Ship it! LGTM ! @gyliu : This change just moves the existing

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-05 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/ --- (Updated Sept. 5, 2015, 10:05 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-05 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review97872 --- include/mesos/v1/executor/executor.proto (line 47)

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-05 Thread Isabel Jimenez
> On Sept. 5, 2015, 3:28 a.m., Guangya Liu wrote: > > include/mesos/v1/executor/executor.proto, line 47 > > > > > > I think that the framework id need to be set when call "SUBSCRIBE" but > > not after "SUBSCRIBED"?

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-05 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review97880 --- Ship it! Thanks Isabel for the explanation! - Guangya Liu On 九月

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review97876 --- Patch looks great! Reviews applied: [38143] All tests passed. -

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-05 Thread Isabel Jimenez
> On Sept. 5, 2015, 3:28 a.m., Guangya Liu wrote: > > include/mesos/v1/executor/executor.proto, line 169 > > > > > > Do you mean that when type is Subscribe, there is no need to set any > > message? Why? I think

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review97846 --- include/mesos/v1/executor/executor.proto (line 47)

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review97847 --- Patch looks great! Reviews applied: [38143] All tests passed. -