Re: Review Request 38149: Add message_call_received metrics for master
> On 九月 9, 2015, 5:37 p.m., Vinod Kone wrote: > > What's the use case for this metric? For old style messages, we had per > > framework "messages_received" because it was used for rate limiting. I see there is a "// TODO(vinod): Add metrics for calls." in comments and also adding this metrics can help used to trace all of the call messages. Thanks. - Guangya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38149/#review98225 --- On 九月 9, 2015, 1:42 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38149/ > --- > > (Updated 九月 9, 2015, 1:42 a.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Add message_call_received metrics for master > > > Diffs > - > > src/master/master.cpp 5589eca4317b597de509f3387cfc349083b361ac > src/master/metrics.hpp 2d07a16f2dc6811973c82259c3cccff07401b542 > src/master/metrics.cpp d79206f08181c99641bef697be57b5d57b627285 > src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 > src/tests/metrics_tests.cpp 3e9d7c2eadfcdd2522d65e4a55dc76808ba39159 > > Diff: https://reviews.apache.org/r/38149/diff/ > > > Testing > --- > > > Thanks, > > Guangya Liu > >
Re: Review Request 38149: Add message_call_received metrics for master
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38149/#review98225 --- What's the use case for this metric? For old style messages, we had per framework "messages_received" because it was used for rate limiting. - Vinod Kone On Sept. 9, 2015, 1:42 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38149/ > --- > > (Updated Sept. 9, 2015, 1:42 a.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Add message_call_received metrics for master > > > Diffs > - > > src/master/master.cpp 5589eca4317b597de509f3387cfc349083b361ac > src/master/metrics.hpp 2d07a16f2dc6811973c82259c3cccff07401b542 > src/master/metrics.cpp d79206f08181c99641bef697be57b5d57b627285 > src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 > src/tests/metrics_tests.cpp 3e9d7c2eadfcdd2522d65e4a55dc76808ba39159 > > Diff: https://reviews.apache.org/r/38149/diff/ > > > Testing > --- > > > Thanks, > > Guangya Liu > >
Re: Review Request 38149: Add message_call_received metrics for master
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38149/#review98150 --- Patch looks great! Reviews applied: [38149] All tests passed. - Mesos ReviewBot On Sept. 9, 2015, 1:42 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38149/ > --- > > (Updated Sept. 9, 2015, 1:42 a.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Add message_call_received metrics for master > > > Diffs > - > > src/master/master.cpp 5589eca4317b597de509f3387cfc349083b361ac > src/master/metrics.hpp 2d07a16f2dc6811973c82259c3cccff07401b542 > src/master/metrics.cpp d79206f08181c99641bef697be57b5d57b627285 > src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 > src/tests/metrics_tests.cpp 3e9d7c2eadfcdd2522d65e4a55dc76808ba39159 > > Diff: https://reviews.apache.org/r/38149/diff/ > > > Testing > --- > > > Thanks, > > Guangya Liu > >
