Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant.

2015-10-14 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38161/#review102636 --- Ship it! Ship It! - Bernd Mathiske On Oct. 14, 2015, 8:51

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant.

2015-10-14 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38161/ --- (Updated Oct. 14, 2015, 3:51 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant.

2015-10-02 Thread Alexander Rukletsov
> On Oct. 1, 2015, 6:08 p.m., Ben Mahler wrote: > > src/tests/fault_tolerance_tests.cpp, lines 650-651 > > > > > > I don't think we need this second sentence, since the DEFAULT expresses > > this pretty clearly,

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant.

2015-10-02 Thread Alexander Rukletsov
> On Oct. 1, 2015, 6:08 p.m., Ben Mahler wrote: > > src/tests/fault_tolerance_tests.cpp, line 1540 > > > > > > I could have committed the `> >` flattening already for you if it was > > split, also, it would be be

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant.

2015-10-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38161/ --- (Updated Oct. 2, 2015, 3:13 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant.

2015-10-02 Thread Alexander Rukletsov
> On Oct. 1, 2015, 6:08 p.m., Ben Mahler wrote: > > src/tests/fault_tolerance_tests.cpp, lines 1547-1551 > > > > > > It looks inconsistent to do this here but not in the other tests this > > patch touches. Now

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant.

2015-10-02 Thread Ben Mahler
> On Oct. 1, 2015, 6:08 p.m., Ben Mahler wrote: > > src/tests/fault_tolerance_tests.cpp, lines 1547-1551 > > > > > > It looks inconsistent to do this here but not in the other tests this > > patch touches. Now

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant.

2015-10-01 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38161/ --- (Updated Oct. 1, 2015, 10:07 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant.

2015-10-01 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38161/#review101250 --- Thanks for the patience, almost there! Can we split the `> >`

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant and extended comments.

2015-09-30 Thread Alexander Rukletsov
> On Sept. 29, 2015, 7:12 p.m., Ben Mahler wrote: > > Thanks Alex, didn't realize I was on the reviewers here, so apologies for > > the delay! Why don't we just name the constant with DEFAULT to avoid the > > need for this and to make the meaning of the constant more clear? Sure, I'll rename

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant and extended comments.

2015-09-28 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38161/#review100821 --- Ship it! Ship It! - haosdent huang On Sept. 28, 2015, 5:08

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant and extended comments.

2015-09-28 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38161/ --- (Updated Sept. 28, 2015, 5:08 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant and extended comments.

2015-09-09 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38161/ --- (Updated Sept. 9, 2015, 2:27 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant and extended comments.

2015-09-09 Thread Alexander Rukletsov
> On Sept. 8, 2015, 2:30 p.m., Bernd Mathiske wrote: > > src/tests/fault_tolerance_tests.cpp, line 705 > > > > > > s/re-/ > > s/retry/ Let's keep "retry" for clarity (we send a second registration request). -

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant and extended comments.

2015-09-09 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38161/#review98191 --- Ship it! Ship It! - Guangya Liu On 九月 9, 2015, 2:27 p.m.,

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant and extended comments.

2015-09-08 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38161/#review98004 --- src/tests/fault_tolerance_tests.cpp (line 675)