Re: Review Request 38173: Stout: Simplified hashmap implementation.

2015-12-12 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38173/#review110081
---



3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp (lines 48 - 51)


Similar questions as in https://reviews.apache.org/r/38172/ regarding the 
specification of `bucket_size`. Here and below.


- Michael Park


On Sept. 8, 2015, 9:52 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38173/
> ---
> 
> (Updated Sept. 8, 2015, 9:52 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp 
> f09bea125035aa3621402b83608b233e42877559 
> 
> Diff: https://reviews.apache.org/r/38173/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 38173: Stout: Simplified hashmap implementation.

2015-09-08 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38173/#review98141
---


Patch looks great!

Reviews applied: [38171, 38172, 38173]

All tests passed.

- Mesos ReviewBot


On Sept. 8, 2015, 9:52 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38173/
> ---
> 
> (Updated Sept. 8, 2015, 9:52 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp 
> f09bea125035aa3621402b83608b233e42877559 
> 
> Diff: https://reviews.apache.org/r/38173/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 38173: Stout: Simplified hashmap implementation.

2015-09-08 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38173/
---

(Updated Sept. 8, 2015, 9:52 p.m.)


Review request for mesos and Michael Park.


Changes
---

updated chain.


Bugs: MESOS-3217
https://issues.apache.org/jira/browse/MESOS-3217


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp 
f09bea125035aa3621402b83608b233e42877559 

Diff: https://reviews.apache.org/r/38173/diff/


Testing
---

make check


Thanks,

Joris Van Remoortere