Re: Review Request 38329: Ensured that the device containing slave work_dir is a shared mount when LinuxFilesystemIsolator is used.

2015-09-13 Thread Jie Yu
> On Sept. 12, 2015, 6:38 a.m., Timothy Chen wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, line 91 > > > > > > Should we check we did successfully found one that we can mark shared? > > Jie Yu

Re: Review Request 38329: Ensured that the device containing slave work_dir is a shared mount when LinuxFilesystemIsolator is used.

2015-09-12 Thread Jie Yu
> On Sept. 12, 2015, 6:38 a.m., Timothy Chen wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, line 91 > > > > > > Should we check we did successfully found one that we can mark shared? > > Jie Yu

Re: Review Request 38329: Ensured that the device containing slave work_dir is a shared mount when LinuxFilesystemIsolator is used.

2015-09-12 Thread haosdent huang
> On Sept. 12, 2015, 6:38 a.m., Timothy Chen wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, line 91 > > > > > > Should we check we did successfully found one that we can mark shared? > > Jie Yu

Re: Review Request 38329: Ensured that the device containing slave work_dir is a shared mount when LinuxFilesystemIsolator is used.

2015-09-12 Thread Jie Yu
> On Sept. 12, 2015, 6:38 a.m., Timothy Chen wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, line 91 > > > > > > Should we check we did successfully found one that we can mark shared? > > Jie Yu

Re: Review Request 38329: Ensured that the device containing slave work_dir is a shared mount when LinuxFilesystemIsolator is used.

2015-09-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38329/#review98743 --- Ship it! Ship It!

Re: Review Request 38329: Ensured that the device containing slave work_dir is a shared mount when LinuxFilesystemIsolator is used.

2015-09-12 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38329/#review98735 --- src/slave/containerizer/isolators/filesystem/linux.cpp (line 91)

Re: Review Request 38329: Ensured that the device containing slave work_dir is a shared mount when LinuxFilesystemIsolator is used.

2015-09-12 Thread Jie Yu
> On Sept. 12, 2015, 6:38 a.m., Timothy Chen wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, line 91 > > > > > > Should we check we did successfully found one that we can mark shared? Good catch!

Re: Review Request 38329: Ensured that the device containing slave work_dir is a shared mount when LinuxFilesystemIsolator is used.

2015-09-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38329/ --- (Updated Sept. 12, 2015, 7:26 a.m.) Review request for mesos, haosdent huang,

Re: Review Request 38329: Ensured that the device containing slave work_dir is a shared mount when LinuxFilesystemIsolator is used.

2015-09-12 Thread haosdent huang
> On Sept. 12, 2015, 6:38 a.m., Timothy Chen wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, line 91 > > > > > > Should we check we did successfully found one that we can mark shared? > > Jie Yu

Re: Review Request 38329: Ensured that the device containing slave work_dir is a shared mount when LinuxFilesystemIsolator is used.

2015-09-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38329/#review98745 --- Patch looks great! Reviews applied: [38328, 38329] All tests