Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38335/ --- (Updated Nov. 4, 2015, 9:21 p.m.) Review request for mesos, Alexander

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38335/#review105065 --- Patch looks great! Reviews applied: [38342, 38335] All tests

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

> On Oct. 22, 2015, 8:53 p.m., Jan Schlicht wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 800 > > > > > > Not yours, but please s/push_back/emplace_back > > Michael Park wrote: > I'm curious

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38335/#review104964 --- Ship it! Please rebase and address the comment below and I can

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

> On Oct. 23, 2015, 4:53 a.m., Jan Schlicht wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 800 > > > > > > Not yours, but please s/push_back/emplace_back > > Michael Park wrote: > I'm curious

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38335/ --- (Updated Nov. 3, 2015, 9:38 p.m.) Review request for mesos, Alexander

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

> On Oct. 22, 2015, 8:53 p.m., Jan Schlicht wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 800 > > > > > > Not yours, but please s/push_back/emplace_back I'm curious as to what your reasoning is?

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

> On Sept. 29, 2015, 3:48 p.m., Alexander Rukletsov wrote: > > src/tests/mesos.hpp, line 1844 > > > > > > We tend not to use `typedef`s in the codebase. However, this looks like > > a good idea, but I would place

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38335/#review103655 --- Ship it! src/slave/containerizer/mesos/containerizer.cpp (line

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38335/ --- (Updated Oct. 20, 2015, 5:37 a.m.) Review request for mesos, Alexander

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

> On Sept. 29, 2015, 3:48 p.m., Alexander Rukletsov wrote: > > src/tests/mesos.hpp, line 1844 > > > > > > We tend not to use `typedef`s in the codebase. However, this looks like > > a good idea, but I would place

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38335/#review100961 --- src/master/http.cpp (lines 261 - 262)

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38335/ --- (Updated Sept. 24, 2015, 2:43 p.m.) Review request for mesos and Michael Park.

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38335/#review98771 --- Bad patch! Reviews applied: [38335] Failed command:

Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38335/ --- (Updated Sept. 14, 2015, 5:15 a.m.) Review request for mesos and Michael Park.