Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

2015-11-23 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38338/#review107695 --- Ship it! Ship It! - Timothy Chen On Oct. 3, 2015, 3:55 p.m.,

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

2015-10-04 Thread haosdent huang
> On Oct. 4, 2015, 2:09 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 463 > > > > > > Is it possible to add a unit test for this change? Because it depends on install and configure flocker in host, I not

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

2015-10-04 Thread haosdent huang
> On Oct. 4, 2015, 2:09 a.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 1443 > > > > > > Does v1 also needs to be updated? I notice we have some inconsistent between v1 and current proto, so I not

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

2015-10-04 Thread Guangya Liu
> On 十月 4, 2015, 2:09 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 463 > > > > > > Is it possible to add a unit test for this change? > > haosdent huang wrote: > Because it depends on install and

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

2015-10-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38338/ --- (Updated Oct. 3, 2015, 3:55 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

2015-10-03 Thread Vaibhav Khanduja
> On Sept. 25, 2015, 6:18 p.m., Timothy Chen wrote: > > Can you add a test for this logic? > > haosdent huang wrote: > Could, but because volume-driver depends on flocker, my test ideas for > this is verify the docker run command is correct. Docker also supports "local" as a volume

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

2015-10-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38338/#review101406 --- Patch looks great! Reviews applied: [38338] All tests passed. -

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

2015-10-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38338/#review101425 --- include/mesos/mesos.proto (line 1443)

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

2015-09-25 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38338/#review100643 --- Can you add a test for this logic? - Timothy Chen On Sept. 25,

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

2015-09-25 Thread haosdent huang
> On Sept. 25, 2015, 6:18 p.m., Timothy Chen wrote: > > Can you add a test for this logic? Could, but because volume-driver depends on flocker, my test ideas for this is verify the docker run command is correct. - haosdent --- This is

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

2015-09-24 Thread Vaibhav Khanduja
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38338/#review100494 --- src/docker/docker.cpp (line 422)

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

2015-09-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38338/ --- (Updated Sept. 25, 2015, 1:12 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

2015-09-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38338/#review100520 --- Patch looks great! Reviews applied: [38338] All tests passed. -

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

2015-09-24 Thread haosdent huang
> On Sept. 24, 2015, 11:28 p.m., Vaibhav Khanduja wrote: > > src/docker/docker.cpp, line 422 > > > > > > volumn - "volume" fixed. - haosdent --- This is

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

2015-09-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38338/#review98779 --- Patch looks great! Reviews applied: [38338] All tests passed. -