Re: Review Request 38343: mesos: Fixed punctuation in log message.

2015-09-14 Thread Niklas Nielsen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38343/#review98878
---

Ship it!


Ship It!

- Niklas Nielsen


On Sept. 13, 2015, 10:09 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38343/
> ---
> 
> (Updated Sept. 13, 2015, 10:09 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Niklas Nielsen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Per style guide, log messages should not end in a period.
> 
> 
> Diffs
> -
> 
>   src/authentication/cram_md5/authenticator.cpp 
> f751ee15a8e8fa47b645d4add0ebe457fa5b49fb 
> 
> Diff: https://reviews.apache.org/r/38343/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Re: Review Request 38343: mesos: Fixed punctuation in log message.

2015-09-13 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38343/#review98815
---


Patch looks great!

Reviews applied: [38343]

All tests passed.

- Mesos ReviewBot


On Sept. 14, 2015, 5:09 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38343/
> ---
> 
> (Updated Sept. 14, 2015, 5:09 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Niklas Nielsen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Per style guide, log messages should not end in a period.
> 
> 
> Diffs
> -
> 
>   src/authentication/cram_md5/authenticator.cpp 
> f751ee15a8e8fa47b645d4add0ebe457fa5b49fb 
> 
> Diff: https://reviews.apache.org/r/38343/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Re: Review Request 38343: mesos: Fixed punctuation in log message.

2015-09-13 Thread Klaus Ma

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38343/#review98813
---

Ship it!


Ship It!

- Klaus Ma


On Sept. 14, 2015, 5:09 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38343/
> ---
> 
> (Updated Sept. 14, 2015, 5:09 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Niklas Nielsen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Per style guide, log messages should not end in a period.
> 
> 
> Diffs
> -
> 
>   src/authentication/cram_md5/authenticator.cpp 
> f751ee15a8e8fa47b645d4add0ebe457fa5b49fb 
> 
> Diff: https://reviews.apache.org/r/38343/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>