Re: Review Request 38347: Add HELP Message for Reserve/Unreserve endpoint

2015-09-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38347/#review99641 --- Patch looks great! Reviews applied: [38347] All tests passed. -

Re: Review Request 38347: Add HELP Message for Reserve/Unreserve endpoint

2015-09-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38347/#review99585 --- Bad patch! Reviews applied: [38347] Failed command:

Re: Review Request 38347: Add HELP Message for Reserve/Unreserve endpoint

2015-09-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38347/#review99574 --- src/master/http.cpp (line 669)

Re: Review Request 38347: Add HELP Message for Reserve/Unreserve endpoint

2015-09-15 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38347/#review99010 --- src/master/http.cpp (line 670)

Re: Review Request 38347: Add HELP Message for Reserve/Unreserve endpoint

2015-09-15 Thread haosdent huang
> On Sept. 15, 2015, 11:23 a.m., haosdent huang wrote: > > src/master/http.cpp, line 670 > > > > > > Could you also document the parameters about the reserve/unreserve > > endpoints? For example: /logging endpoint

Re: Review Request 38347: Add HELP Message for Reserve/Unreserve endpoint

2015-09-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38347/ --- (Updated Sept. 15, 2015, 12:56 p.m.) Review request for mesos and Michael

Re: Review Request 38347: Add HELP Message for Reserve/Unreserve endpoint

2015-09-15 Thread Guangya Liu
> On Sept. 15, 2015, 11:23 a.m., haosdent huang wrote: > > src/master/http.cpp, line 670 > > > > > > Could you also document the parameters about the reserve/unreserve > > endpoints? For example: /logging endpoint

Re: Review Request 38347: Add HELP Message for Reserve/Unreserve endpoint

2015-09-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38347/ --- (Updated Sept. 15, 2015, 1:04 p.m.) Review request for mesos and Michael Park.