Re: Review Request 38382: Fixed the perf event isolator to continue sampling in the presence of failures.

2015-09-15 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38382/#review99046
---


Bad patch!

Reviews applied: [38377]

Failed command: ./support/apply-review.sh -n -r 38377

Error:
 2015-09-15 17:09:14 URL:https://reviews.apache.org/r/38377/diff/raw/ 
[1009/1009] -> "38377.patch" [1]
error: patch failed: src/slave/containerizer/isolators/cgroups/perf_event.cpp:46
error: src/slave/containerizer/isolators/cgroups/perf_event.cpp: patch does not 
apply
Failed to apply patch

- Mesos ReviewBot


On Sept. 14, 2015, 10:57 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38382/
> ---
> 
> (Updated Sept. 14, 2015, 10:57 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3423
> https://issues.apache.org/jira/browse/MESOS-3423
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See [MESOS-3423](https://issues.apache.org/jira/browse/MESOS-3423).
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 7dc8b7a99074b74ade019ef4df296780650a2e4e 
> 
> Diff: https://reviews.apache.org/r/38382/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 38382: Fixed the perf event isolator to continue sampling in the presence of failures.

2015-09-14 Thread Ben Mahler 


> On Sept. 14, 2015, 11:38 p.m., Cong Wang wrote:
> > src/slave/containerizer/isolators/cgroups/perf_event.cpp, line 413
> > 
> >
> > s/sampling will be halted// ?

Great catch, thank you!


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38382/#review98959
---


On Sept. 14, 2015, 10:57 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38382/
> ---
> 
> (Updated Sept. 14, 2015, 10:57 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3423
> https://issues.apache.org/jira/browse/MESOS-3423
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See [MESOS-3423](https://issues.apache.org/jira/browse/MESOS-3423).
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 7dc8b7a99074b74ade019ef4df296780650a2e4e 
> 
> Diff: https://reviews.apache.org/r/38382/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 38382: Fixed the perf event isolator to continue sampling in the presence of failures.

2015-09-14 Thread Cong Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38382/#review98959
---



src/slave/containerizer/isolators/cgroups/perf_event.cpp (line 411)


s/sampling will be halted// ?


- Cong Wang


On Sept. 14, 2015, 10:57 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38382/
> ---
> 
> (Updated Sept. 14, 2015, 10:57 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3423
> https://issues.apache.org/jira/browse/MESOS-3423
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See [MESOS-3423](https://issues.apache.org/jira/browse/MESOS-3423).
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 7dc8b7a99074b74ade019ef4df296780650a2e4e 
> 
> Diff: https://reviews.apache.org/r/38382/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 38382: Fixed the perf event isolator to continue sampling in the presence of failures.

2015-09-14 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38382/#review98956
---

Ship it!


Ship It!

- Jie Yu


On Sept. 14, 2015, 10:57 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38382/
> ---
> 
> (Updated Sept. 14, 2015, 10:57 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3423
> https://issues.apache.org/jira/browse/MESOS-3423
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See [MESOS-3423](https://issues.apache.org/jira/browse/MESOS-3423).
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 7dc8b7a99074b74ade019ef4df296780650a2e4e 
> 
> Diff: https://reviews.apache.org/r/38382/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>