Re: Review Request 38447: Implemented a TODO to clean up host mounts irrelevant to the container in the container's mount namespace.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38447/#review99457
---


Bad patch!

Reviews applied: [38447]

Failed command: ./support/apply-review.sh -n -r 38447

Error:
 2015-09-17 22:37:55 URL:https://reviews.apache.org/r/38447/diff/raw/ 
[17738/17738] -> "38447.patch" [1]
error: patch failed: src/slave/containerizer/isolators/filesystem/linux.hpp:100
error: src/slave/containerizer/isolators/filesystem/linux.hpp: patch does not 
apply
error: patch failed: src/slave/containerizer/isolators/filesystem/linux.cpp:360
error: src/slave/containerizer/isolators/filesystem/linux.cpp: patch does not 
apply
error: patch failed: src/tests/containerizer/filesystem_isolator_tests.cpp:26
error: src/tests/containerizer/filesystem_isolator_tests.cpp: patch does not 
apply
Failed to apply patch

- Mesos ReviewBot


On Sept. 17, 2015, 10:03 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38447/
> ---
> 
> (Updated Sept. 17, 2015, 10:03 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3433
> https://issues.apache.org/jira/browse/MESOS-3433
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented a TODO to clean up host mounts irrelevant to the container in the 
> container's mount namespace.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 
> 99f939f8b254cf71b4c1c7829b5fa37abdc2771b 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> b6746345b70b462123c3254065e4f09a42f45e5b 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> ca9f423d5f2f8f838c3371ee596f07537bb45210 
> 
> Diff: https://reviews.apache.org/r/38447/diff/
> 
> 
> Testing
> ---
> 
> Added a test that is not specific for this but observed successful cleanup of 
> the other container's mounts in logs.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 38447: Implemented a TODO to clean up host mounts irrelevant to the container in the container's mount namespace.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38447/#review99451
---

Ship it!


Ship It!

- Jie Yu


On Sept. 17, 2015, 10:03 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38447/
> ---
> 
> (Updated Sept. 17, 2015, 10:03 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3433
> https://issues.apache.org/jira/browse/MESOS-3433
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented a TODO to clean up host mounts irrelevant to the container in the 
> container's mount namespace.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 
> 99f939f8b254cf71b4c1c7829b5fa37abdc2771b 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> b6746345b70b462123c3254065e4f09a42f45e5b 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> ca9f423d5f2f8f838c3371ee596f07537bb45210 
> 
> Diff: https://reviews.apache.org/r/38447/diff/
> 
> 
> Testing
> ---
> 
> Added a test that is not specific for this but observed successful cleanup of 
> the other container's mounts in logs.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 38447: Implemented a TODO to clean up host mounts irrelevant to the container in the container's mount namespace.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38447/
---

(Updated Sept. 17, 2015, 3:03 p.m.)


Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.


Changes
---

Minor style fix.


Bugs: MESOS-3433
https://issues.apache.org/jira/browse/MESOS-3433


Repository: mesos


Description
---

Implemented a TODO to clean up host mounts irrelevant to the container in the 
container's mount namespace.


Diffs (updated)
-

  src/slave/containerizer/isolators/filesystem/linux.hpp 
99f939f8b254cf71b4c1c7829b5fa37abdc2771b 
  src/slave/containerizer/isolators/filesystem/linux.cpp 
b6746345b70b462123c3254065e4f09a42f45e5b 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
ca9f423d5f2f8f838c3371ee596f07537bb45210 

Diff: https://reviews.apache.org/r/38447/diff/


Testing
---

Added a test that is not specific for this but observed successful cleanup of 
the other container's mounts in logs.


Thanks,

Jiang Yan Xu

Re: Review Request 38447: Implemented a TODO to clean up host mounts irrelevant to the container in the container's mount namespace.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38447/
---

(Updated Sept. 17, 2015, 2:58 p.m.)


Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.


Changes
---

The previous version had a bug which caused unable to clean up multiple mounts 
and it masked another issue in filesystem tests that rootfses are not put under 
a directory with the container ID in its path. This caused some mounts such as 
the persistent volumes which belonged to the same container to be mistakenly 
cleaned up!


Bugs: MESOS-3433
https://issues.apache.org/jira/browse/MESOS-3433


Repository: mesos


Description
---

Implemented a TODO to clean up host mounts irrelevant to the container in the 
container's mount namespace.


Diffs (updated)
-

  src/slave/containerizer/isolators/filesystem/linux.hpp 
99f939f8b254cf71b4c1c7829b5fa37abdc2771b 
  src/slave/containerizer/isolators/filesystem/linux.cpp 
b6746345b70b462123c3254065e4f09a42f45e5b 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
ca9f423d5f2f8f838c3371ee596f07537bb45210 

Diff: https://reviews.apache.org/r/38447/diff/


Testing
---

Added a test that is not specific for this but observed successful cleanup of 
the other container's mounts in logs.


Thanks,

Jiang Yan Xu

Re: Review Request 38447: Implemented a TODO to clean up host mounts irrelevant to the container in the container's mount namespace.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38447/#review99359
---


Patch looks great!

Reviews applied: [38447]

All tests passed.

- Mesos ReviewBot


On Sept. 17, 2015, 6:22 a.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38447/
> ---
> 
> (Updated Sept. 17, 2015, 6:22 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3433
> https://issues.apache.org/jira/browse/MESOS-3433
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented a TODO to clean up host mounts irrelevant to the container in the 
> container's mount namespace.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 
> 99f939f8b254cf71b4c1c7829b5fa37abdc2771b 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> b6746345b70b462123c3254065e4f09a42f45e5b 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> ca9f423d5f2f8f838c3371ee596f07537bb45210 
> 
> Diff: https://reviews.apache.org/r/38447/diff/
> 
> 
> Testing
> ---
> 
> Added a test that is not specific for this but observed successful cleanup of 
> the other container's mounts in logs.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 38447: Implemented a TODO to clean up host mounts irrelevant to the container in the container's mount namespace.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38447/#review99357
---

Ship it!



src/slave/containerizer/isolators/filesystem/linux.cpp (lines 363 - 366)


Thanks for fixing this!



src/slave/containerizer/isolators/filesystem/linux.cpp (line 409)


No need for this variable, right?

```
out << "xxx" << xxx
<< ...
```

looks more natural to me.



src/slave/containerizer/isolators/filesystem/linux.cpp (line 411)


single quote as well?


- Jie Yu


On Sept. 17, 2015, 6:22 a.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38447/
> ---
> 
> (Updated Sept. 17, 2015, 6:22 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3433
> https://issues.apache.org/jira/browse/MESOS-3433
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented a TODO to clean up host mounts irrelevant to the container in the 
> container's mount namespace.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 
> 99f939f8b254cf71b4c1c7829b5fa37abdc2771b 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> b6746345b70b462123c3254065e4f09a42f45e5b 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> ca9f423d5f2f8f838c3371ee596f07537bb45210 
> 
> Diff: https://reviews.apache.org/r/38447/diff/
> 
> 
> Testing
> ---
> 
> Added a test that is not specific for this but observed successful cleanup of 
> the other container's mounts in logs.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>