Re: Review Request 38452: Updated C++ style guide for namespace usage

2015-09-29 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38452/ --- (Updated 九月 29, 2015, 11:04 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38452: Updated C++ style guide for namespace usage

2015-09-29 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38452/#review101044 --- Ship it! Thanks! I'll get this committed shortly.

Re: Review Request 38452: Updated C++ style guide for namespace usage

2015-09-29 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38452/#review101041 --- Ship it! Thanks for your patience! Just a couple of cleanups and

Re: Review Request 38452: Updated C++ style guide for namespace usage

2015-09-29 Thread Guangya Liu
> On 九月 29, 2015, 11:30 p.m., Ben Mahler wrote: > > docs/mesos-c++-style-guide.md, lines 41-45 > > > > > > To mirror the google style guide, can we place this before 'Naming'? Done > On 九月 29, 2015, 11:30 p.m.,

Re: Review Request 38452: Updated C++ style guide for namespace usage

2015-09-29 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38452/ --- (Updated 九月 29, 2015, 11:43 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38452: Updated C++ style guide for namespace usage

2015-09-29 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38452/#review101038 --- docs/mesos-c++-style-guide.md (lines 41 - 43)

Re: Review Request 38452: Updated C++ style guide for namespace usage

2015-09-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38452/#review100240 --- It seems good to qualify how we're different from the google style

Re: Review Request 38452: Updated C++ style guide for namespace usage

2015-09-23 Thread Guangya Liu
> On 九月 23, 2015, 5:47 p.m., Ben Mahler wrote: > > It seems good to qualify how we're different from the google style guide > > here. It seems the main difference is that we avoid the using statements > > inside functions / classes for the most part. > > > > Also not your fault but we're

Re: Review Request 38452: Updated C++ style guide for namespace usage

2015-09-23 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38452/ --- (Updated 九月 24, 2015, 2:20 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38452: Updated C++ style guide for namespace usage

2015-09-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38452/#review99363 --- Patch looks great! Reviews applied: [38452] All tests passed. -