Re: Review Request 38475: Maintenance Primitives: Add test for inverse offer filters.

2015-09-20 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38475/#review99687
---

Ship it!



src/tests/master_maintenance_tests.cpp (lines 1230 - 1231)


It seems like we could add an accessor to the master to get a `const` 
reference to the flags?
Want to make a JIRA for this?



src/tests/master_maintenance_tests.cpp (lines 1236 - 1237)


I ran into some non-deterministic behavior repeatedly running this test.
Please see the slight changes I made, as well as the subsequent commit to 
the TestContainerizer.



src/tests/master_maintenance_tests.cpp (lines 1261 - 1275)


Let's make sure both slaves register before we schedule the machine for 
maintenance mode.


- Joris Van Remoortere


On Sept. 19, 2015, 6:14 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38475/
> ---
> 
> (Updated Sept. 19, 2015, 6:14 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3346
> https://issues.apache.org/jira/browse/MESOS-3346
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Checks that filters change which inverse offer is sent when.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> 9892bc329ff850f638e9f5e79d047efaf2fcb037 
> 
> Diff: https://reviews.apache.org/r/38475/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 38475: Maintenance Primitives: Add test for inverse offer filters.

2015-09-19 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38475/
---

(Updated Sept. 19, 2015, 6:14 p.m.)


Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Bugs: MESOS-3346
https://issues.apache.org/jira/browse/MESOS-3346


Repository: mesos


Description
---

Checks that filters change which inverse offer is sent when.


Diffs
-

  src/tests/master_maintenance_tests.cpp 
9892bc329ff850f638e9f5e79d047efaf2fcb037 

Diff: https://reviews.apache.org/r/38475/diff/


Testing
---

`make check`


Thanks,

Joseph Wu

Re: Review Request 38475: Maintenance Primitives: Add test for inverse offer filters.

2015-09-18 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38475/#review99631
---


Patch looks great!

Reviews applied: [38244, 38246, 38324, 38475]

All tests passed.

- Mesos ReviewBot


On Sept. 18, 2015, 10 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38475/
> ---
> 
> (Updated Sept. 18, 2015, 10 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Checks that filters change which inverse offer is sent when.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> 9892bc329ff850f638e9f5e79d047efaf2fcb037 
> 
> Diff: https://reviews.apache.org/r/38475/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 38475: Maintenance Primitives: Add test for inverse offer filters.

2015-09-18 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38475/
---

(Updated Sept. 18, 2015, 3 p.m.)


Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Changes
---

Update a TODO.  Add some minor comments.


Repository: mesos


Description
---

Checks that filters change which inverse offer is sent when.


Diffs (updated)
-

  src/tests/master_maintenance_tests.cpp 
9892bc329ff850f638e9f5e79d047efaf2fcb037 

Diff: https://reviews.apache.org/r/38475/diff/


Testing
---

`make check`


Thanks,

Joseph Wu