Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-10-13 Thread Guangya Liu
> On 十月 13, 2015, 2:52 a.m., Guangya Liu wrote: > > src/slave/slave.cpp, line 394 > > > > > > I have one question for this after second review: I see that in > > slave.cpp, most APIs are calling

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-10-13 Thread Niklas Nielsen
> On Oct. 12, 2015, 7:52 p.m., Guangya Liu wrote: > > src/slave/slave.cpp, line 394 > > > > > > I have one question for this after second review: I see that in > > slave.cpp, most APIs are calling

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-10-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38564/#review102473 --- Ship it! Ship It! - Guangya Liu On 十月 13, 2015, 1:39 a.m.,

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-10-12 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38564/#review102362 --- Ship it! Mind rebasing this, Felix? :) We can land this after

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-10-12 Thread Felix Abecassis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38564/ --- (Updated Oct. 13, 2015, 1:39 a.m.) Review request for mesos, Connor Doyle and

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-10-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38564/#review102380 --- src/slave/slave.cpp (line 394)

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-10-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38564/#review102383 --- Patch looks great! Reviews applied: [38279, 38517, 38564] All

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38564/#review99934 --- Ship it! Ship It! - Guangya Liu On 九月 22, 2015, 6:05 a.m.,

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-22 Thread Guangya Liu
> On 九月 21, 2015, 10:08 p.m., Guangya Liu wrote: > > I think that you need make this patch depend on > > https://reviews.apache.org/r/38279/ to make this works. > > Felix Abecassis wrote: > Thank you, I hope it's fixed now. I see that this patch is depending on

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-22 Thread Felix Abecassis
> On Sept. 21, 2015, 10:08 p.m., Guangya Liu wrote: > > I think that you need make this patch depend on > > https://reviews.apache.org/r/38279/ to make this works. > > Felix Abecassis wrote: > Thank you, I hope it's fixed now. > > Guangya Liu wrote: > I see that this patch is

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38564/#review99962 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Felix Abecassis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38564/ --- (Updated Sept. 22, 2015, 1:40 a.m.) Review request for mesos. Bugs:

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Felix Abecassis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38564/ --- (Updated Sept. 21, 2015, 11:22 p.m.) Review request for mesos. Bugs:

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Felix Abecassis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38564/ --- (Updated Sept. 22, 2015, 12:16 a.m.) Review request for mesos. Bugs:

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38564/#review99890 --- Ship it! include/mesos/hook.hpp (lines 25 - 27)

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Connor Doyle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38564/#review99846 --- include/mesos/hook.hpp (line 129)

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Felix Abecassis
> On Sept. 21, 2015, 10:08 p.m., Guangya Liu wrote: > > I think that you need make this patch depend on > > https://reviews.apache.org/r/38279/ to make this works. Thank you, I hope it's fixed now. - Felix --- This is an automatically

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Felix Abecassis
> On Sept. 21, 2015, 11:27 p.m., Connor Doyle wrote: > > include/mesos/hook.hpp, line 129 > > > > > > Missing definite article: "within the slave". I wanted to add it, but the hooks above don't. I know, that's not

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38564/#review99841 --- I think that you need make this patch depend on