Re: Review Request 38575: Added masterSlaveLostHook

2015-09-23 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38575/#review100221
---

Ship it!


Ship It!

- haosdent huang


On Sept. 21, 2015, 10:40 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38575/
> ---
> 
> (Updated Sept. 21, 2015, 10:40 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Kapil Arya.
> 
> 
> Bugs: MESOS-3015
> https://issues.apache.org/jira/browse/MESOS-3015
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a new masterSlaveLost hook to enable modules to clean up 
> after lost slaves events (as in networking modules, where we want to avoid 
> leaking IPs).
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 2353602c8ac8b89e3fa86bda7d1e262a3debef80 
>   src/examples/test_hook_module.cpp 0dc74d60576af6f88cbdc1c9a6f82348c5761d2f 
>   src/hook/manager.hpp a517c05855b07831a9728c1191243d114781b70a 
>   src/hook/manager.cpp 691976e94d5ac9fe4f8ba583214f24900d14248c 
>   src/master/master.cpp 90ef8c663c90ffbdcb4aa2377bfba65ea5d3fda9 
>   src/tests/hook_tests.cpp b23a587c683c391ca860b3b7d876902987f4d158 
> 
> Diff: https://reviews.apache.org/r/38575/diff/
> 
> 
> Testing
> ---
> 
> make check with new masterSlaveLostHook test
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 38575: Added masterSlaveLostHook

2015-09-23 Thread Niklas Nielsen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38575/
---

(Updated Sept. 23, 2015, 3:24 p.m.)


Review request for mesos, Joris Van Remoortere and Kapil Arya.


Changes
---

Addressed comments from Joris (offline) and Kapil


Bugs: MESOS-3015
https://issues.apache.org/jira/browse/MESOS-3015


Repository: mesos


Description
---

This patch adds a new masterSlaveLost hook to enable modules to clean up after 
lost slaves events (as in networking modules, where we want to avoid leaking 
IPs).


Diffs (updated)
-

  include/mesos/hook.hpp 2353602c8ac8b89e3fa86bda7d1e262a3debef80 
  src/examples/test_hook_module.cpp 0dc74d60576af6f88cbdc1c9a6f82348c5761d2f 
  src/hook/manager.hpp a517c05855b07831a9728c1191243d114781b70a 
  src/hook/manager.cpp 691976e94d5ac9fe4f8ba583214f24900d14248c 
  src/master/master.cpp 5ca19412f5e654a8e1e265559a809cfaa2a59014 
  src/tests/hook_tests.cpp b23a587c683c391ca860b3b7d876902987f4d158 

Diff: https://reviews.apache.org/r/38575/diff/


Testing
---

make check with new masterSlaveLostHook test


Thanks,

Niklas Nielsen

Re: Review Request 38575: Added masterSlaveLostHook

2015-09-23 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38575/#review100308
---

Ship it!


Ship It!

- Joris Van Remoortere


On Sept. 23, 2015, 10:24 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38575/
> ---
> 
> (Updated Sept. 23, 2015, 10:24 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Kapil Arya.
> 
> 
> Bugs: MESOS-3015
> https://issues.apache.org/jira/browse/MESOS-3015
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a new masterSlaveLost hook to enable modules to clean up 
> after lost slaves events (as in networking modules, where we want to avoid 
> leaking IPs).
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 2353602c8ac8b89e3fa86bda7d1e262a3debef80 
>   src/examples/test_hook_module.cpp 0dc74d60576af6f88cbdc1c9a6f82348c5761d2f 
>   src/hook/manager.hpp a517c05855b07831a9728c1191243d114781b70a 
>   src/hook/manager.cpp 691976e94d5ac9fe4f8ba583214f24900d14248c 
>   src/master/master.cpp 5ca19412f5e654a8e1e265559a809cfaa2a59014 
>   src/tests/hook_tests.cpp b23a587c683c391ca860b3b7d876902987f4d158 
> 
> Diff: https://reviews.apache.org/r/38575/diff/
> 
> 
> Testing
> ---
> 
> make check with new masterSlaveLostHook test
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 38575: Added masterSlaveLostHook

2015-09-21 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38575/#review99920
---


Patch looks great!

Reviews applied: [38574, 38575]

All tests passed.

- Mesos ReviewBot


On Sept. 21, 2015, 10:40 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38575/
> ---
> 
> (Updated Sept. 21, 2015, 10:40 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Kapil Arya.
> 
> 
> Bugs: MESOS-3015
> https://issues.apache.org/jira/browse/MESOS-3015
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a new masterSlaveLost hook to enable modules to clean up 
> after lost slaves events (as in networking modules, where we want to avoid 
> leaking IPs).
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 2353602c8ac8b89e3fa86bda7d1e262a3debef80 
>   src/examples/test_hook_module.cpp 0dc74d60576af6f88cbdc1c9a6f82348c5761d2f 
>   src/hook/manager.hpp a517c05855b07831a9728c1191243d114781b70a 
>   src/hook/manager.cpp 691976e94d5ac9fe4f8ba583214f24900d14248c 
>   src/master/master.cpp 90ef8c663c90ffbdcb4aa2377bfba65ea5d3fda9 
>   src/tests/hook_tests.cpp b23a587c683c391ca860b3b7d876902987f4d158 
> 
> Diff: https://reviews.apache.org/r/38575/diff/
> 
> 
> Testing
> ---
> 
> make check with new masterSlaveLostHook test
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 38575: Added masterSlaveLostHook

2015-09-21 Thread Kapil Arya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38575/#review99885
---

Ship it!


LGTM module some minor language fixes for comments/log.


src/hook/manager.cpp (line 141)


s/slave lost/slave-lost/ (?)



src/tests/hook_tests.cpp (line 243)


s/ yet././


- Kapil Arya


On Sept. 21, 2015, 6:40 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38575/
> ---
> 
> (Updated Sept. 21, 2015, 6:40 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Kapil Arya.
> 
> 
> Bugs: MESOS-3015
> https://issues.apache.org/jira/browse/MESOS-3015
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a new masterSlaveLost hook to enable modules to clean up 
> after lost slaves events (as in networking modules, where we want to avoid 
> leaking IPs).
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 2353602c8ac8b89e3fa86bda7d1e262a3debef80 
>   src/examples/test_hook_module.cpp 0dc74d60576af6f88cbdc1c9a6f82348c5761d2f 
>   src/hook/manager.hpp a517c05855b07831a9728c1191243d114781b70a 
>   src/hook/manager.cpp 691976e94d5ac9fe4f8ba583214f24900d14248c 
>   src/master/master.cpp 90ef8c663c90ffbdcb4aa2377bfba65ea5d3fda9 
>   src/tests/hook_tests.cpp b23a587c683c391ca860b3b7d876902987f4d158 
> 
> Diff: https://reviews.apache.org/r/38575/diff/
> 
> 
> Testing
> ---
> 
> make check with new masterSlaveLostHook test
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 38575: Added masterSlaveLostHook

2015-09-21 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38575/#review99871
---



include/mesos/hook.hpp (line 66)


Do we need to update slave to agent in other comments introduced by this 
patch?


- Guangya Liu


On 九月 21, 2015, 10:40 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38575/
> ---
> 
> (Updated 九月 21, 2015, 10:40 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Kapil Arya.
> 
> 
> Bugs: MESOS-3015
> https://issues.apache.org/jira/browse/MESOS-3015
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a new masterSlaveLost hook to enable modules to clean up 
> after lost slaves events (as in networking modules, where we want to avoid 
> leaking IPs).
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 2353602c8ac8b89e3fa86bda7d1e262a3debef80 
>   src/examples/test_hook_module.cpp 0dc74d60576af6f88cbdc1c9a6f82348c5761d2f 
>   src/hook/manager.hpp a517c05855b07831a9728c1191243d114781b70a 
>   src/hook/manager.cpp 691976e94d5ac9fe4f8ba583214f24900d14248c 
>   src/master/master.cpp 90ef8c663c90ffbdcb4aa2377bfba65ea5d3fda9 
>   src/tests/hook_tests.cpp b23a587c683c391ca860b3b7d876902987f4d158 
> 
> Diff: https://reviews.apache.org/r/38575/diff/
> 
> 
> Testing
> ---
> 
> make check with new masterSlaveLostHook test
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 38575: Added masterSlaveLostHook

2015-09-21 Thread Niklas Nielsen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38575/
---

(Updated Sept. 21, 2015, 3:40 p.m.)


Review request for mesos, Joris Van Remoortere and Kapil Arya.


Bugs: MESOS-3015
https://issues.apache.org/jira/browse/MESOS-3015


Repository: mesos


Description (updated)
---

This patch adds a new masterSlaveLost hook to enable modules to clean up after 
lost slaves events (as in networking modules, where we want to avoid leaking 
IPs).


Diffs
-

  include/mesos/hook.hpp 2353602c8ac8b89e3fa86bda7d1e262a3debef80 
  src/examples/test_hook_module.cpp 0dc74d60576af6f88cbdc1c9a6f82348c5761d2f 
  src/hook/manager.hpp a517c05855b07831a9728c1191243d114781b70a 
  src/hook/manager.cpp 691976e94d5ac9fe4f8ba583214f24900d14248c 
  src/master/master.cpp 90ef8c663c90ffbdcb4aa2377bfba65ea5d3fda9 
  src/tests/hook_tests.cpp b23a587c683c391ca860b3b7d876902987f4d158 

Diff: https://reviews.apache.org/r/38575/diff/


Testing
---

make check with new masterSlaveLostHook test


Thanks,

Niklas Nielsen