Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-10-27 Thread Vinod Kone
> On Oct. 27, 2015, 1:13 a.m., Vinod Kone wrote: > > src/slave/validation.cpp, line 75 > > > > > > also print status.source() > > Isabel Jimenez wrote: > We don't have a stringify for this. > > Anand Mazumdar

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-10-26 Thread Isabel Jimenez
> On Oct. 27, 2015, 1:13 a.m., Vinod Kone wrote: > > src/slave/validation.hpp, line 31 > > > > > > why space here? Added it there after a review comment. > On Oct. 27, 2015, 1:13 a.m., Vinod Kone wrote: > >

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-10-26 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- (Updated Oct. 27, 2015, 12:23 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-10-26 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- (Updated Oct. 27, 2015, 1:20 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-10-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review104123 --- Ship it! src/slave/validation.hpp (line 19)

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-10-26 Thread Anand Mazumdar
> On Oct. 27, 2015, 1:13 a.m., Vinod Kone wrote: > > src/slave/validation.cpp, line 75 > > > > > > also print status.source() > > Isabel Jimenez wrote: > We don't have a stringify for this. Why not implement

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-10-05 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- (Updated Oct. 5, 2015, 3:54 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-10-02 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- (Updated Oct. 2, 2015, 6:42 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-29 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- (Updated Sept. 29, 2015, 8 a.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-29 Thread Alex Clemmer
> On Sept. 25, 2015, 6:52 p.m., Vinod Kone wrote: > > src/Makefile.am, line 501 > > > > > > I think you'll make Alex happy if you also update the corresponding > > CMake file(s). > > Isabel Jimenez wrote: > We

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-29 Thread Alex Clemmer
> On Sept. 25, 2015, 6:52 p.m., Vinod Kone wrote: > > src/Makefile.am, line 501 > > > > > > I think you'll make Alex happy if you also update the corresponding > > CMake file(s). > > Isabel Jimenez wrote: > We

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-29 Thread Isabel Jimenez
> On Sept. 29, 2015, 8:29 p.m., Anand Mazumdar wrote: > > src/slave/validation.cpp, line 57 > > > > > > Sorry for the ping pong iterations on this but noticed another missing > > validation check for `Call::UPDATE`

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-29 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- (Updated Sept. 29, 2015, 9:25 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-29 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review101078 --- Thanks Isabel, this looks pretty neat now. Just some minor cleanup

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-29 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- (Updated Sept. 29, 2015, 8:15 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-29 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review101003 --- src/slave/validation.cpp (line 57)

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-29 Thread Isabel Jimenez
> On Sept. 25, 2015, 6:52 p.m., Vinod Kone wrote: > > src/Makefile.am, line 501 > > > > > > I think you'll make Alex happy if you also update the corresponding > > CMake file(s). > > Isabel Jimenez wrote: > We

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-25 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review100682 --- src/slave/validation.cpp (line 52)

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-25 Thread Isabel Jimenez
> On Sept. 25, 2015, 6:52 p.m., Vinod Kone wrote: > > src/slave/validation.hpp, line 36 > > > > > > Can you please add tests in this patch? Adding tests in a separate dependant patch. - Isabel

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review100653 --- src/Makefile.am (line 501)

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-25 Thread Isabel Jimenez
> On Sept. 25, 2015, 6:52 p.m., Vinod Kone wrote: > > src/Makefile.am, line 501 > > > > > > I think you'll make Alex happy if you also update the corresponding > > CMake file(s). We don't have cmake support for

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-22 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- (Updated Sept. 22, 2015, 9:46 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-22 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- (Updated Sept. 22, 2015, 9:43 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review99974 --- Patch looks great! Reviews applied: [38618, 38577] All tests

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-22 Thread Isabel Jimenez
> On Sept. 22, 2015, 1:08 a.m., Anand Mazumdar wrote: > > src/slave/validation.hpp, line 28 > > > > > > newline before. I am expecting other people to add slave validation > > code in this file too in the future. So

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-21 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review99886 --- LGTM, thanks for working on this Isabel ! Waiting for some