Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

2015-09-23 Thread Niklas Nielsen
> On Sept. 23, 2015, 1:46 a.m., Timothy Chen wrote: > > src/linux/systemd.cpp, line 54 > > > > > > Just tried to run this in CentOS 7 and I couldn't find /bin/systemd, > > but systemd is running. I see :/ So either

Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

2015-09-23 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38634/#review100155 --- src/linux/systemd.cpp (line 38)

Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

2015-09-23 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38634/#review100168 --- src/linux/systemd.cpp (line 54)

Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

2015-09-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38634/#review100303 --- src/slave/containerizer/linux_launcher.cpp (line 81)

Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

2015-09-23 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38634/ --- (Updated Sept. 23, 2015, 8:34 p.m.) Review request for mesos, Benjamin

Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

2015-09-23 Thread Joris Van Remoortere
> On Sept. 23, 2015, 2:19 a.m., Artem Harutyunyan wrote: > > src/linux/systemd.cpp, line 38 > > > > > > I agree with Nik, stat() would work just fine here. using realpath. changed the detection logic. - Joris

Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

2015-09-23 Thread Joris Van Remoortere
> On Sept. 23, 2015, 8:46 a.m., Timothy Chen wrote: > > src/slave/containerizer/linux_launcher.cpp, line 108 > > > > > > Where does it create and start? Next patch :-) - Joris

Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

2015-09-23 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38634/ --- (Updated Sept. 24, 2015, 3:39 a.m.) Review request for mesos, Benjamin

Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

2015-09-23 Thread Joris Van Remoortere
> On Sept. 23, 2015, 8:46 a.m., Timothy Chen wrote: > > src/linux/systemd.cpp, line 54 > > > > > > Just tried to run this in CentOS 7 and I couldn't find /bin/systemd, > > but systemd is running. > > Niklas Nielsen

Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

2015-09-23 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38634/#review100310 --- Ship it! Ship It! src/linux/systemd.cpp (line 86)

Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

2015-09-23 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38634/ --- (Updated Sept. 23, 2015, 10:59 p.m.) Review request for mesos, Benjamin

Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

2015-09-23 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38634/#review100330 --- Ship it! src/linux/systemd.cpp (line 59)

Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

2015-09-22 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38634/#review100120 --- src/linux/systemd.cpp (line 38)

Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

2015-09-22 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38634/ --- (Updated Sept. 23, 2015, 1:48 a.m.) Review request for mesos, Benjamin