Re: Review Request 38660: Restore Linux/Posix launcher creation logic for MesosContainerizer.

2015-09-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38660/#review100146 --- To fix the ExampleTests, you may want to force to use

Re: Review Request 38660: Restore Linux/Posix launcher creation logic for MesosContainerizer.

2015-09-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38660/#review100148 --- Ship it! Ship It!

Re: Review Request 38660: Restore Linux/Posix launcher creation logic for MesosContainerizer.

2015-09-23 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38660/#review100302 --- src/slave/flags.cpp (line 62)

Re: Review Request 38660: Restore Linux/Posix launcher creation logic for MesosContainerizer.

2015-09-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38660/ --- (Updated Sept. 23, 2015, 5:46 p.m.) Review request for mesos, haosdent huang

Re: Review Request 38660: Restore Linux/Posix launcher creation logic for MesosContainerizer.

2015-09-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38660/#review100298 --- Ship it! Ship It! - Jie Yu On Sept. 23, 2015, 9:46 p.m., Kapil

Re: Review Request 38660: Restore Linux/Posix launcher creation logic for MesosContainerizer.

2015-09-23 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38660/#review100312 --- This can also fix Artem's failing CI with Docker too. - Timothy

Re: Review Request 38660: Restore Linux/Posix launcher creation logic for MesosContainerizer.

2015-09-23 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38660/#review100311 --- Ship it! Ship It! - Timothy Chen On Sept. 23, 2015, 10:44

Re: Review Request 38660: Restore Linux/Posix launcher creation logic for MesosContainerizer.

2015-09-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38660/ --- (Updated Sept. 23, 2015, 6:44 p.m.) Review request for mesos, haosdent huang

Re: Review Request 38660: Restore Linux/Posix launcher creation logic for MesosContainerizer.

2015-09-23 Thread Kapil Arya
> On Sept. 23, 2015, 6:15 p.m., Cong Wang wrote: > > src/slave/flags.cpp, line 62 > > > > > > Document it in docs/configuration.md too? Created a new RR: https://reviews.apache.org/r/38697/ - Kapil

Re: Review Request 38660: Restore Linux/Posix launcher creation logic for MesosContainerizer.

2015-09-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38660/#review100131 --- Hi, @kapil The flaky test you metioned is a known issue.

Re: Review Request 38660: Restore Linux/Posix launcher creation logic for MesosContainerizer.

2015-09-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38660/#review100142 --- Patch looks great! Reviews applied: [38660] All tests passed. -