Re: Review Request 38697: Updated documentation strings for --launcher flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38697/#review100439 --- Ship it! Ship It! - Jie Yu On Sept. 24, 2015, 6:44 a.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38697/ > --- > > (Updated Sept. 24, 2015, 6:44 a.m.) > > > Review request for mesos, Jie Yu and Niklas Nielsen. > > > Bugs: MESOS-3508 > https://issues.apache.org/jira/browse/MESOS-3508 > > > Repository: mesos > > > Description > --- > > Updated documentation strings for --launcher flag. > > > Diffs > - > > docs/configuration.md dd7f4aa806a3c1a8653a0fda9a326a3707308e7c > src/slave/flags.cpp 6164b4bae3f1b74da87f01a6db934f265e1a0117 > > Diff: https://reviews.apache.org/r/38697/diff/ > > > Testing > --- > > Viewed in help message as well as markdown viewer. > > > Thanks, > > Kapil Arya > >
Re: Review Request 38697: Updated documentation strings for --launcher flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38697/ --- (Updated Sept. 24, 2015, 2:44 a.m.) Review request for mesos, Jie Yu and Niklas Nielsen. Changes --- removed depedency Bugs: MESOS-3508 https://issues.apache.org/jira/browse/MESOS-3508 Repository: mesos Description --- Updated documentation strings for --launcher flag. Diffs - docs/configuration.md dd7f4aa806a3c1a8653a0fda9a326a3707308e7c src/slave/flags.cpp 6164b4bae3f1b74da87f01a6db934f265e1a0117 Diff: https://reviews.apache.org/r/38697/diff/ Testing --- Viewed in help message as well as markdown viewer. Thanks, Kapil Arya
Re: Review Request 38697: Updated documentation strings for --launcher flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38697/ --- (Updated Sept. 24, 2015, 2:44 a.m.) Review request for mesos, Jie Yu and Niklas Nielsen. Changes --- updated bug. Bugs: MESOS-3508 https://issues.apache.org/jira/browse/MESOS-3508 Repository: mesos Description --- Updated documentation strings for --launcher flag. Diffs - docs/configuration.md dd7f4aa806a3c1a8653a0fda9a326a3707308e7c src/slave/flags.cpp 6164b4bae3f1b74da87f01a6db934f265e1a0117 Diff: https://reviews.apache.org/r/38697/diff/ Testing --- Viewed in help message as well as markdown viewer. Thanks, Kapil Arya
Re: Review Request 38697: Updated documentation strings for --launcher flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38697/#review100359 --- Bad patch! Reviews applied: [38660] Failed command: ./support/apply-review.sh -n -r 38660 Error: 2015-09-24 04:29:00 URL:https://reviews.apache.org/r/38660/diff/raw/ [3536/3536] -> "38660.patch" [1] error: patch failed: src/slave/containerizer/mesos/containerizer.cpp:215 error: src/slave/containerizer/mesos/containerizer.cpp: patch does not apply error: patch failed: src/slave/flags.hpp:46 error: src/slave/flags.hpp: patch does not apply error: patch failed: src/slave/flags.cpp:59 error: src/slave/flags.cpp: patch does not apply error: patch failed: src/tests/test_framework_test.sh:30 error: src/tests/test_framework_test.sh: patch does not apply Failed to apply patch - Mesos ReviewBot On Sept. 24, 2015, 1:50 a.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38697/ > --- > > (Updated Sept. 24, 2015, 1:50 a.m.) > > > Review request for mesos, Jie Yu and Niklas Nielsen. > > > Bugs: MESOS-3451 > https://issues.apache.org/jira/browse/MESOS-3451 > > > Repository: mesos > > > Description > --- > > Updated documentation strings for --launcher flag. > > > Diffs > - > > docs/configuration.md dd7f4aa806a3c1a8653a0fda9a326a3707308e7c > src/slave/flags.cpp 6164b4bae3f1b74da87f01a6db934f265e1a0117 > > Diff: https://reviews.apache.org/r/38697/diff/ > > > Testing > --- > > Viewed in help message as well as markdown viewer. > > > Thanks, > > Kapil Arya > >
Re: Review Request 38697: Updated documentation strings for --launcher flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38697/#review100350 --- Ship it! Ship It! - Guangya Liu On 九月 24, 2015, 1:50 a.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38697/ > --- > > (Updated 九月 24, 2015, 1:50 a.m.) > > > Review request for mesos, Jie Yu and Niklas Nielsen. > > > Bugs: MESOS-3451 > https://issues.apache.org/jira/browse/MESOS-3451 > > > Repository: mesos > > > Description > --- > > Updated documentation strings for --launcher flag. > > > Diffs > - > > docs/configuration.md dd7f4aa806a3c1a8653a0fda9a326a3707308e7c > src/slave/flags.cpp 6164b4bae3f1b74da87f01a6db934f265e1a0117 > > Diff: https://reviews.apache.org/r/38697/diff/ > > > Testing > --- > > Viewed in help message as well as markdown viewer. > > > Thanks, > > Kapil Arya > >
Re: Review Request 38697: Updated documentation strings for --launcher flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38697/#review100343 --- Ship it! Ship It! - Cong Wang On Sept. 24, 2015, 1:50 a.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38697/ > --- > > (Updated Sept. 24, 2015, 1:50 a.m.) > > > Review request for mesos, Jie Yu and Niklas Nielsen. > > > Bugs: MESOS-3451 > https://issues.apache.org/jira/browse/MESOS-3451 > > > Repository: mesos > > > Description > --- > > Updated documentation strings for --launcher flag. > > > Diffs > - > > docs/configuration.md dd7f4aa806a3c1a8653a0fda9a326a3707308e7c > src/slave/flags.cpp 6164b4bae3f1b74da87f01a6db934f265e1a0117 > > Diff: https://reviews.apache.org/r/38697/diff/ > > > Testing > --- > > Viewed in help message as well as markdown viewer. > > > Thanks, > > Kapil Arya > >
Re: Review Request 38697: Updated documentation strings for --launcher flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38697/ --- (Updated Sept. 23, 2015, 9:50 p.m.) Review request for mesos, Jie Yu and Niklas Nielsen. Changes --- rebased Bugs: MESOS-3451 https://issues.apache.org/jira/browse/MESOS-3451 Repository: mesos Description --- Updated documentation strings for --launcher flag. Diffs (updated) - docs/configuration.md dd7f4aa806a3c1a8653a0fda9a326a3707308e7c src/slave/flags.cpp 6164b4bae3f1b74da87f01a6db934f265e1a0117 Diff: https://reviews.apache.org/r/38697/diff/ Testing --- Viewed in help message as well as markdown viewer. Thanks, Kapil Arya
Re: Review Request 38697: Updated documentation strings for --launcher flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38697/#review100331 --- Bad patch! Reviews applied: [38660] Failed command: ./support/apply-review.sh -n -r 38660 Error: 2015-09-24 00:39:43 URL:https://reviews.apache.org/r/38660/diff/raw/ [3536/3536] -> "38660.patch" [1] error: patch failed: src/slave/containerizer/mesos/containerizer.cpp:215 error: src/slave/containerizer/mesos/containerizer.cpp: patch does not apply error: patch failed: src/slave/flags.hpp:46 error: src/slave/flags.hpp: patch does not apply error: patch failed: src/slave/flags.cpp:59 error: src/slave/flags.cpp: patch does not apply error: patch failed: src/tests/test_framework_test.sh:30 error: src/tests/test_framework_test.sh: patch does not apply Failed to apply patch - Mesos ReviewBot On Sept. 23, 2015, 10:45 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38697/ > --- > > (Updated Sept. 23, 2015, 10:45 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-3451 > https://issues.apache.org/jira/browse/MESOS-3451 > > > Repository: mesos > > > Description > --- > > Updated documentation strings for --launcher flag. > > > Diffs > - > > docs/configuration.md dd7f4aa806a3c1a8653a0fda9a326a3707308e7c > src/slave/flags.cpp add4196dfd06c0f602ff5ebd39960dc05c4cd11f > > Diff: https://reviews.apache.org/r/38697/diff/ > > > Testing > --- > > Viewed in help message as well as markdown viewer. > > > Thanks, > > Kapil Arya > >