Re: Review Request 38729: Do not retry close on EINTR.

[Ben Mahler]

> On Sept. 24, 2015, 8:55 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/src/subprocess.cpp, line 133
> > 
> >
> > Should we wrap it with #ifdef linux?

Sadly, it is more involved than just an ifdef :(

For example, on OS X: 
https://code.google.com/p/chromium/issues/detail?id=269623 and the change here 
https://codereview.chromium.org/23455051/
On Linux the no retry logic is correct, although it seems the glibc wrapper 
makes it cancelable: 
https://code.google.com/p/chromium/issues/detail?id=269623#c13


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38729/#review100463
---


On Sept. 24, 2015, 7:41 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38729/
> ---
> 
> (Updated Sept. 24, 2015, 7:41 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3512
> https://issues.apache.org/jira/browse/MESOS-3512
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See: https://issues.apache.org/jira/browse/MESOS-3512
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/subprocess.cpp 
> d6ea62ed1c914d34e0e189395831c86fff8aac22 
> 
> Diff: https://reviews.apache.org/r/38729/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 38729: Do not retry close on EINTR.

[Jie Yu]

> On Sept. 24, 2015, 8:55 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/src/subprocess.cpp, line 133
> > 
> >
> > Should we wrap it with #ifdef linux?
> 
> Ben Mahler wrote:
> Sadly, it is more involved than just an ifdef :(
> 
> For example, on OS X: 
> https://code.google.com/p/chromium/issues/detail?id=269623 and the change 
> here https://codereview.chromium.org/23455051/
> On Linux the no retry logic is correct, although it seems the glibc 
> wrapper makes it cancelable: 
> https://code.google.com/p/chromium/issues/detail?id=269623#c13

ok, looks like OSX is more complicated:(


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38729/#review100463
---


On Sept. 24, 2015, 7:41 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38729/
> ---
> 
> (Updated Sept. 24, 2015, 7:41 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3512
> https://issues.apache.org/jira/browse/MESOS-3512
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See: https://issues.apache.org/jira/browse/MESOS-3512
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/subprocess.cpp 
> d6ea62ed1c914d34e0e189395831c86fff8aac22 
> 
> Diff: https://reviews.apache.org/r/38729/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 38729: Do not retry close on EINTR.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38729/#review100472
---

Ship it!


Ship It!

- Vinod Kone


On Sept. 24, 2015, 7:41 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38729/
> ---
> 
> (Updated Sept. 24, 2015, 7:41 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3512
> https://issues.apache.org/jira/browse/MESOS-3512
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See: https://issues.apache.org/jira/browse/MESOS-3512
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/subprocess.cpp 
> d6ea62ed1c914d34e0e189395831c86fff8aac22 
> 
> Diff: https://reviews.apache.org/r/38729/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 38729: Do not retry close on EINTR.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38729/#review100463
---



3rdparty/libprocess/src/subprocess.cpp (line 133)


Should we wrap it with #ifdef linux?


- Jie Yu


On Sept. 24, 2015, 7:41 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38729/
> ---
> 
> (Updated Sept. 24, 2015, 7:41 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3512
> https://issues.apache.org/jira/browse/MESOS-3512
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See: https://issues.apache.org/jira/browse/MESOS-3512
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/subprocess.cpp 
> d6ea62ed1c914d34e0e189395831c86fff8aac22 
> 
> Diff: https://reviews.apache.org/r/38729/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>