Re: Review Request 38770: routing: fixed a file descriptor leak.

2015-09-25 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38770/ --- (Updated Sept. 25, 2015, 8:33 p.m.) Review request for mesos, Ben Mahler, Jie Y

Re: Review Request 38770: routing: fixed a file descriptor leak.

2015-09-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38770/#review100675 --- Patch looks great! Reviews applied: [38770] All tests passed. -

Re: Review Request 38770: routing: fixed a file descriptor leak.

2015-09-25 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38770/#review100670 --- Ship it! Thanks! Would you mind tracking these under a ticket to c

Re: Review Request 38770: routing: fixed a file descriptor leak.

2015-09-25 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38770/#review100661 --- Ship it! Or you can do unconditionally os::close() after that ioct

Re: Review Request 38770: routing: fixed a file descriptor leak.

2015-09-25 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38770/ --- (Updated Sept. 25, 2015, 7:07 p.m.) Review request for mesos, Ben Mahler, Jie Y