Re: Review Request 38793: CMake: Transition to CMake-based build system for GMock/GTest.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38793/#review100783 --- Ship it! Ship It! - Joris Van Remoortere On Sept. 26, 2015, 10:58 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38793/ > --- > > (Updated Sept. 26, 2015, 10:58 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > --- > > CMake: Transition to CMake-based build system for GMock/GTest. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/CMakeLists.txt > b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d > 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake > 9e4dcb83a8cc4e95a2a38573944f6b38e2eac76e > > Diff: https://reviews.apache.org/r/38793/diff/ > > > Testing > --- > > Compiled and ran made sure libprocess and stout tests ran and passed on the > following platforms: > > * OS X 10.10 > * Ubuntu 14.04.2 > > > Thanks, > > Alex Clemmer > >
Re: Review Request 38793: CMake: Transition to CMake-based build system for GMock/GTest.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38793/#review100767 --- Patch looks great! Reviews applied: [38456, 38457, 38529, 38530, 38531, 38538, 38539, 38540, 38541, 38542, 38549, 38550, 38551, 38552, 38751, 38752, 38753, 38754, 38755, 38756, 38793] All tests passed. - Mesos ReviewBot On Sept. 26, 2015, 10:58 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38793/ > --- > > (Updated Sept. 26, 2015, 10:58 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > --- > > CMake: Transition to CMake-based build system for GMock/GTest. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/CMakeLists.txt > b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d > 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake > 9e4dcb83a8cc4e95a2a38573944f6b38e2eac76e > > Diff: https://reviews.apache.org/r/38793/diff/ > > > Testing > --- > > Compiled and ran made sure libprocess and stout tests ran and passed on the > following platforms: > > * OS X 10.10 > * Ubuntu 14.04.2 > > > Thanks, > > Alex Clemmer > >