Re: Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling.

2015-09-29 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38828/#review100966 --- Ship it! Ship It! - Timothy Chen On Sept. 29, 2015, 12:50

Re: Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling.

2015-09-29 Thread Ben Mahler
> On Sept. 29, 2015, 1:17 a.m., Timothy Chen wrote: > > src/slave/containerizer/docker.cpp, lines 926-928 > > > > > > Hey I think we should be doing the same behavior as MesosContainerizer > > since the executor

Re: Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling.

2015-09-28 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38828/#review100908 --- src/slave/containerizer/docker.cpp

Re: Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling.

2015-09-28 Thread Chi Zhang
> On Sept. 29, 2015, 12:31 a.m., Ben Mahler wrote: > > src/slave/containerizer/docker.cpp, lines 926-928 > > > > > > I believe these were in place to terminate the subprocess, so perhaps a > > killtree with SIGTERM

Re: Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling.

2015-09-28 Thread Chi Zhang
> On Sept. 29, 2015, 12:31 a.m., Ben Mahler wrote: > > src/slave/containerizer/docker.cpp, lines 926-928 > > > > > > I believe these were in place to terminate the subprocess, so perhaps a > > killtree with SIGTERM

Re: Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling.

2015-09-28 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38828/#review100913 --- src/slave/containerizer/docker.cpp